]> git.koha-community.org Git - koha.git/commit
Bug 36956: Allow all providers to be displayed in reports
authorMatt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Tue, 28 May 2024 10:39:33 +0000 (10:39 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 17 Jul 2024 14:26:00 +0000 (16:26 +0200)
commit564af1451a1b9f7f8a28ecc80c418b0a293df6d7
tree5947c3b06736250045b11f7e66d24caaecf264ea
parenta19842abc3049d068a761f798b3f5807d3f7ec38
Bug 36956: Allow all providers to be displayed in reports

This patch fixes an incorrect usage of the API which was only returning 20 results.

Test plan:
1) Go to ERM module and make sure you have more than 20 data providers stored in your database.
1) (Optional) Run the following command (k-t-d) to create 21 data providers:
  perl -MKoha::Database -e '
      my $schema = Koha::Database->schema;

      $schema->resultset("ErmUsageDataProvider")->create({
          name => "name ".$_
      }) for (1..21)
  '
2) Go to eUsage / reports and create new report (cgi-bin/koha/erm/eusage/reports)
3) Check that only the first 20 data providers are displayed in the drop down
4) Apply patch
5) yarn build or reset_all to rebuild the javascript
6) Repeat steps 1-3, all providers should now be displayed

PA amended patch: Updated commit message test plan

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 6afe1e14dc0e42b34ed57e9c29637ef8edbe24ab)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 642acf7566fc53676d491db7a6ba604b5bdfe88b)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/intranet-tmpl/prog/js/vue/fetch/erm-api-client.js