]> git.koha-community.org Git - koha.git/commit
Bug 14184: Undefined $term causes noisy warns in C4/CourseReserves.pm
authorAleisha <aleishaamohia@hotmail.com>
Tue, 12 May 2015 02:08:17 +0000 (02:08 +0000)
committerChris Cormack <chrisc@catalyst.net.nz>
Wed, 27 May 2015 08:03:37 +0000 (20:03 +1200)
commit598a1525e5150d793b7e504ce61b9cbaa8bf80a2
tree59f9094cacbd7b22b3f8089e7f40db16118b4c35
parent85f81150570926931339813422b8e0feff3430ca
Bug 14184: Undefined $term causes noisy warns in C4/CourseReserves.pm

This patch sets $term to be an empty string.

Test plan
=========

1/ enable 'UseCourseReserves' syspref in Circulation preferences
2/ in a terminal, run a `tail -f ` on your instance's opac-error.log
3/ go to the opac, click on 'Course reserve' tab to go to
   opac-course-reserves.pl
4/ notice the warning - "opac-course-reserves.pl: Use of uninitialized
   value $term" appear in the `tail`ed opac-error.log
5/ apply the patch
6/ reload the page (opac-course-reserves.pl)
7/ page works but the warning in step #4 is no longer logged
8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error

Remarks: Testing result match expected test plan output. The QA tests
         pass with "OK" for the commit.

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 4f994e8baf3ffd209f6a0a85993039f753ec6e32)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
C4/CourseReserves.pm