From 3d4fd9b2c6603fe4b5f96a7e90f9f6ad68e2356e Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Tue, 28 Nov 2023 14:58:04 +0000
Subject: [PATCH] Bug 35413: Terminology: Manage issues (issue_manage)

This patch updates several files which use the term "issues" without
context, changing them to "Vendor issues." Unchanged is the vendor
issues page template, vendor_issues.tt, which is updated in Bug 35417.

To test, apply the patch and go to Acquisitions.

- Search for a vendor and view the details.
- You should see a "Vendor issues" link in the sidebar.
- Go to Patrons and search for a patron. View the patron's details.
- Click More -> Set permissions.
- Under Acquisitions management you should see "Manage vendor issues
  (issue_manage)"

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit b6c71bea4e0a92523f881151c5fbe556eee7eab8)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 installer/data/mysql/mandatory/userpermissions.sql       | 2 +-
 koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc | 2 +-
 koha-tmpl/intranet-tmpl/prog/en/includes/vendor-menu.inc | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/installer/data/mysql/mandatory/userpermissions.sql b/installer/data/mysql/mandatory/userpermissions.sql
index 9660879f86..7e52abd262 100644
--- a/installer/data/mysql/mandatory/userpermissions.sql
+++ b/installer/data/mysql/mandatory/userpermissions.sql
@@ -75,7 +75,7 @@ INSERT INTO permissions (module_bit, code, description) VALUES
    (11, 'planning_manage', 'Manage budget plannings'),
    (11, 'order_manage', 'Manage baskets and order lines'),
    (11, 'order_manage_all', 'Manage all baskets and order lines, regardless of restrictions on them'),
-   (11, 'issue_manage', 'Manage issues'),
+   (11, 'issue_manage', 'Manage vendor issues'),
    (11, 'group_manage', 'Manage basket groups'),
    (11, 'order_receive', 'Receive orders and manage shipments'),
    (11, 'budget_add_del', 'Add and delete funds (but can''t modify funds)'),
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
index 3d0af47233..4caf7022c4 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
@@ -464,7 +464,7 @@
         <span class="permissioncode">([% name | html %])</span>
     [%- CASE 'issue_manage' -%]
         <span class="sub_permission issues_manage_subpermission">
-            Manage issues
+            Manage vendor issues
         </span>
         <span class="permissioncode">([% name | html %])</span>
     [%- CASE 'order_receive' -%]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/vendor-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/vendor-menu.inc
index 82415521c0..631692721e 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/vendor-menu.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/vendor-menu.inc
@@ -4,7 +4,7 @@
         [% IF ( CAN_user_acquisition_order_manage ) %]<li><a href="/cgi-bin/koha/acqui/booksellers.pl?booksellerid=[% booksellerid | uri %]">Baskets</a></li>[% END %]
         [% IF ( CAN_user_acquisition_group_manage ) %]<li><a href="/cgi-bin/koha/acqui/basketgroup.pl?booksellerid=[% booksellerid | uri %]">Basket groups</a></li>[% END %]
         [% IF ( CAN_user_acquisition_contracts_manage ) %]<li><a href="/cgi-bin/koha/admin/aqcontract.pl?booksellerid=[% booksellerid | uri %]">Contracts</a></li>[% END %]
-        [% IF ( CAN_user_acquisition_issue_manage ) %]<li><a href="/cgi-bin/koha/acqui/vendor_issues.pl?booksellerid=[% booksellerid | uri %]">Issues</a></li>[% END %]
+        [% IF ( CAN_user_acquisition_issue_manage ) %]<li><a href="/cgi-bin/koha/acqui/vendor_issues.pl?booksellerid=[% booksellerid | uri %]">Vendor issues</a></li>[% END %]
         <li><a href="/cgi-bin/koha/acqui/invoices.pl?supplierid=[% booksellerid | uri %]&amp;op=do_search">Invoices</a></li>
         [% IF ( CAN_user_acquisition_order_manage ) %][% IF ( basketno ) %]
         <li><a href="/cgi-bin/koha/acqui/uncertainprice.pl?booksellerid=[% booksellerid | uri %]&amp;basketno=[% basketno | uri %]&amp;owner=1">Uncertain prices</a></li>
-- 
2.39.5