From a14a5c2f268414ca48cd84f9732851a45eac6ff3 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Wed, 2 Dec 2020 10:52:27 +0100
Subject: [PATCH] Bug 26953: Hide phone and itiva from "Overdue notice/status
 triggers"

If the prefs are off we should not display the checkboxes

Test plan:
1. Turn off PhoneNotification and TalkingTechItivaPhoneNotification
2. Go to the "Overdue notice/status triggers" and confirm that phone and
itiva columns are not displayed
3. Turn the prefs on and confirm the checkboxes are now displayed

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 6ef7cbededc424e93622b30832ebc7f609d7308d)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 .../intranet-tmpl/prog/en/modules/tools/overduerules.tt   | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt
index 22d4050fe0..8fea31861b 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt
@@ -73,6 +73,8 @@
               <th scope="col">Letter</th>
               <th scope="col">Restrict</th>
               [% FOREACH mtt IN message_transport_types %]
+                [% NEXT IF mtt == 'itiva' AND !Koha.Preference('TalkingTechItivaPhoneNotification') %]
+                [% NEXT IF mtt == 'phone' AND !Koha.Preference('PhoneNotification') %]
                 <th scpre="col">
                   [% SWITCH mtt %]
                   [% CASE 'email' %]
@@ -121,16 +123,14 @@
               [% END %]
               </td>
               [% FOREACH mtt IN value.message_transport_types %]
+                [% NEXT IF mtt.value == 'itiva' AND !Koha.Preference('TalkingTechItivaPhoneNotification') %]
+                [% NEXT IF mtt.value == 'phone' AND !Koha.Preference('PhoneNotification') %]
                 <td>
                   [% IF mtt.selected %]
                     <input type="checkbox" name="mtt[% tab.number | html %]-[% value.overduename | html %]" value="[% mtt.value | html %]" checked="checked" />
                   [% ELSE %]
                     [% IF mtt.value == "sms" and not Koha.Preference("SMSSendDriver") %]
                       <input type="checkbox" name="mtt[% tab.number | html %]-[% value.overduename | html %]" value="[% mtt.value | html %]" disabled="disabled" />
-                    [% ELSIF mtt.value == "itiva" and not Koha.Preference("TalkingTechItivaPhoneNotification") %]
-                      <input type="checkbox" name="mtt[% tab.number | html %]-[% value.overduename | html %]" value="[% mtt.value | html %]" disabled="disabled" />
-                    [% ELSIF mtt.value == "phone" and not Koha.Preference("PhoneNotification") %]
-                        <input type="checkbox" name="mtt[% tab.number | html %]-[% value.overduename | html %]" value="[% mtt.value | html %]" disabled="disabled" />
                     [% ELSE %]
                       <input type="checkbox" name="mtt[% tab.number | html %]-[% value.overduename | html %]" value="[% mtt.value | html %]" />
                     [% END %]
-- 
2.39.5