From aeb242dd156af73b60d73d755bc26ef9ead1d4b9 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 5 Nov 2021 15:00:04 +0000 Subject: [PATCH] Bug 29321: Remove a last without loop context This reads better when converted to regular if. Note that last within such a block is allowed in Perl, but it feels better to use it only in a loop context. Test plan: Read the patch ;) Bonus: Test if you enter the block by using pref OPACSuggestionMandatoryFields when adding a suggestion from opac. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Edit: Added a space between 'if' and '(' :-D Signed-off-by: Jonathan Druart --- opac/opac-suggestions.pl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/opac/opac-suggestions.pl b/opac/opac-suggestions.pl index 9c965041ce..7c3dae9777 100755 --- a/opac/opac-suggestions.pl +++ b/opac/opac-suggestions.pl @@ -245,8 +245,7 @@ foreach my $suggestion(@$suggestions_loop) { my $patron_reason_loop = GetAuthorisedValues("OPAC_SUG", "opac"); my @mandatoryfields; -{ - last unless ($op eq 'add'); +if ( $op eq 'add' ) { my $fldsreq_sp = C4::Context->preference("OPACSuggestionMandatoryFields") || 'title'; @mandatoryfields = sort split(/\s*\,\s*/, $fldsreq_sp); foreach (@mandatoryfields) { -- 2.39.5