]> git.koha-community.org Git - koha.git/commit
Bug 26405: Prevent Circulation.t failing on 'AddRenewal left both fines'
authorEmmi Takkinen <emmi.takkinen@outlook.com>
Thu, 3 Dec 2020 08:41:47 +0000 (10:41 +0200)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Mon, 24 May 2021 18:49:00 +0000 (18:49 +0000)
commit61c3414eb6e9540d7565534f93b1fc4712d8483c
tree34225267b1bf453e03850619d3e7110fb2813739
parent0c0541ee98d58d9a1fd09d520163a1a07430f041
Bug 26405: Prevent Circulation.t failing on 'AddRenewal left both fines'

Bug 23051 added option to skip calculating fines even when
"CalculateFinesOnReturn" is enabled. Due this Circulation.t
fails on  test  "AddRenewal left both fines" if
"CalculateFinesOnReturn"  is disabled on ones system.
Mocking syspref while testing fixes failig tests.

To test:
1. Disable "CalculateFinesOnReturn".
2. Run prove t/db_dependent/Circulation.t
=> Tests fail
3. Apply patch.
4. Run prove t/db_dependent/Circulation.t again
=> Tests are succesful

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 95cbefe12d5b5d901d545b602627224dfc2c7034)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit e9caf93ad51874333348cf784c8e569793fec554)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
t/db_dependent/Circulation.t