]> git.koha-community.org Git - koha.git/commit
Bug 26721: Fix permission check on debit and credit type admin pages
authorKatrin Fischer <katrin.fischer.83@web.de>
Sun, 18 Oct 2020 15:14:48 +0000 (15:14 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 3 Nov 2020 09:57:35 +0000 (10:57 +0100)
commit915b4431e5d8cb45c644bb383adbccc41813e4fc
tree5ecf9869f20d6f98b5a7180b24c82a88f577b648
parent3dee550e346d8a998335eb7ce77b4a064a1d129a
Bug 26721: Fix permission check on debit and credit type admin pages

At the moment the pages falsely check for parameters_remaining_permissions,
but they should check the specific manage_accounts permission.

To test:
- Create a new staff user with only catalog and manage_acccounts
  permissions
- Log in with this staff user and go to the admin page
- You will see the debit and credit type sections, but won't be
  able to access them
- Apply the patch
- Veriy the links still show, but pages are now accessible

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
admin/credit_types.pl
admin/debit_types.pl