From 413c241d6b089cbbb782ce712200a86d2a3ceac3 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Fri, 20 Oct 2023 14:53:13 +0200
Subject: [PATCH] Bug 34913: Move item groups table to kohaTable

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit f9687f28c018075758364ffb3d859d2477defdae)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit a8018d568cd9757ba245c94477d2c9d410bee56c)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 .../prog/en/modules/catalogue/detail.tt       | 38 +++++++++----------
 1 file changed, 17 insertions(+), 21 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
index 725ca167c4..e9f91e5375 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
@@ -2208,22 +2208,24 @@
 
         [% IF Koha.Preference('EnableItemGroups') %]
             // Load item groups table
-            var itemGroupsTable = KohaTable("items-group-table", {
-                "autoWidth": false,
-                "dom": '<"top pager"ilp>t<"bottom pager"ip>r',
-                "columns": [
+            var itemGroupsTable = $("#items-group-table").kohaTable({
+                autoWidth: false,
+                dom: '<"top pager"ilp>t<"bottom pager"ip>r',
+                columns: [
                     {
-                        "data": function( oObj ) {
-                            return oObj.display_order;
-                        },
+                        data: "display_order",
+                        title: _("Display order"),
+                        searchable: true,
+                        orderable: true,
                     },
                     {
-                        "data": function( oObj ) {
-                            return oObj.description;
-                        },
+                        data: "description",
+                        title: _("Description"),
+                        searchable: true,
+                        orderable: true,
                     },
                     {
-                        "data": function( oObj ) {
+                        data: function( oObj ) {
                             [% IF CAN_user_editcatalogue_manage_item_groups %]
                                 return `<button class='item-group-edit btn btn-default btn-xs' data-item-group-id='${oObj.item_group_id}'>
                                     <i class='fa fa-edit'></i> ${_("Edit")}
@@ -2236,18 +2238,12 @@
                                 return "";
                             [% END %]
                         },
+                        searchable: false,
+                        orderable: false,
                     },
                 ],
-                "paginate": false,
-                "processing": true,
-                "serverSide":  false,
-                "ajax":  `/api/v1/biblios/${biblionumber}/item_groups?_per_page=-1`,
-                "sAjaxDataProp": "",
-                "fnServerData": function ( sSource, aoData, fnCallback ) {
-                    $.getJSON( sSource, aoData, function (json) {
-                        fnCallback(json)
-                    } );
-                },
+                paginate: false,
+                ajax: { url: `/api/v1/biblios/${biblionumber}/item_groups?_per_page=-1` },
             });
 
             // Create new item groups
-- 
2.39.5