From b0f3bc8c134c195e3d943a0f7f9d5ff6a064da79 Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Fri, 21 Sep 2018 11:17:25 +0200 Subject: [PATCH] Bug 21389: Correct Javascript error on article requests page Bug 21076 fixed a Javascript error on article requests page when patron is found. There is also an error when patron is not found, with message : Patron not found No patron with this name, please, try another This patch fixes by replacing TT condition by a JS condition testing the existance of the patron input. Test plan: 1 - Do not apply patch 2 - Enable article requests 3 - Search on staff client and click 'Request article' 4 - Search for a patron that does not exist 5 - You get a yellow message "Patron not found" 6 - View error in console 7 - Apply patch 8 - Reload 9 - Not error is gone 10 - Search for a patron that does exist 11 - Check there is no error in console 12 - Check that autocompletion works Signed-off-by: Owen Leonard Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens (cherry picked from commit b27db0fbfc0b715df1b63c57228a9945d4834f29) Signed-off-by: Martin Renvoize --- .../intranet-tmpl/prog/en/modules/circ/request-article.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt index 375b653ca8..28372e944c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt @@ -308,7 +308,7 @@ }); $(document).ready(function() { - [% UNLESS (patron ) %] + if ( $( "#patron" ).size() ){ $( "#patron" ).autocomplete({ source: "/cgi-bin/koha/circ/ysearch.pl", minLength: 3, @@ -327,7 +327,7 @@ item.country + "" ) .appendTo( ul ); }; - [% END %] + } $( ".ar-update-branchcode" ).on('focus', function(){ previous_branchcode = this.value; -- 2.39.5