From aacb4e6bb9e6cc0539134a0389e1babe540eb142 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Fri, 19 Apr 2019 09:28:35 -0300 Subject: [PATCH] Bug 22739: Test SelfCheckInTimeout <> 0, not just defined On sci-main.pl the preference value is tested for 'defined'. This patch tests it is different than empty string too. This was causing a JavaScript syntax error, that made it display a wrong message. To test: 1 - Blank the syspref SelfCheckInTimeout 2 - Attempt to checkin something via sci => FAIL: The 'Your request included no check-ins.' message is printed. 3 - Apply this patch, reload the sci-main.pl page 4 - Attempt to checkin something via sci => SUCCESS: The UI correctly stacks the scanned barcodes 5 - Sign off :-D Signed-off-by: Liz Rea Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens (cherry picked from commit c1949cda9b2847bc6ecf7e1dbc07990c4055b69a) Signed-off-by: Martin Renvoize (cherry picked from commit 1269f7d6c7712b3c9115824660d5f12933ba6462) Signed-off-by: Lucas Gass --- opac/sci/sci-main.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/opac/sci/sci-main.pl b/opac/sci/sci-main.pl index b76179ecf4..84d2a6cb67 100755 --- a/opac/sci/sci-main.pl +++ b/opac/sci/sci-main.pl @@ -94,7 +94,7 @@ if ( $op eq 'check_in' ) { } # Make sure timeout has a reasonable value -my $timeout = C4::Context->preference('SelfCheckInTimeout') // 120; +my $timeout = C4::Context->preference('SelfCheckInTimeout') || 120; $template->param( refresh_timeout => $timeout ); output_html_with_http_headers $cgi, $cookie, $template->output, undef, { force_no_caching => 1 }; -- 2.39.5