]> git.koha-community.org Git - koha.git/commit
Bug 24614: Fix Reports/Guided.t
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 27 Mar 2020 16:09:27 +0000 (17:09 +0100)
committerLucas Gass <lucas@bywatersolutions.com>
Mon, 13 Apr 2020 20:39:47 +0000 (20:39 +0000)
commit98178e0bb8162c648b03b32f54d609b3990b4e83
tree66fdcd37b7bbd4e162fa822add225069a03a2081
parent6dde1fa54a7fcf4623adaa2b32f58d5ba5952137
Bug 24614: Fix Reports/Guided.t

DBD::mysql::st execute failed: Column 'public' cannot be null [for Statement "UPDATE `saved_sql` SET `last_modified` = ?, `notes` = ?, `public` = ?, `report_group` = ?, `report_name` = ?, `report_subgroup` = ?,
`savedsql` = ? WHERE ( `id` = ? )" with ParamValues: 0='2020-03-27T16:03:04', 1=undef, 2=undef, 3=undef, 4='Just another report', 5=undef, 6=undef, 7=25] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
    # Looks like you planned 17 tests but ran 6.

update_sql expect all the paramters to be set, otherwise it will be
nulled.

The best way to fix it is at test level. There is only 1 occurrence in
controller/module, and it sends all the parameters. That is the correct
way to do and will make things easier when we will removed them to use
Koha::Reports directly

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit 60c88bfa2f6c23c58ebd953eca2d0c29f6f2dee3)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
t/db_dependent/Reports/Guided.t