From 075c8a96b387efebf40601debc347c4a33607e51 Mon Sep 17 00:00:00 2001 From: Andreas Jonsson Date: Tue, 31 Aug 2021 12:50:03 +0000 Subject: [PATCH] Bug 28930: Keep cardnumber be editable after server side form validation fails during self registration. MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Test plan: - Enable the system preference PatronSelfRegistration - Make sure PatronSelfRegistrationBorrowerUnwantedField does not contain cardnumber. - Set the system preference GDPR_Policy to "Enforce". - In the OPAC click "Log in to your account" and "Register here". - Fill out the form with valid data, but make sure you leave the checkbox under "GDPR consent" unchecked. - Submit the form - You will get back the form with the error message "You have not filled out all required fields. Please fill in all missing fields and resubmit." - Without patch: cardnumber is not editable, and there is no input element for borrower_cardnumber (so the cardnumber will be lost when resubmitting the form) - With patch: cardnumber is editable. Signed-off-by: Owen Leonard Signed-off-by: Joonas Kylmälä Signed-off-by: Jonathan Druart --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt index 790f1e5044..c7f7c9c503 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt @@ -209,7 +209,7 @@ - [% IF borrower && !(cardnumber_wrong_length || cardnumber_already_exists) %] + [% IF borrower && !(cardnumber_wrong_length || cardnumber_already_exists) && action == 'edit' %] [% borrower.cardnumber | html %] [% ELSE %] [% IF minlength_cardnumber == maxlength_cardnumber %] -- 2.39.5