]> git.koha-community.org Git - koha.git/commit
Bug 28936: Add sort1/sort2 to borrowers.json
authorLucas Gass <lucas@bywatersolutions.com>
Wed, 1 Sep 2021 16:24:52 +0000 (16:24 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 16 Sep 2021 07:55:43 +0000 (21:55 -1000)
commitadeda4f416eb03537cad8439fba5e2c1736ba59f
tree54496dc10acd8f820e8f8e8df315992a4341b4d7
parent053b19db85de318fae1dfe544cae5e076073e899
Bug 28936: Add sort1/sort2 to borrowers.json

To Test:
1. Check the BorrowerMandatoryField and BorrowerUnwantedField system preferences, sort1 and sort2 cannot be hidden or required
2. Apply patch
3. Check the BorrowerMandatoryField and BorrowerUnwantedField system preferences again, you should see sort1 and sort2
4. Since sort1 and sort2 are now added to borrowers.json we must also check the system preferences PatronQuickAddFields & PatronDuplicateMatchingAddFields
5. They should both now include sort1 and sort2, check to make sure they work with these two system preferences
6. Look at the system preferences PatronSelfRegistrationBorrowerMandatoryField, PatronSelfRegistrationBorrowerUnwantedField, and PatronSelfModificationBorrowerUnwantedField
7. sort1 and sort2 should be disabled in these OPAC system preferences

This patch does not attempt to add sort1 or sort2 to the self reg or borrower mod pages. If they should be added, which I am not sure they should, we should do so in a seperate bug

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 73a711b41ff7dd0ba4e35d7643a793a7addb7cfe)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/borrowers.json
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref