From 7e4db79ce66b296de822b7d49b5a302d2dd0d0a6 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Thu, 29 Aug 2024 12:41:27 +0200
Subject: [PATCH] Bug 37745: Remove more duplicated class attributes

Found using `egrep 'class=[^>]+class=' **/*.tt **/*.inc`

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 koha-tmpl/intranet-tmpl/prog/en/includes/clubs-table.inc    | 4 ++--
 koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc  | 2 +-
 .../intranet-tmpl/prog/en/includes/patron_messages.inc      | 4 ++--
 koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt     | 6 +++---
 koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt   | 2 +-
 koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_sets.tt   | 2 +-
 .../prog/en/modules/authorities/authorities.tt              | 4 ++--
 .../intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt   | 4 ++--
 .../intranet-tmpl/prog/en/modules/catalogue/results.tt      | 6 +++---
 .../intranet-tmpl/prog/en/modules/circ/curbside_pickups.tt  | 2 +-
 .../intranet-tmpl/prog/en/modules/members/housebound.tt     | 4 ++--
 .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 2 +-
 .../prog/en/modules/onboarding/onboardingstep3.tt           | 2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-illrequests.tt      | 2 +-
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-library.tt    | 4 ++--
 15 files changed, 25 insertions(+), 25 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/clubs-table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/clubs-table.inc
index c2db426cf3..ccf055d465 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/clubs-table.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/clubs-table.inc
@@ -96,14 +96,14 @@
                                         </a>
                                     </li>
                                     <li>
-                                        <a class="dropdown-item" href="#" class="delete_club" data-id="[% c.id | html %]" data-name="[% c.name | html %]">
+                                        <a class="dropdown-item delete_club" href="#" data-id="[% c.id | html %]" data-name="[% c.name | html %]">
                                             <i class="fa fa-trash-can"></i> Delete
                                         </a>
                                     </li>
                                 [% END %]
                                 [% IF ( c.club_enrollments.count ) %]
                                     <li>
-                                        <a class="dropdown-item" href="#" class="club_hold_search" data-id="[% c.id | html %]">
+                                        <a class="dropdown-item club_hold_search" href="#" data-id="[% c.id | html %]">
                                             <i class="fa fa-search"></i> Search to hold
                                         </a>
                                     </li>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
index 714cec4e19..21f29ea7b3 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
@@ -935,7 +935,7 @@
                                     <a href="#" class="btn btn-link select_all"><i class="fa fa-check"></i> Select all</a>
                                     |
                                     <a href="#" class="btn btn-link clear_all"><i class="fa fa-remove"></i> Clear all</a>
-                                    <button class="add-selected" class="btn btn-sm btn-default" type="submit">Add selected patrons</button>
+                                    <button class="add-selected btn btn-sm btn-default" type="submit">Add selected patrons</button>
                                 </div>
                             </div>
                         [% END %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
index 5c063e3d05..c2551b2e65 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
@@ -349,7 +349,7 @@
                     </span>
                     [% IF patron_message.branchcode == Branches.GetLoggedInBranchcode OR Koha.Preference('AllowAllMessageDeletion') %]
                         [% IF moremember %]
-                            <a id="#edit_message_form_[% patron_message.message_id | html %]" class="btn btn-link edit_message" href="#edit_message_form_[% patron_message.message_id | uri %]" data-bs-target="#edit_message_form_[% patron_message.message_id | html %]" data-bs-toggle="modal" class="btn btn-default"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit</a>
+                            <a id="#edit_message_form_[% patron_message.message_id | html %]" class="btn btn-default btn-link edit_message" href="#edit_message_form_[% patron_message.message_id | uri %]" data-bs-target="#edit_message_form_[% patron_message.message_id | html %]" data-bs-toggle="modal"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit</a>
                             <form action="/cgi-bin/koha/circ/del_message.pl" method="post">
                                 [% INCLUDE 'csrf-token.inc' %]
                                 <input type="hidden" name="op" value="cud-delete">
@@ -359,7 +359,7 @@
                                 <button type="submit" class="btn btn-link delete_message"><i class="fa fa-trash-can"></i> Delete</button>
                             </form>
                         [% ELSE %]
-                            <a id="#edit_message_form_[% patron_message.message_id | html %]" class="btn btn-link edit_message" href="#edit_message_form_[% patron_message.message_id | uri %]" data-bs-target="#edit_message_form_[% patron_message.message_id | html %]" data-bs-toggle="modal" class="btn btn-default"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit</a>
+                            <a id="#edit_message_form_[% patron_message.message_id | html %]" class="btn btn-default btn-link edit_message" href="#edit_message_form_[% patron_message.message_id | uri %]" data-bs-target="#edit_message_form_[% patron_message.message_id | html %]" data-bs-toggle="modal"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit</a>
                             <form action="/cgi-bin/koha/circ/del_message.pl" method="post">
                                 [% INCLUDE 'csrf-token.inc' %]
                                 <input type="hidden" name="op" value="cud-delete">
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
index 70fb74b90d..cb960e13c1 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
@@ -535,9 +535,9 @@
                             result += '<button type="button" class="btn btn-default btn-xs dropdown-toggle dropdown-toggle-split" data-bs-toggle="dropdown" aria-expanded="false"><span class="visually-hidden">Toggle dropdown</span></button>';
 
                             result += '<ul class="dropdown-menu" aria-labelledby="view' + row.order_id + '">';
-                                result += '<li><a class="dropdown-item previewData" href="/cgi-bin/koha/acqui/showorder.pl?ordernumber=' + encodeURIComponent(row.order_id) + '" class="previewData">[% tp("noun", "Order") | html %]</a></li>';
-                                result += '<li><a class="dropdown-item previewData" href="/cgi-bin/koha/catalogue/showmarc.pl?id=' + encodeURIComponent(row.biblio_id) + '" class="previewData">' + _("MARC") + '</a></li>';
-                                result += '<li><a class="dropdown-item previewData" href="/cgi-bin/koha/catalogue/showmarc.pl?viewas=card&amp;id=' + encodeURIComponent(row.biblio_id) + '" class="previewData">' + _("Card") + '</a></li>';
+                                result += '<li><a class="dropdown-item previewData" href="/cgi-bin/koha/acqui/showorder.pl?ordernumber=' + encodeURIComponent(row.order_id) + '">[% tp("noun", "Order") | html %]</a></li>';
+                                result += '<li><a class="dropdown-item previewData" href="/cgi-bin/koha/catalogue/showmarc.pl?id=' + encodeURIComponent(row.biblio_id) + '">' + _("MARC") + '</a></li>';
+                                result += '<li><a class="dropdown-item previewData" href="/cgi-bin/koha/catalogue/showmarc.pl?viewas=card&amp;id=' + encodeURIComponent(row.biblio_id) + '">' + _("Card") + '</a></li>';
                             result += '</ul>';
                             result += '</div>';
                             return result;
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt
index 7098e8e3b9..6eccd23962 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt
@@ -122,7 +122,7 @@
                     <input type="hidden" name="currency_code" id="currency" value="[% currency.currency | html %]" />[% currency.currency | html %]
                 [% ELSE %]
                     <label for="currency_code" class="required">Currency: </label>
-                    <input type="text" name="currency_code" id="currency_code" class="focus" size="50" maxlength="50" required="required" class="required" /> <span class="required">Required</span>
+                    <input type="text" name="currency_code" id="currency_code" class="focus required" size="50" maxlength="50" required="required" /> <span class="required">Required</span>
                 [% END %]
             </li>
             <li>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_sets.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_sets.tt
index 2d29d45d7d..c3d6f60b7e 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_sets.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_sets.tt
@@ -73,7 +73,7 @@
                         <li>
                             <label for="spec" class="required">setSpec: </label>
                             [% IF ( spec == "" ) %]
-                                <input type="text" id="spec" class="focus" name="spec" value="[% spec | html %]" required="required" class="required" />
+                                <input type="text" id="spec" class="focus required" name="spec" value="[% spec | html %]" required="required" />
                             [% ELSE %]
                                 <input type="text" id="spec" name="spec" value="[% spec | html %]" required="required" class="required" />
                             [% END %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
index dea2683962..ea7034eed0 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
@@ -462,10 +462,10 @@
                 [% IF ( duplicateauthid ) %]
                     <div class="alert alert-warning">
                         <h3>Duplicate record suspected</h3>
-                        <p>Is this a duplicate of <a href="/cgi-bin/koha/authorities/detail.pl?authid=[% duplicateauthid | uri %]" class="popup" onclick="openWindow('/cgi-bin/koha/authorities/detail.pl?authid=[% duplicateauthid | html %]&amp;popup=1', 'DuplicateAuthority','800','600'); return false;" class="button">[% duplicateauthvalue | html %]</a> ?</p>
+                        <p>Is this a duplicate of <a href="/cgi-bin/koha/authorities/detail.pl?authid=[% duplicateauthid | uri %]" class="popup button" onclick="openWindow('/cgi-bin/koha/authorities/detail.pl?authid=[% duplicateauthid | html %]&amp;popup=1', 'DuplicateAuthority','800','600'); return false;">[% duplicateauthvalue | html %]</a> ?</p>
 
                         <p>
-                            <a href="/cgi-bin/koha/authorities/authorities.pl?authid=[% duplicateauthid | uri %]" class="btn btn-default" class="new"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Yes: Edit existing authority</a>
+                            <a href="/cgi-bin/koha/authorities/authorities.pl?authid=[% duplicateauthid | uri %]" class="btn btn-default new"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Yes: Edit existing authority</a>
                         </p>
                         <p>
                             <a class="btn btn-default new" onclick="confirmnotdup('items'); return false;"><i class="fa fa-save"></i> No: Save as new authority</a>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt
index 3e8215a0af..241606d311 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt
@@ -499,11 +499,11 @@
                     + '            <ul class="dropdown-menu" aria-labelledby="batch_mod_menu">';
                 [% IF ( CAN_user_tools_items_batchmod ) %]
                     table += ''
-                        + '                <li> <a class="dropdown-item" href="#" data-submit="batch_item_modification" data-bs-toggle="tooltip" data-bs-placement="right" title="' + _("Send selected items to batch item modification") + '" class="batch_op send_to_item_mod">' + _("Batch item modification") + '</a> </li>';
+                        + '                <li> <a class="dropdown-item batch_op send_to_item_mod" href="#" data-submit="batch_item_modification" data-bs-toggle="tooltip" data-bs-placement="right" title="' + _("Send selected items to batch item modification") + '">' + _("Batch item modification") + '</a> </li>';
                 [% END %]
                 [% IF ( CAN_user_tools_items_batchdel ) %]
                     table += ''
-                        + '                <li> <a class="dropdown-item" href="#" data-submit="batch_item_deletion" data-bs-toggle="tooltip" data-bs-placement="right" title="' + _("Send selected items to batch item deletion") + '" class="batch_op send_to_item_del">' + _("Batch item deletion") + '</a> </li>';
+                        + '                <li> <a class="dropdown-item batch_op send_to_item_del"" href="#" data-submit="batch_item_deletion" data-bs-toggle="tooltip" data-bs-placement="right" title="' + _("Send selected items to batch item deletion") + '">' + _("Batch item deletion") + '</a> </li>';
                 [% END %]
                 table += ''
                     + '            </ul>'
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
index 542232c49f..e2dcdb6ff8 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
@@ -144,7 +144,7 @@
                                             [% FOREACH s IN add_to_some_public_shelves %]
                                                 [% IF shelfnumber != s.shelfnumber %]
                                                     <li>
-                                                        <a class="dropdown-item" href="#" data-shelfnumber="[% s.shelfnumber | html %]" class="addtolist dropdown-item">[% s.shelfname | html %]</a>
+                                                        <a class="addtolist dropdown-item" href="#" data-shelfnumber="[% s.shelfnumber | html %]">[% s.shelfname | html %]</a>
                                                     </li>
                                                     [% SET number_of_public_shelves = number_of_public_shelves + 1 %]
                                                     [% IF number_of_public_shelves == 10 %][% LAST %][% END %]
@@ -154,11 +154,11 @@
                                         <li><hr class="dropdown-divider"></li>
                                         [% IF add_to_some_private_shelves.count > 10 or add_to_some_public_shelves.count > 10 %]
                                             <li>
-                                                <a class="dropdown-item" href="#" class="addtolist morelists dropdown-item">More lists</a>
+                                                <a href="#" class="addtolist morelists dropdown-item">More lists</a>
                                             </li>
                                         [% END %]
                                         <li>
-                                            <a class="dropdown-item" href="#" class="addtolist newlist dropdown-item">New list</a>
+                                            <a href="#" class="dropdown-item addtolist newlist dropdown-item">New list</a>
                                         </li>
                                     </ul>
                                 </div>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/curbside_pickups.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/curbside_pickups.tt
index 011b5b6a22..f1d1e84efd 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/curbside_pickups.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/curbside_pickups.tt
@@ -441,7 +441,7 @@
                                 <label class="sr-only" for="input-patron-cardnumber">Card number</label>
                                 <div class="input-group">
                                     <div class="input-group-addon">Search a patron</div>
-                                    <input autocomplete="off" id="find-patron" class="form-control" type="text" style="width:25%" class="noEnterSubmit" placeholder="Enter patron card number or name"//>
+                                    <input autocomplete="off" id="find-patron" class="form-control noEnterSubmit" type="text" style="width:25%" placeholder="Enter patron card number or name"//>
                                 </div>
                             </div>
                         [% ELSE %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt
index 51e5619ae6..eaf4af84ef 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt
@@ -24,7 +24,7 @@
     <div class="rows">
         <ol>
           <li>
-            <span class="label" class="required"> Delivery day:</span>
+            <span class="label required"> Delivery day:</span>
             [% hpd = housebound_profile.day %]
             [% IF hpd == 'any' %]<span>Any</span>
             [% ELSIF hpd == 'monday' %]<span>Monday</span>
@@ -37,7 +37,7 @@
             [% END %]
           </li>
           <li>
-            <span class="label" class="required">Frequency:</span>
+            <span class="label required">Frequency:</span>
             [% AuthorisedValues.GetByCode( 'HSBND_FREQ', housebound_profile.frequency, 0 ) || housebound_profile.frequency | html %]
           </li>
           <li>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
index c3a7512b7e..ca4a298717 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
@@ -254,7 +254,7 @@ legend.collapsed i.fa.fa-caret-down::before {
                                 [% END %]
                                 <button class="btn btn-primary toggler" id="saverecord" name="save" ><i class="fa fa-save"></i> Save</button>
                                 [% IF op == 'add_form' %]
-                                    <a class="btn btn-link" href="/cgi-bin/koha/members/member.pl" class="toggler save_entryform">
+                                    <a class="btn btn-link toggler save_entryform" href="/cgi-bin/koha/members/member.pl">
                                 [% ELSE %]
                                     <a class="btn btn-link" href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber | html %]">
                                 [% END %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt
index 483d44ba9f..3876246cba 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt
@@ -61,7 +61,7 @@
                             <li>
                                 <label for="cardnumber" class="required">Card number: </label>
                                 [% IF patrons && patrons > 1 %]
-                                    <input type="text" id="cardnumber" class="noEnterSubmit valid" name="cardnumber" value="[% newcardnumber | html %]" class="required" required="required">
+                                    <input type="text" id="cardnumber" class="noEnterSubmit valid required" name="cardnumber" value="[% newcardnumber | html %]" required="required">
                                 [% ELSE %]
                                     <input type="text" id="cardnumber" name="cardnumber" value="[% cardnumber | html %]" class="required" required="required">
                                 [% END %]
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt
index 38ec0e0735..0e6b3d5932 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt
@@ -277,7 +277,7 @@
                                     <input type="hidden" name="checked_availability" value="1">
                                     <div id="continue-request-row" class="alert">
                                         If you can't find what you are looking for, you can
-                                        <button class="button" class="btn btn-primary" type="submit">continue creating your request</button> or
+                                        <button class="button btn btn-primary" type="submit">continue creating your request</button> or
                                         <a href="/cgi-bin/koha/opac-illrequests.pl">cancel your request</a>
                                     </div>
                                 </form>
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-library.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-library.tt
index 09ed26ebe1..5d1a3dc709 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-library.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-library.tt
@@ -110,9 +110,9 @@
                     <h1>Libraries</h1>
                     [% FOREACH library IN libraries %]
                         [% IF ( branchcode == library.branchcode ) %]
-                            <div class="section_library" id="section_[% library.branchcode | html %]" class="current">
+                            <div class="section_library current" id="section_[% library.branchcode | html %]">
                         [% ELSE %]
-                            <div class="section_library" id="section_[% library.branchcode | html %]" class="">
+                            <div class="section_library" id="section_[% library.branchcode | html %]">
                         [% END %]
                         <h2 property="name">
                             <a href="/cgi-bin/koha/opac-library.pl?branchcode=[% library.branchcode | url %]">
-- 
2.39.5