From 8f4dbfbf50cb027a133c28e5240a5c1c996e648d Mon Sep 17 00:00:00 2001 From: Petro Vashchuk Date: Mon, 25 Jan 2021 17:35:18 +0200 Subject: [PATCH] Bug 27548: "use of uninitialized value" warning on branchoverdues.pl On the beginning we have empty "location" parameter for this form, but that not taken into account in comparison and undef warning emitted: "Use of uninitialized value $location in string eq at /usr/share/koha/intranet/cgi-bin/circ/branchoverdues.pl line 72" in branchoverdues.pl Fixed by adding pre-check for $location. To reproduce: 1) Head over to "Circulation ->Overdues with fines" page. Check intranet-error.log where there will be many warnings "Use of uninitialized value $location in string eq at /usr/share/koha/intranet/cgi-bin/circ/branchoverdues.pl line 72". 2) Apply the patch, refresh the "Overdues with fines" page. 3) Ensure that the new "use of uninitialized value" warnings didn't appear in the console. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit c3d22687568640930bad9ffbb426033423e7efe9) Signed-off-by: Fridolin Somers (cherry picked from commit 44d1675aaf1e602e12ccd669dad50a299654f89d) Signed-off-by: Andrew Fuerste-Henry (cherry picked from commit d766debe2c80bf991145e413308ef1a8b298286e) Signed-off-by: Victor Grousset/tuxayo --- circ/branchoverdues.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/circ/branchoverdues.pl b/circ/branchoverdues.pl index 24c49cfddf..62127bbf85 100755 --- a/circ/branchoverdues.pl +++ b/circ/branchoverdues.pl @@ -69,7 +69,7 @@ my ($tag,$subfield) = GetMarcFromKohaField( 'items.location' ); my $tagslib = &GetMarcStructure(1,''); if ($tagslib->{$tag}->{$subfield}->{authorised_value}) { my $values= GetAuthorisedValues($tagslib->{$tag}->{$subfield}->{authorised_value}); - for (@$values) { $_->{selected} = 1 if $location eq $_->{authorised_value} } + for (@$values) { $_->{selected} = 1 if defined $location && $location eq $_->{authorised_value} } $template->param(locationsloop => $values); } # now display infos -- 2.39.5