From c4f17c10ff7901b8900c1913fc1edac9d6e176c1 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Tue, 2 Feb 2021 12:54:39 +0000
Subject: [PATCH] Bug 27592: Link audio alerts to corresponding preference and
 back

This patch adds links from the audio alerts page to system preferences
and back.

To test, apply the patch and disable the "AudioAlerts" system
preference.

- Log in to the staff interface as a user with permission to access
  audio alerts and system preferences.
- Go to Administration -> Audio alerts.
- You should see an alert, "Audio alerts are disabled."
  - Test the link to system preferences. It should take you a
    preferences search which returns only "AudioAlerts."
- On the system preference page, test that the link to audio alerts
  works correctly.

- Disable audio alerts again.
- Log in to the staf interface as a user with permission to access audio
  alerts but WITHOUT permission to access system preferences.
- Go to Administration -> Audio alerts.
- You should see an alert, "Audio alerts are disabled."
- There should be no link to system preferences.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 .../intranet-tmpl/prog/en/modules/admin/audio_alerts.tt   | 8 ++++++--
 .../en/modules/admin/preferences/staff_interface.pref     | 2 +-
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt
index 4587214c0e..34a6446c13 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt
@@ -75,8 +75,12 @@
                     <h3>Audio alerts</h3>
                     [%IF !( Koha.Preference('AudioAlerts') ) %]
                         <div class="dialog alert">
-                            <p><strong>Note: </strong></p>
-                            <p>Please enable system preference 'AudioAlerts' to activate sounds.</p>
+                            <h3>Audio alerts are disabled</h3>
+                            [% IF ( CAN_user_parameters_manage_sysprefs ) %]
+                                <p>Please enable system preference <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=AudioAlerts">AudioAlerts</a> to activate sounds.</p>
+                            [% ELSE %]
+                                <p>The system preference <strong>AudioAlerts</strong> must be enabled to activate sounds.</p>
+                            [% END %]
                         </div>
                     [% END %]
                     <table id="audio-alerts-table">
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref
index 30132b35fc..12fc8cdfa5 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref
@@ -174,7 +174,7 @@ Staff interface:
               choices:
                  yes: "Enable"
                  no: "Don't enable"
-            - audio alerts for events defined in the audio alerts section of administration.
+            - audio alerts for events defined in the <a href="/cgi-bin/koha/admin/audio_alerts.pl">audio alerts</a> section of administration.
         -
             - pref: IntranetCatalogSearchPulldown
               choices:
-- 
2.39.5