From 53811a1700f9e7083e24ab65f5b7291a2fa090be Mon Sep 17 00:00:00 2001
From: Tomas Cohen Arazi <tomascohen@theke.io>
Date: Fri, 29 Jan 2021 16:43:06 -0300
Subject: [PATCH] Bug 27580: Handle NULL values correctly in
 Koha::Items->filter_by_visible_in_opac

This patch fixes the internally used query so it doesn't consider NULL
values as IN the set.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Items.t
=> FAIL: Tests fail :-/
3. Apply this patch
4. Repeat 2
=> SUCCESS: tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit b60ff6452ef2212a02f16ddc5c46edeb3d83a5e3)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 606f47b2e91dcc51b1348356d672e95f8943ab8a)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
---
 Koha/Items.pm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Koha/Items.pm b/Koha/Items.pm
index a375757b2b..cffbf9a254 100644
--- a/Koha/Items.pm
+++ b/Koha/Items.pm
@@ -65,8 +65,9 @@ sub filter_by_visible_in_opac {
         my $rules = C4::Context->yaml_preference('OpacHiddenItems') // {};
 
         my $rules_params;
-        foreach my $field (keys %$rules){
-            $rules_params->{$field}->{'-not_in'} = $rules->{$field};
+        foreach my $field ( keys %$rules ) {
+            $rules_params->{$field} =
+              [ { '-not_in' => $rules->{$field} }, undef ];
         }
 
         $result = $result->search( $rules_params );
-- 
2.39.5