From 54e951e72d28925c0795bea5b5cf21d3cc03aecf Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Fri, 18 Mar 2022 15:03:30 +0000
Subject: [PATCH] Bug 30009: Do not set MARCNOTES to empty list in list context

AMENDED:
We should not pass an empty list here, but just undef in order to
prevent creating a shift of elements in the hash.

To test:
1 - Find or create an invalid marc record
2 - View in staff client
3 - Note tab Descriptions(1) has no content
4 - Apply patch, reload
5 - No empty tab

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 catalogue/detail.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/catalogue/detail.pl b/catalogue/detail.pl
index 9687f3b01b..29b6167f61 100755
--- a/catalogue/detail.pl
+++ b/catalogue/detail.pl
@@ -464,7 +464,7 @@ $template->param(
 );
 
 $template->param(
-    MARCNOTES   => $marc_record ? $biblio->get_marc_notes({ marcflavour => $marcflavour }) : (),
+    MARCNOTES   => $marc_record ? $biblio->get_marc_notes({ marcflavour => $marcflavour }) : undef,
     itemdata_ccode      => $itemfields{ccode},
     itemdata_enumchron  => $itemfields{enumchron},
     itemdata_uri        => $itemfields{uri},
-- 
2.39.5