From 623bae988442c9bdff5d34de23270e3f09f523bc Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Thu, 18 Nov 2021 19:17:48 +0000
Subject: [PATCH] Bug 29521: Fix style of patron clubs table when in clubs
 management

This patch follows up Bug 24627 to add some additional template logic to
the table of clubs so that the interface is consistent whether you're
looking at clubs during the holds process or during the clubs management
view.

The ways Bug 24627 made the clubs list more consistent with patron
search results made it LESS consistent with the Clubs management
interface.

To test, apply the patch and go to Tools -> Patron clubs.

- Scroll down to the "Clubs" table, below the "Club templates" table.
  - In the table of clubs, the club name should not be a link.
  - Hovering your mouse over the table should not highlight each row.

Confirm the previous behavior of a clubs search when placing a hold:

- Search the catalog and start the process of placing a hold on an item.
- On the "Place hold" page, click the "Clubs" tab and perform a search
  which will return multiple clubs.
- In this view, the club name should be a link. Clicking it should
  select that club for the hold.
- You should also be able to click anywhere in the row to select the
  club for the hold.

Signed-off-by: Andreas Roussos <a.roussos@dataly.gr>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
---
 koha-tmpl/intranet-tmpl/prog/en/includes/clubs-table.inc | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/clubs-table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/clubs-table.inc
index 233ccf3d04..99d1d861e8 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/clubs-table.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/clubs-table.inc
@@ -1,4 +1,8 @@
-<table id="clubs-table" class="selections-table">
+[% IF destination == 'holds' %]
+    <table id="clubs-table" class="selections-table">
+[% ELSE %]
+    <table id="clubs-table">
+[% END %]
     <thead>
         <tr>
             <th>Name</th>
@@ -26,10 +30,11 @@
                     [% SET data_url = "/cgi-bin/koha/reserve/request.pl?club=" _ c.id _ "&amp;biblionumber=" _ biblionumber %]
                 [% END %]
                 <tr class="clickable" data-url="[% data_url | html %]">
+                    <td><a href="[% data_url | url %]">[% c.name | html %]</a></td>
             [% ELSE %]
                 <tr>
+                    <td>[% c.name | html %]</td>
             [% END %]
-                <td><a href="[% data_url | url %]">[% c.name | html %]</a></td>
                 <td>[% c.club_template.name | html %]</td>
                 <td>[% c.description | html %]</td>
                 [% UNLESS destination == 'holds' %]
-- 
2.39.5