From a822fa569a3b136d01f4b15e6e1b0a7e93a544e1 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Mon, 29 Jan 2024 10:41:56 +0100
Subject: [PATCH] Bug 34913: Fix perlcritic for VirtualShelves.pm

C4/Utils/DataTables/VirtualShelves.pm: "@order_by" is declared but not used at line 86, column 9.  Unused variables clutter code and make it harder to read.  (Severity: 3)

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 0c96e57b0c6986f5bffc7530bd2eaf25ea7e994e)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 5ae6890b8579673f5ac0458e0466cbbd75cba927)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 C4/Utils/DataTables/VirtualShelves.pm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/C4/Utils/DataTables/VirtualShelves.pm b/C4/Utils/DataTables/VirtualShelves.pm
index 8100a65591..2c4c1628e1 100644
--- a/C4/Utils/DataTables/VirtualShelves.pm
+++ b/C4/Utils/DataTables/VirtualShelves.pm
@@ -83,7 +83,6 @@ sub search {
 
 
     if ($order_by) {
-        my @order_by;
         $order_by =~ s|shelfnumber|vs.shelfnumber|;
         my @sanitized_orderbys;
         for my $order ( split ',', $order_by ) {
-- 
2.39.5