From dfd3f183cfa3e65d9bdf2d002fe9aa7ddbe0127f Mon Sep 17 00:00:00 2001
From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Date: Tue, 16 Mar 2021 17:18:39 +0000
Subject: [PATCH] Bug 22435: Use 'CREATE' offset type in Koha::Account::Line

This patch updates the Koha::Account::Line methods that result in new account
lines to use the 'CREATE' offset type for the creation record.

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 Koha/Account/Line.pm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Koha/Account/Line.pm b/Koha/Account/Line.pm
index 36a420b10c..23b2cc869e 100644
--- a/Koha/Account/Line.pm
+++ b/Koha/Account/Line.pm
@@ -283,7 +283,7 @@ sub void {
             Koha::Account::Offset->new(
                 {
                     debit_id => $void->id,
-                    type     => 'VOID',
+                    type     => 'CREATE',
                     amount   => $self->amount * -1
                 }
             )->store();
@@ -415,7 +415,7 @@ sub cancel {
             my $cancellation_offset = Koha::Account::Offset->new(
                 {
                     credit_id => $cancellation->accountlines_id,
-                    type      => 'CANCELLATION',
+                    type      => 'CREATE',
                     amount    => $self->amount
                 }
             )->store();
@@ -539,7 +539,7 @@ sub reduce {
             my $reduction_offset = Koha::Account::Offset->new(
                 {
                     credit_id => $reduction->accountlines_id,
-                    type      => uc( $params->{reduction_type} ),
+                    type      => 'CREATE',
                     amount    => $params->{amount}
                 }
             )->store();
@@ -772,7 +772,7 @@ sub payout {
             my $payout_offset = Koha::Account::Offset->new(
                 {
                     debit_id => $payout->accountlines_id,
-                    type     => 'PAYOUT',
+                    type     => 'CREATE',
                     amount   => $amount
                 }
             )->store();
-- 
2.39.5