From 37ca7f59fc7ab863cffff15b06d4b0d29844245a Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Tue, 22 Sep 2015 09:49:39 +0200 Subject: [PATCH] Bug 14867: userid not generated when defined in BorrowerUnwantedField MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit When userid is not provided when creating a new patron, it is generated using surname and firstname. The bug is when userid is defined in syspref BorrowerUnwantedField, the input text is missing in patron creation form. When saving you always get an alert message : "Username/password already exists". No patron can be created. This patch corrects by adding this case to userid generation conditions. Test plan : - add 'userid' in syspref BorrowerUnwantedField - try to create a new patron : /cgi-bin/koha/members/memberentry.pl - there is not input text for userid - choose non-existing surname and firstname - click on save => Without patch : patron is not created, you see the alert message "Username/password already exists" => With patch : patron is created, userid is generated with surname and firstname - remove 'userid' in syspref BorrowerUnwantedField and check it can be defined in patron creation form Signed-off-by: Frédéric Demians The issue is there, and this patch fixes it. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 0cbc65111c735e699d94d50ad09c17fb7b7b8913) (cherry picked from commit ee185cfd1afed08d20f226ef8a2c62df2c96b6e8) Signed-off-by: Liz Rea --- members/memberentry.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/members/memberentry.pl b/members/memberentry.pl index 2578aff881..fc74fbfca5 100755 --- a/members/memberentry.pl +++ b/members/memberentry.pl @@ -275,8 +275,9 @@ $newdata{'city'} = $input->param('city') if defined($input->param('city')) $newdata{'zipcode'} = $input->param('zipcode') if defined($input->param('zipcode')); $newdata{'country'} = $input->param('country') if defined($input->param('country')); -#builds default userid -if ( (defined $newdata{'userid'}) && ($newdata{'userid'} eq '')){ +# builds default userid +# userid input text may be empty or missing because of syspref BorrowerUnwantedField +if ( ( defined $newdata{'userid'} && $newdata{'userid'} eq '' ) || $check_BorrowerUnwantedField =~ /userid/ ) { if ( ( defined $newdata{'firstname'} ) && ( defined $newdata{'surname'} ) ) { # Full page edit, firstname and surname input zones are present $newdata{'userid'} = Generate_Userid( $borrowernumber, $newdata{'firstname'}, $newdata{'surname'} ); -- 2.39.5