From 19d0de6597c32c0ec495ca64a654c9576256feff Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Wed, 28 Sep 2016 14:49:32 +0200 Subject: [PATCH] Bug 17367 - Showing all items must keep show holdings tab in OPAC details MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit In OPAC details page, when record as too many items (depending on syspref OpacMaxItemsToDisplay), they are not displayed in holdings tab. You can click on link "Click here to view them all" to show them : page reloads with a new arg viewallitems=1. Also you can choose which tab is shown by default using syspref opacSerialDefaultTab. The bug is that when default tab is not holdings, clicking on link to show all items will show another tab. So one must reclick on holings tab to see all items. This patch corrects by forcing holdings tab when arg viewallitems is defined. Test plan : - Create a serial record with more items than syspref OpacMaxItemsToDisplay (or decrease this syspref) - Select "Subscriptions tab" for syspref opacSerialDefaultTab - Go to opac details on this record : /cgi-bin/koha/opac-detail.pl?biblionumber=xxx => You see Subscriptions tab selected - Click on Holdings tab => You see no items but a link "Click here to view them all" - Click on this link => Without patch you see Subscriptions tab selected => Wih patch you see Holdings tab selected and the items Signed-off-by: Juliette Signed-off-by: Nick Clemens Signed-off-by: Brendan Gallagher (cherry picked from commit f1298dc7828757fe9277a5128910335d2d6c0f2c) Signed-off-by: Frédéric Demians (cherry picked from commit 2a62a9a18cc3a36288e6abf3586a7e606e6e07db) Signed-off-by: Julian Maurice --- opac/opac-detail.pl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl index da94801caa..43b0f54e8c 100755 --- a/opac/opac-detail.pl +++ b/opac/opac-detail.pl @@ -1124,6 +1124,8 @@ if ( C4::Context->preference("IDREF") ) { # the user wants, and what's available for display my $opac_serial_default = C4::Context->preference('opacSerialDefaultTab'); my $defaulttab = + $viewallitems + ? 'holdings' : $opac_serial_default eq 'subscriptions' && $subscriptionsnumber ? 'subscriptions' : $opac_serial_default eq 'serialcollection' && @serialcollections > 0 -- 2.39.5