From 2e07ea6512d2d1afa63786d3a2d8703b6b93509e Mon Sep 17 00:00:00 2001 From: Indranil Das Gupta Date: Mon, 4 May 2015 18:55:15 +0530 Subject: [PATCH] Bug 14135: Adds 'Free' to variabletypes in systempreferences.tt The 'Local Use' system preference addition/modification template provides the following options against "Variable Type" - Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSource. There is no option presented for "Free" which seems to be the most used variable type out-of-the-box (i.e. INTRAdidyoumean, OPACdidyoumean, UsageStatsID and UsageStatsLastUpdateTime) This trivial patch proposes to modify the systempreferences.tt and add the option 'Free' to the list offered to users. Test Plan ========= 1/ Go to Home > Administration > System preferences > Local use 2/ Click on 'New preference'. 3/ In the fieldset 'Koha Internal', the variable types offered are Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSources. 4/ Clicking on 'Choice' should set the 'preftype' field as 'Choice'. 5/ Apply this patch. 6/ Refresh the page. 7/ The variable types list should read - "Free, Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSources". 8/ Clicking on 'Free' should set the 'preftype' field as 'Free'. Signed-off-by: Mark Tompsett NOTE: Discovered that there is no validation on the type field. However, that is beyond the scope of this bug. Signed-off-by: Amit Gupta Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 9f008a102415c8b71a1f4a976bc15691c2663b5c) Signed-off-by: Chris Cormack Signed-off-by: Liz Rea --- .../intranet-tmpl/prog/en/modules/admin/systempreferences.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt index 6ca3274a30..ee79530ceb 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt @@ -200,7 +200,7 @@
Note: you should have no reasons to modify the following default values
  1. -
    (Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSources)
    +
    (Free, Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSources)
  2. (a choice list for choice (separated by |) or cols|rows for texarea)
    -- 2.39.5