From 774f7eece6da4e39a70675921e344c80cc92f666 Mon Sep 17 00:00:00 2001 From: Fridolyn SOMERS Date: Wed, 9 Jan 2013 10:40:24 +0100 Subject: [PATCH] Bug 9065 - set correct permission for upload local cover image This patch fixes a problem where if a staff user has the upload_local_cover_images permission (and is not a superlibrarian and does not have all of the tools permissions), trying to use the "Tools -> Upload local cover image" will fail with "You do not have permissions [...]". To test after applying the patch: - Create a staff uesr that has just the catalogue and upload_local_cover_images permission. - Log in as that staff user. - Go to "Tools -> Upload local cover image". - Verify that one is given the form to upload a cover image. - Without the patch, one will be presented with the login form instead. Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart mysql> select * from permissions where code="upload_cover_images"; Empty set (0.00 sec) mysql> select * from permissions where code="upload_local_cover_images"; +------------+---------------------------+---------------------------+ | module_bit | code | description | +------------+---------------------------+---------------------------+ | 13 | upload_local_cover_images | Upload local cover images | +------------+---------------------------+---------------------------+ 1 row in set (0.00 sec) "git grep upload_cover_images" returns 0 result. Signed-off-by: Jared Camins-Esakov Signed-off-by: Chris Cormack --- tools/upload-cover-image.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/upload-cover-image.pl b/tools/upload-cover-image.pl index 9fe1ad4319..b85a81a73c 100755 --- a/tools/upload-cover-image.pl +++ b/tools/upload-cover-image.pl @@ -61,7 +61,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( query => $input, type => "intranet", authnotrequired => 0, - flagsrequired => { tools => 'upload_cover_images' }, + flagsrequired => { tools => 'upload_local_cover_images' }, debug => 0, } ); -- 2.39.5