From b3aee76dc12ce4aadfc4b3e30f0d589391b0b631 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Tue, 6 Dec 2022 11:02:20 -0300 Subject: [PATCH] Bug 32409: Fix cashup searching with non latin-1 chars MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This patch fixes a problem with the way queries are passed to the API so cashups are searchable with non-laint1 chars. To test: 1. Have two superlibrarian users, one with non-latin1 chars on the name (e.g. خمسة) 2. Setup a debit type that can be sold. 3. Use the POS module to have some activity, using both your regular user and the other one. 4. Go to the register you used, and choose 'Transaction history' 5. Perform a couple cashups with each user ('Record cashup'). 6. Look at the 'Cashup history' table => SUCCESS: You see cashups for both users 7. Use the 'Search' filter with latin chars => SUCCESS: Your user with only latin1 chars is displayed on the table 8. Repeat, using some non-latin1 char found on the other user => FAIL: Table is not refreshed or filtered! 9. Apply this patch 10. Reload the page 11. Repeat 8 => SUCCESS: Filtering works now! 12. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 96cba5503c896b01bb4eb7eab326d2fa8c4b96dc) Signed-off-by: Jacob O'Mara (cherry picked from commit 270170cd0e37ed016bec0ba845ce887f1b2414d0) Signed-off-by: Lucas Gass (cherry picked from commit b242b1b83e5626e8c3c751d3053df603bf2df392) Signed-off-by: Arthur Suzuki --- koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt | 1 - 1 file changed, 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt index 5b5a6a335a..c5903806d2 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt @@ -428,7 +428,6 @@ "ajax": { "url": cashups_table_url }, - "header_filter": true, "embed": [ "manager" ], -- 2.39.5