From fcc1934a9254d330ca5bed96acb1bc13b09b277f Mon Sep 17 00:00:00 2001
From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Date: Thu, 25 Jul 2024 16:52:10 +0000
Subject: [PATCH] Bug 35044: (QA follow-up): Avoid polluting global scope with
 functions

using immediately invoked function expression

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 .../prog/js/additional-fields-entry.js        | 58 +++++++++++--------
 1 file changed, 35 insertions(+), 23 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/js/additional-fields-entry.js b/koha-tmpl/intranet-tmpl/prog/js/additional-fields-entry.js
index 590533b7d5..a50ba9e33a 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/additional-fields-entry.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/additional-fields-entry.js
@@ -1,28 +1,40 @@
-$(document).ready(function() {
-    $("#additional_fields_form_section").on("click", ".clone_attribute", function(e){
-        e.preventDefault();
-        clone_entry( this );
-    });
+(function () {
+    $(document).ready(function () {
+        $("#additional_fields_form_section").on(
+            "click",
+            ".clone_attribute",
+            function (e) {
+                e.preventDefault();
+                clone_entry(this);
+            }
+        );
 
-    $("#additional_fields_form_section").on("click", ".clear_attribute", function(e){
-        e.preventDefault();
-        clear_entry( this );
-    });
+        $("#additional_fields_form_section").on(
+            "click",
+            ".clear_attribute",
+            function (e) {
+                e.preventDefault();
+                clear_entry(this);
+            }
+        );
 
-    $('#additional_fields_form_section').parents('form ').submit(function() {
-        $('.marcfieldget').prop("disabled", false);
-        return true;
+        $("#additional_fields_form_section")
+            .parents("form ")
+            .submit(function () {
+                $(".marcfieldget").prop("disabled", false);
+                return true;
+            });
     });
-});
 
-function clone_entry(node) {
-    var original = $(node).parent();
-    var clone = $(node).parent().clone();
-    $(original).after(clone);
-    return false;
-}
+    function clone_entry(node) {
+        var original = $(node).parent();
+        var clone = $(node).parent().clone();
+        $(original).after(clone);
+        return false;
+    }
 
-function clear_entry(node) {
-    var original = $(node).parent();
-    $("input", original).val('');
-}
\ No newline at end of file
+    function clear_entry(node) {
+        var original = $(node).parent();
+        $("input", original).val("");
+    }
+})();
\ No newline at end of file
-- 
2.39.5