From e98dc1e69ccc12820aba5cf45ab997da45198cf8 Mon Sep 17 00:00:00 2001 From: Lucas Gass Date: Mon, 29 Apr 2024 15:18:26 +0000 Subject: [PATCH] Bug 36708: Fix column index for processing No automatic renewal after To test: 1- Find or create a circulation rule with a 'Holds allowed (total)' limit of 3 (or another number) and no value in 'No automatic renewal after (hard limit)' 2- Select to edit the rule, and note that 'No automatic renewal after (hard limit)' box in the editing line is now populated with a date 3- Note also that 'Holds allowed (total)' is empty in your editing line 4- If you save your edits without clearing the new 'No automatic renewal after (hard limit)' date, it will save as part of the rule. Also, 'Holds allowed (total)' will save as Unlimited unless you re-add your numerical value. 5- APPLY PATCH 6- Try again, the values should save corrected and not erroneously fill the No automatic renewal after (hard limit) column. Signed-off-by: Andrew Fuerste Henry Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer (cherry picked from commit e3a04f73a22b46af1a68f221dcaa6db77017d76d) Signed-off-by: Lucas Gass --- koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt index afcd972af3..b74d3cae59 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt @@ -1476,7 +1476,7 @@ hardduedate = fp.parseDate( hardduedate, flatpickr_dateformat_string ); if( hardduedate) fp.setDate( hardduedate, 1 ); } - } else if ( i == 26 ) { + } else if ( i == 25 ) { // specific processing for No automatic renewal after (hard limit) var renewdate = itm_text; if (renewdate) { -- 2.39.5