From fbd233db5a4c7201c4691198fe5f0aecb320f357 Mon Sep 17 00:00:00 2001 From: Andrew Isherwood Date: Tue, 10 Apr 2018 16:50:56 +0100 Subject: [PATCH] Bug 20556: Marking ILL request as complete.. When marking a request as complete, the status is updated internally then the user to redirected to the view of the request. Although the redirect header is sent, there is no exit to indicate that the program flow should stop. As a result, an attempt is made to render the template, which fails. This patch simply adds the missing exit. TEST PLAN --------- - Create an ILL request - "Manage request" > "Confirm request" - "Mark completed" - TEST: Ensure that no error is written to the error log upon clicking "Mark completed" Signed-off-by: Brendan A Gallagher Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart --- ill/ill-requests.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/ill/ill-requests.pl b/ill/ill-requests.pl index 029fa49eea..47cfc97050 100755 --- a/ill/ill-requests.pl +++ b/ill/ill-requests.pl @@ -264,6 +264,7 @@ sub handle_commit_maybe { '/cgi-bin/koha/ill/ill-requests.pl?method=illview&illrequest_id='. $request->id ); + exit; } else { # Redirect to a requests list view redirect_to_list(); -- 2.39.5