]> git.koha-community.org Git - koha.git/commit
Bug 10428: undefined check in add additem.pl
authorFridolyn SOMERS <fridolyn.somers@biblibre.com>
Fri, 7 Jun 2013 08:17:54 +0000 (10:17 +0200)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Mon, 15 Jul 2013 23:13:46 +0000 (20:13 -0300)
commit54d414ee2d16a2969c91e5a83cb8c66858fed03c
treedaa1f2de079343e97f8b743f81a3849a639a500a
parent2dff5177f2d7c542175b28adf1832e201c0ae864
Bug 10428: undefined check in add additem.pl

In additem.pl, in the code that generates item form you find:

@values = $itemrecord->field($tag)->subfield($subtag) if ($itemrecord && defined($itemrecord->field($tag)->subfield($subtag)));

This patch adds the check of $itemrecord->field($tag) undef.
I did not found a way to test it because item tag is always defined
when editing an item, but it would be safer/prettier to add this check.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Passed-QA-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit e31b158245f4eff36decebf30c8a87c8cfebe472)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
cataloguing/additem.pl