From 289551282da7209b5394c82c4f310c32ae084499 Mon Sep 17 00:00:00 2001 From: Thomas Klausner Date: Tue, 22 Feb 2022 15:09:58 +0100 Subject: [PATCH] Bug 30153: Use uppercase AND to join query parts MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit C4::Search->FindDuplicate joins title and author using 'and' (lowercase). When this query is passed on to ElasticSearch, it interprets the lowercase 'and' as a term to search for, because the operator has to be in uppercases ('AND'). Test plan: * Reproduce the bug: - Set SearchEngine to ElasticSearch (and make sure you have the data indexed etc) - Find an existing book, note the title (245a) and the author (100a) - Create a new book (Cataloging -> New Record) - Fill in the same title and author using the same data as in an existing book (and any other fields that might be required) - Click "save" => A new book will be created, the Duplicate Finder has failed * Apply the patch * Check if it's working now: - Create a new book (Cataloging -> New Record) - Fill in the same title and author using the same data as in an existing book (and any other fields that might be required) - Click "save" - The DuplicateFinder should now report the already exising book Maybe we should also check if Zebra does not have any problems with the uppercase 'AND'? In that case, repeat the above steps, but set SearchEngine to Zebra :-) Sponsored-by: Steiermärkische Landesbibliothek Signed-off-by: Martin Renvoize Signed-off-by: Fridolin Somers --- C4/Search.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Search.pm b/C4/Search.pm index 6cf40b67b3..96013e28dd 100644 --- a/C4/Search.pm +++ b/C4/Search.pm @@ -99,7 +99,7 @@ sub FindDuplicate { my $titleindex = 'ti,ext'; my $authorindex = 'au,ext'; - my $op = 'and'; + my $op = 'AND'; $result->{title} =~ s /\\//g; $result->{title} =~ s /\"//g; -- 2.39.5