From c89f531f042f275fd7b582da656af6aa07445ab8 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Tue, 11 Jun 2019 18:13:08 +0000
Subject: [PATCH] Bug 23099: OPAC Search result sorting "go" button flashes on
 page load

There are a few places in the OPAC where we hide the submit button on a
sorting form because the form auto-submits when the selection changes.
These should be hidden using CSS instead of JS to prevent the temporary
appearance of the submit button while the page loads.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Test OPAC search results and OPAC checkout history. On both pages you
should not see a "Go" button next to the <select> input for changing the
sort order.

Disable JavaScript in your browser and test those pages again. The "Go"
button should appear.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit a89a203c1c85841a09b49771adbd77eeb76180c2)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit a00b6b155617f686c2a67a4b2b9c985b7d851bd2)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss           | 8 ++++++++
 .../opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt  | 1 -
 .../bootstrap/en/modules/opac-results-grouped.tt          | 1 -
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt  | 1 -
 4 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
index b629e913b8..b333d18f80 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
@@ -68,12 +68,20 @@ body {
     .selections-toolbar {
         display: none;
     }
+
+    #sortsubmit {
+        display: inline;
+    }
 }
 
 .js {
     .dateformat {
         display: none;
     }
+
+    #sortsubmit {
+        display: none;
+    }
 }
 
 /* Wrapper for page content to push down footer */
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
index d03d51855a..a2f2524f36 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
@@ -191,7 +191,6 @@
 //<![CDATA[
     $(document).ready(function(){
         [% IF ( GoogleJackets ) %]KOHA.Google.GetCoverFromIsbn();[% END %]
-            $('#sortsubmit').hide();
         $('#order').change(function() {
             $('#sortform').submit();
         });
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt
index 31194b9d97..8e4ac21a39 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt
@@ -297,7 +297,6 @@ $(document).ready(function(){
         });
     [% END %]
 
-    $('#sortsubmit').hide();
     $('#sort_by').change(function() {
         $('#bookbag_form').submit();
     });
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
index 6115cecd9a..7e38613586 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
@@ -805,7 +805,6 @@ $(document).ready(function(){
     param1 += "<\/select> <input type=\"submit\" class=\"btn btn-small\" value=\""+_("Save")+"\" />";
 [% END %]
 
-    $('#sortsubmit').hide();
     $('.resort').change(function() {
         $('#bookbag_form').submit();
     });
-- 
2.39.5