3 # Copyright 2015 Koha Development team
5 # This file is part of Koha
7 # Koha is free software; you can redistribute it and/or modify it
8 # under the terms of the GNU General Public License as published by
9 # the Free Software Foundation; either version 3 of the License, or
10 # (at your option) any later version.
12 # Koha is distributed in the hope that it will be useful, but
13 # WITHOUT ANY WARRANTY; without even the implied warranty of
14 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 # GNU General Public License for more details.
17 # You should have received a copy of the GNU General Public License
18 # along with Koha; if not, see <http://www.gnu.org/licenses>.
22 use Test::More tests => 40;
34 use C4::Auth qw(checkpw_hash);
40 use Koha::Old::Patrons;
41 use Koha::Patron::Categories;
42 use Koha::Patron::Relationship;
45 use Koha::Virtualshelves;
47 use t::lib::TestBuilder;
50 my $schema = Koha::Database->new->schema;
51 $schema->storage->txn_begin;
53 my $builder = t::lib::TestBuilder->new;
54 my $library = $builder->build({source => 'Branch' });
55 my $category = $builder->build({source => 'Category' });
56 my $nb_of_patrons = Koha::Patrons->search->count;
57 my $new_patron_1 = Koha::Patron->new(
58 { cardnumber => 'test_cn_1',
59 branchcode => $library->{branchcode},
60 categorycode => $category->{categorycode},
61 surname => 'surname for patron1',
62 firstname => 'firstname for patron1',
63 userid => 'a_nonexistent_userid_1',
64 flags => 1, # Is superlibrarian
67 my $new_patron_2 = Koha::Patron->new(
68 { cardnumber => 'test_cn_2',
69 branchcode => $library->{branchcode},
70 categorycode => $category->{categorycode},
71 surname => 'surname for patron2',
72 firstname => 'firstname for patron2',
73 userid => 'a_nonexistent_userid_2',
77 t::lib::Mocks::mock_userenv({ patron => $new_patron_1 });
79 is( Koha::Patrons->search->count, $nb_of_patrons + 2, 'The 2 patrons should have been added' );
81 my $retrieved_patron_1 = Koha::Patrons->find( $new_patron_1->borrowernumber );
82 is( $retrieved_patron_1->cardnumber, $new_patron_1->cardnumber, 'Find a patron by borrowernumber should return the correct patron' );
84 subtest 'library' => sub {
86 is( $retrieved_patron_1->library->branchcode, $library->{branchcode}, 'Koha::Patron->library should return the correct library' );
87 is( ref($retrieved_patron_1->library), 'Koha::Library', 'Koha::Patron->library should return a Koha::Library object' );
90 subtest 'guarantees' => sub {
93 t::lib::Mocks::mock_preference( 'borrowerRelationship', 'test|test2' );
95 my $guarantees = $new_patron_1->guarantee_relationships;
96 is( ref($guarantees), 'Koha::Patron::Relationships', 'Koha::Patron->guarantees should return a Koha::Patrons result set in a scalar context' );
97 is( $guarantees->count, 0, 'new_patron_1 should have 0 guarantee relationships' );
98 my @guarantees = $new_patron_1->guarantee_relationships;
99 is( ref(\@guarantees), 'ARRAY', 'Koha::Patron->guarantee_relationships should return an array in a list context' );
100 is( scalar(@guarantees), 0, 'new_patron_1 should have 0 guarantee' );
102 my $guarantee_1 = $builder->build({ source => 'Borrower' });
103 my $relationship_1 = Koha::Patron::Relationship->new( { guarantor_id => $new_patron_1->id, guarantee_id => $guarantee_1->{borrowernumber}, relationship => 'test' } )->store();
104 my $guarantee_2 = $builder->build({ source => 'Borrower' });
105 my $relationship_2 = Koha::Patron::Relationship->new( { guarantor_id => $new_patron_1->id, guarantee_id => $guarantee_2->{borrowernumber}, relationship => 'test' } )->store();
107 $guarantees = $new_patron_1->guarantee_relationships;
108 is( ref($guarantees), 'Koha::Patron::Relationships', 'Koha::Patron->guarantee_relationships should return a Koha::Patrons result set in a scalar context' );
109 is( $guarantees->count, 2, 'new_patron_1 should have 2 guarantees' );
110 @guarantees = $new_patron_1->guarantee_relationships;
111 is( ref(\@guarantees), 'ARRAY', 'Koha::Patron->guarantee_relationships should return an array in a list context' );
112 is( scalar(@guarantees), 2, 'new_patron_1 should have 2 guarantees' );
113 $_->delete for @guarantees;
115 #Test return order of guarantees BZ 18635
116 my $categorycode = $builder->build({ source => 'Category' })->{categorycode};
117 my $branchcode = $builder->build({ source => 'Branch' })->{branchcode};
119 my $guarantor = $builder->build_object( { class => 'Koha::Patrons' } );
121 my $order_guarantee1 = $builder->build_object(
123 class => 'Koha::Patrons',
129 $builder->build_object(
131 class => 'Koha::Patron::Relationships',
133 guarantor_id => $guarantor->id,
134 guarantee_id => $order_guarantee1,
135 relationship => 'test',
140 my $order_guarantee2 = $builder->build_object(
142 class => 'Koha::Patrons',
148 $builder->build_object(
150 class => 'Koha::Patron::Relationships',
152 guarantor_id => $guarantor->id,
153 guarantee_id => $order_guarantee2,
154 relationship => 'test',
159 my $order_guarantee3 = $builder->build_object(
161 class => 'Koha::Patrons',
164 firstname => 'Walrus',
168 $builder->build_object(
170 class => 'Koha::Patron::Relationships',
172 guarantor_id => $guarantor->id,
173 guarantee_id => $order_guarantee3,
174 relationship => 'test',
179 my $order_guarantee4 = $builder->build_object(
181 class => 'Koha::Patrons',
184 firstname => 'Vulture',
185 guarantorid => $guarantor->borrowernumber
189 $builder->build_object(
191 class => 'Koha::Patron::Relationships',
193 guarantor_id => $guarantor->id,
194 guarantee_id => $order_guarantee4,
195 relationship => 'test',
200 my $order_guarantee5 = $builder->build_object(
202 class => 'Koha::Patrons',
205 firstname => 'Unicorn',
206 guarantorid => $guarantor->borrowernumber
210 my $r = $builder->build_object(
212 class => 'Koha::Patron::Relationships',
214 guarantor_id => $guarantor->id,
215 guarantee_id => $order_guarantee5,
216 relationship => 'test',
221 $guarantees = $guarantor->guarantee_relationships->guarantees;
223 is( $guarantees->next()->borrowernumber, $order_guarantee5, "Return first guarantor alphabetically" );
224 is( $guarantees->next()->borrowernumber, $order_guarantee4, "Return second guarantor alphabetically" );
225 is( $guarantees->next()->borrowernumber, $order_guarantee3, "Return third guarantor alphabetically" );
226 is( $guarantees->next()->borrowernumber, $order_guarantee2, "Return fourth guarantor alphabetically" );
227 is( $guarantees->next()->borrowernumber, $order_guarantee1, "Return fifth guarantor alphabetically" );
230 subtest 'category' => sub {
232 my $patron_category = $new_patron_1->category;
233 is( ref( $patron_category), 'Koha::Patron::Category', );
234 is( $patron_category->categorycode, $category->{categorycode}, );
237 subtest 'siblings' => sub {
239 my $siblings = $new_patron_1->siblings;
240 is( $siblings, undef, 'Koha::Patron->siblings should not crashed if the patron has no guarantor' );
241 my $guarantee_1 = $builder->build( { source => 'Borrower' } );
242 my $relationship_1 = Koha::Patron::Relationship->new( { guarantor_id => $new_patron_1->borrowernumber, guarantee_id => $guarantee_1->{borrowernumber}, relationship => 'test' } )->store();
243 my $retrieved_guarantee_1 = Koha::Patrons->find($guarantee_1);
244 $siblings = $retrieved_guarantee_1->siblings;
245 is( ref($siblings), 'Koha::Patrons', 'Koha::Patron->siblings should return a Koha::Patrons result set in a scalar context' );
246 my @siblings = $retrieved_guarantee_1->siblings;
247 is( ref( \@siblings ), 'ARRAY', 'Koha::Patron->siblings should return an array in a list context' );
248 is( $siblings->count, 0, 'guarantee_1 should not have siblings yet' );
249 my $guarantee_2 = $builder->build( { source => 'Borrower' } );
250 my $relationship_2 = Koha::Patron::Relationship->new( { guarantor_id => $new_patron_1->borrowernumber, guarantee_id => $guarantee_2->{borrowernumber}, relationship => 'test' } )->store();
251 my $guarantee_3 = $builder->build( { source => 'Borrower' } );
252 my $relationship_3 = Koha::Patron::Relationship->new( { guarantor_id => $new_patron_1->borrowernumber, guarantee_id => $guarantee_3->{borrowernumber}, relationship => 'test' } )->store();
253 $siblings = $retrieved_guarantee_1->siblings;
254 is( $siblings->count, 2, 'guarantee_1 should have 2 siblings' );
255 is( $guarantee_2->{borrowernumber}, $siblings->next->borrowernumber, 'guarantee_2 should exist in the guarantees' );
256 is( $guarantee_3->{borrowernumber}, $siblings->next->borrowernumber, 'guarantee_3 should exist in the guarantees' );
257 $_->delete for $retrieved_guarantee_1->siblings;
258 $retrieved_guarantee_1->delete;
261 subtest 'has_overdues' => sub {
264 my $biblioitem_1 = $builder->build( { source => 'Biblioitem' } );
265 my $item_1 = $builder->build(
268 homebranch => $library->{branchcode},
269 holdingbranch => $library->{branchcode},
273 biblionumber => $biblioitem_1->{biblionumber}
277 my $retrieved_patron = Koha::Patrons->find( $new_patron_1->borrowernumber );
278 is( $retrieved_patron->has_overdues, 0, );
280 my $tomorrow = DateTime->today( time_zone => C4::Context->tz() )->add( days => 1 );
281 my $issue = Koha::Checkout->new({ borrowernumber => $new_patron_1->id, itemnumber => $item_1->{itemnumber}, date_due => $tomorrow, branchcode => $library->{branchcode} })->store();
282 is( $retrieved_patron->has_overdues, 0, );
284 my $yesterday = DateTime->today(time_zone => C4::Context->tz())->add( days => -1 );
285 $issue = Koha::Checkout->new({ borrowernumber => $new_patron_1->id, itemnumber => $item_1->{itemnumber}, date_due => $yesterday, branchcode => $library->{branchcode} })->store();
286 $retrieved_patron = Koha::Patrons->find( $new_patron_1->borrowernumber );
287 is( $retrieved_patron->has_overdues, 1, );
291 subtest 'is_expired' => sub {
293 my $patron = $builder->build({ source => 'Borrower' });
294 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
295 $patron->dateexpiry( undef )->store->discard_changes;
296 is( $patron->is_expired, 0, 'Patron should not be considered expired if dateexpiry is not set');
297 $patron->dateexpiry( dt_from_string )->store->discard_changes;
298 is( $patron->is_expired, 0, 'Patron should not be considered expired if dateexpiry is today');
299 $patron->dateexpiry( dt_from_string->add( days => 1 ) )->store->discard_changes;
300 is( $patron->is_expired, 0, 'Patron should not be considered expired if dateexpiry is tomorrow');
301 $patron->dateexpiry( dt_from_string->add( days => -1 ) )->store->discard_changes;
302 is( $patron->is_expired, 1, 'Patron should be considered expired if dateexpiry is yesterday');
307 subtest 'is_going_to_expire' => sub {
310 my $today = dt_from_string(undef, undef, 'floating');
311 my $patron = $builder->build({ source => 'Borrower' });
312 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
313 $patron->dateexpiry( undef )->store->discard_changes;
314 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is not set');
316 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 0);
317 $patron->dateexpiry( $today )->store->discard_changes;
318 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is today');
320 $patron->dateexpiry( $today )->store->discard_changes;
321 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is today and pref is 0');
323 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 10);
324 $patron->dateexpiry( $today->clone->add( days => 11 ) )->store->discard_changes;
325 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is 11 days ahead and pref is 10');
327 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 0);
328 $patron->dateexpiry( $today->clone->add( days => 10 ) )->store->discard_changes;
329 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is 10 days ahead and pref is 0');
331 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 10);
332 $patron->dateexpiry( $today->clone->add( days => 10 ) )->store->discard_changes;
333 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is 10 days ahead and pref is 10');
336 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 10);
337 $patron->dateexpiry( $today->clone->add( days => 20 ) )->store->discard_changes;
338 is( $patron->is_going_to_expire, 0, 'Patron should not be considered going to expire if dateexpiry is 20 days ahead and pref is 10');
340 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 20);
341 $patron->dateexpiry( $today->clone->add( days => 10 ) )->store->discard_changes;
342 is( $patron->is_going_to_expire, 1, 'Patron should be considered going to expire if dateexpiry is 10 days ahead and pref is 20');
344 { # Testing invalid is going to expiry date
345 t::lib::Mocks::mock_preference('NotifyBorrowerDeparture', 30);
346 # mock_config does not work here, because of tz vs timezone subroutines
347 my $context = new Test::MockModule('C4::Context');
348 $context->mock( 'tz', sub {
351 $patron->dateexpiry(DateTime->new( year => 2019, month => 12, day => 3 ))->store;
352 eval { $patron->is_going_to_expire };
353 is( $@, '', 'On invalid "is going to expire" date, the method should not crash with "Invalid local time for date in time zone"');
354 $context->unmock('tz');
361 subtest 'renew_account' => sub {
364 for my $date ( '2016-03-31', '2016-11-30', '2019-01-31', dt_from_string() ) {
365 my $dt = dt_from_string( $date, 'iso' );
366 Time::Fake->offset( $dt->epoch );
367 my $a_month_ago = $dt->clone->subtract( months => 1, end_of_month => 'limit' )->truncate( to => 'day' );
368 my $a_year_later = $dt->clone->add( months => 12, end_of_month => 'limit' )->truncate( to => 'day' );
369 my $a_year_later_minus_a_month = $a_month_ago->clone->add( months => 12, end_of_month => 'limit' )->truncate( to => 'day' );
370 my $a_month_later = $dt->clone->add( months => 1 , end_of_month => 'limit' )->truncate( to => 'day' );
371 my $a_year_later_plus_a_month = $a_month_later->clone->add( months => 12, end_of_month => 'limit' )->truncate( to => 'day' );
372 my $patron_category = $builder->build(
373 { source => 'Category',
375 enrolmentperiod => 12,
376 enrolmentperioddate => undef,
380 my $patron = $builder->build(
381 { source => 'Borrower',
383 dateexpiry => $a_month_ago,
384 categorycode => $patron_category->{categorycode},
385 date_renewed => undef, # Force builder to not populate the column for new patron
389 my $patron_2 = $builder->build(
390 { source => 'Borrower',
392 dateexpiry => $a_month_ago,
393 categorycode => $patron_category->{categorycode},
397 my $patron_3 = $builder->build(
398 { source => 'Borrower',
400 dateexpiry => $a_month_later,
401 categorycode => $patron_category->{categorycode},
405 my $retrieved_patron = Koha::Patrons->find( $patron->{borrowernumber} );
406 my $retrieved_patron_2 = Koha::Patrons->find( $patron_2->{borrowernumber} );
407 my $retrieved_patron_3 = Koha::Patrons->find( $patron_3->{borrowernumber} );
409 is( $retrieved_patron->date_renewed, undef, "Date renewed is not set for patrons that have never been renewed" );
411 t::lib::Mocks::mock_preference( 'BorrowerRenewalPeriodBase', 'dateexpiry' );
412 t::lib::Mocks::mock_preference( 'BorrowersLog', 1 );
413 my $expiry_date = $retrieved_patron->renew_account;
414 is( $expiry_date, $a_year_later_minus_a_month, "$a_month_ago + 12 months must be $a_year_later_minus_a_month" );
415 my $retrieved_expiry_date = Koha::Patrons->find( $patron->{borrowernumber} )->dateexpiry;
416 is( dt_from_string($retrieved_expiry_date), $a_year_later_minus_a_month, "$a_month_ago + 12 months must be $a_year_later_minus_a_month" );
417 my $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'RENEW', object => $retrieved_patron->borrowernumber } )->count;
418 is( $number_of_logs, 1, 'With BorrowerLogs, Koha::Patron->renew_account should have logged' );
420 t::lib::Mocks::mock_preference( 'BorrowerRenewalPeriodBase', 'now' );
421 t::lib::Mocks::mock_preference( 'BorrowersLog', 0 );
422 $expiry_date = $retrieved_patron->renew_account;
423 is( $expiry_date, $a_year_later, "today + 12 months must be $a_year_later" );
424 $retrieved_patron = Koha::Patrons->find( $patron->{borrowernumber} );
425 is( $retrieved_patron->date_renewed, output_pref({ dt => $dt, dateformat => 'iso', dateonly => 1 }), "Date renewed is set when calling renew_account" );
426 $retrieved_expiry_date = $retrieved_patron->dateexpiry;
427 is( dt_from_string($retrieved_expiry_date), $a_year_later, "today + 12 months must be $a_year_later" );
428 $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'RENEW', object => $retrieved_patron->borrowernumber } )->count;
429 is( $number_of_logs, 1, 'Without BorrowerLogs, Koha::Patron->renew_account should not have logged' );
431 t::lib::Mocks::mock_preference( 'BorrowerRenewalPeriodBase', 'combination' );
432 $expiry_date = $retrieved_patron_2->renew_account;
433 is( $expiry_date, $a_year_later, "today + 12 months must be $a_year_later" );
434 $retrieved_expiry_date = Koha::Patrons->find( $patron_2->{borrowernumber} )->dateexpiry;
435 is( dt_from_string($retrieved_expiry_date), $a_year_later, "today + 12 months must be $a_year_later" );
437 $expiry_date = $retrieved_patron_3->renew_account;
438 is( $expiry_date, $a_year_later_plus_a_month, "$a_month_later + 12 months must be $a_year_later_plus_a_month" );
439 $retrieved_expiry_date = Koha::Patrons->find( $patron_3->{borrowernumber} )->dateexpiry;
440 is( dt_from_string($retrieved_expiry_date), $a_year_later_plus_a_month, "$a_month_later + 12 months must be $a_year_later_plus_a_month" );
442 $retrieved_patron->delete;
443 $retrieved_patron_2->delete;
444 $retrieved_patron_3->delete;
449 subtest "move_to_deleted" => sub {
451 my $originally_updated_on = '2016-01-01 12:12:12';
452 my $patron = $builder->build( { source => 'Borrower',value => { updated_on => $originally_updated_on } } );
453 my $retrieved_patron = Koha::Patrons->find( $patron->{borrowernumber} );
454 is( ref( $retrieved_patron->move_to_deleted ), 'Koha::Schema::Result::Deletedborrower', 'Koha::Patron->move_to_deleted should return the Deleted patron' )
455 ; # FIXME This should be Koha::Deleted::Patron
456 my $deleted_patron = $schema->resultset('Deletedborrower')
457 ->search( { borrowernumber => $patron->{borrowernumber} }, { result_class => 'DBIx::Class::ResultClass::HashRefInflator' } )
459 ok( $retrieved_patron->updated_on, 'updated_on should be set for borrowers table' );
460 ok( $deleted_patron->{updated_on}, 'updated_on should be set for deleted_borrowers table' );
461 isnt( $deleted_patron->{updated_on}, $retrieved_patron->updated_on, 'Koha::Patron->move_to_deleted should have correctly updated the updated_on column');
462 $deleted_patron->{updated_on} = $originally_updated_on; #reset for simplicity in comparing all other fields
463 is_deeply( $deleted_patron, $patron, 'Koha::Patron->move_to_deleted should have correctly moved the patron to the deleted table' );
464 $retrieved_patron->delete( $patron->{borrowernumber} ); # Cleanup
467 subtest "delete" => sub {
469 t::lib::Mocks::mock_preference( 'BorrowersLog', 1 );
470 my $patron = $builder->build( { source => 'Borrower' } );
471 my $retrieved_patron = Koha::Patrons->find( $patron->{borrowernumber} );
472 my $hold = $builder->build(
473 { source => 'Reserve',
474 value => { borrowernumber => $patron->{borrowernumber} }
477 my $list = $builder->build(
478 { source => 'Virtualshelve',
479 value => { owner => $patron->{borrowernumber} }
483 my $deleted = $retrieved_patron->delete;
484 is( ref($deleted), 'Koha::Patron', 'Koha::Patron->delete should return the deleted patron object if the patron has been correctly deleted' );
486 is( Koha::Patrons->find( $patron->{borrowernumber} ), undef, 'Koha::Patron->delete should have deleted the patron' );
488 is (Koha::Old::Holds->search( { reserve_id => $hold->{ reserve_id } } )->count, 1, q|Koha::Patron->delete should have cancelled patron's holds| );
490 is( Koha::Holds->search( { borrowernumber => $patron->{borrowernumber} } )->count, 0, q|Koha::Patron->delete should have cancelled patron's holds 2| );
492 is( Koha::Virtualshelves->search( { owner => $patron->{borrowernumber} } )->count, 0, q|Koha::Patron->delete should have deleted patron's lists| );
494 my $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'DELETE', object => $retrieved_patron->borrowernumber } )->count;
495 is( $number_of_logs, 1, 'With BorrowerLogs, Koha::Patron->delete should have logged' );
498 subtest 'Koha::Patrons->delete' => sub {
501 my $patron1 = $builder->build_object({ class => 'Koha::Patrons' });
502 my $patron2 = $builder->build_object({ class => 'Koha::Patrons' });
503 my $id1 = $patron1->borrowernumber;
504 my $set = Koha::Patrons->search({ borrowernumber => { -in => [$patron1->borrowernumber, $patron2->borrowernumber]}});
505 is( $set->count, 2, 'Two patrons found as expected' );
506 is( $set->delete({ move => 1 }), 2, 'Two patrons deleted' );
507 my $deleted_patrons = Koha::Old::Patrons->search({ borrowernumber => { -in => [$patron1->borrowernumber, $patron2->borrowernumber]}});
508 is( $deleted_patrons->count, 2, 'Patrons moved to deletedborrowers' );
510 # See other tests in t/db_dependent/Koha/Objects.t
513 subtest 'add_enrolment_fee_if_needed' => sub {
516 my $enrolmentfees = { K => 5, J => 10, YA => 20 };
517 foreach( keys %{$enrolmentfees} ) {
518 ( Koha::Patron::Categories->find( $_ ) // $builder->build_object({ class => 'Koha::Patron::Categories', value => { categorycode => $_ } }) )->enrolmentfee( $enrolmentfees->{$_} )->store;
520 my $enrolmentfee_K = $enrolmentfees->{K};
521 my $enrolmentfee_J = $enrolmentfees->{J};
522 my $enrolmentfee_YA = $enrolmentfees->{YA};
524 my %borrower_data = (
525 firstname => 'my firstname',
526 surname => 'my surname',
528 branchcode => $library->{branchcode},
531 my $borrowernumber = Koha::Patron->new(\%borrower_data)->store->borrowernumber;
532 $borrower_data{borrowernumber} = $borrowernumber;
534 my $patron = Koha::Patrons->find( $borrowernumber );
535 my $total = $patron->account->balance;
536 is( int($total), int($enrolmentfee_K), "New kid pay $enrolmentfee_K" );
538 t::lib::Mocks::mock_preference( 'FeeOnChangePatronCategory', 0 );
539 $borrower_data{categorycode} = 'J';
540 $patron->set(\%borrower_data)->store;
541 $total = $patron->account->balance;
542 is( int($total), int($enrolmentfee_K), "Kid growing and become a juvenile, but shouldn't pay for the upgrade " );
544 $borrower_data{categorycode} = 'K';
545 $patron->set(\%borrower_data)->store;
546 t::lib::Mocks::mock_preference( 'FeeOnChangePatronCategory', 1 );
548 $borrower_data{categorycode} = 'J';
549 $patron->set(\%borrower_data)->store;
550 $total = $patron->account->balance;
551 is( int($total), int($enrolmentfee_K + $enrolmentfee_J), "Kid growing and become a juvenile, they should pay " . ( $enrolmentfee_K + $enrolmentfee_J ) );
553 # Check with calling directly Koha::Patron->get_enrolment_fee_if_needed
554 $patron->categorycode('YA')->store;
555 $total = $patron->account->balance;
557 int($enrolmentfee_K + $enrolmentfee_J + $enrolmentfee_YA),
558 "Juvenile growing and become an young adult, they should pay " . ( $enrolmentfee_K + $enrolmentfee_J + $enrolmentfee_YA )
564 subtest 'checkouts + pending_checkouts + get_overdues + old_checkouts' => sub {
567 my $library = $builder->build( { source => 'Branch' } );
568 my ($biblionumber_1) = AddBiblio( MARC::Record->new, '' );
569 my $item_1 = $builder->build(
573 homebranch => $library->{branchcode},
574 holdingbranch => $library->{branchcode},
575 biblionumber => $biblionumber_1,
581 my $item_2 = $builder->build(
585 homebranch => $library->{branchcode},
586 holdingbranch => $library->{branchcode},
587 biblionumber => $biblionumber_1,
593 my ($biblionumber_2) = AddBiblio( MARC::Record->new, '' );
594 my $item_3 = $builder->build(
598 homebranch => $library->{branchcode},
599 holdingbranch => $library->{branchcode},
600 biblionumber => $biblionumber_2,
606 my $patron = $builder->build(
608 source => 'Borrower',
609 value => { branchcode => $library->{branchcode} }
613 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
614 my $checkouts = $patron->checkouts;
615 is( $checkouts->count, 0, 'checkouts should not return any issues for that patron' );
616 is( ref($checkouts), 'Koha::Checkouts', 'checkouts should return a Koha::Checkouts object' );
617 my $pending_checkouts = $patron->pending_checkouts;
618 is( $pending_checkouts->count, 0, 'pending_checkouts should not return any issues for that patron' );
619 is( ref($pending_checkouts), 'Koha::Checkouts', 'pending_checkouts should return a Koha::Checkouts object' );
620 my $old_checkouts = $patron->old_checkouts;
621 is( $old_checkouts->count, 0, 'old_checkouts should not return any issues for that patron' );
622 is( ref($old_checkouts), 'Koha::Old::Checkouts', 'old_checkouts should return a Koha::Old::Checkouts object' );
624 # Not sure how this is useful, but AddIssue pass this variable to different other subroutines
625 $patron = Koha::Patrons->find( $patron->borrowernumber )->unblessed;
627 t::lib::Mocks::mock_userenv({ branchcode => $library->{branchcode} });
629 AddIssue( $patron, $item_1->{barcode}, DateTime->now->subtract( days => 1 ) );
630 AddIssue( $patron, $item_2->{barcode}, DateTime->now->subtract( days => 5 ) );
631 AddIssue( $patron, $item_3->{barcode} );
633 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
634 $checkouts = $patron->checkouts;
635 is( $checkouts->count, 3, 'checkouts should return 3 issues for that patron' );
636 is( ref($checkouts), 'Koha::Checkouts', 'checkouts should return a Koha::Checkouts object' );
637 $pending_checkouts = $patron->pending_checkouts;
638 is( $pending_checkouts->count, 3, 'pending_checkouts should return 3 issues for that patron' );
639 is( ref($pending_checkouts), 'Koha::Checkouts', 'pending_checkouts should return a Koha::Checkouts object' );
641 my $first_checkout = $pending_checkouts->next;
642 is( $first_checkout->unblessed_all_relateds->{biblionumber}, $item_3->{biblionumber}, 'pending_checkouts should prefetch values from other tables (here biblio)' );
644 my $overdues = $patron->get_overdues;
645 is( $overdues->count, 2, 'Patron should have 2 overdues');
646 is( ref($overdues), 'Koha::Checkouts', 'Koha::Patron->get_overdues should return Koha::Checkouts' );
647 is( $overdues->next->itemnumber, $item_1->{itemnumber}, 'The issue should be returned in the same order as they have been done, first is correct' );
648 is( $overdues->next->itemnumber, $item_2->{itemnumber}, 'The issue should be returned in the same order as they have been done, second is correct' );
651 C4::Circulation::AddReturn( $item_1->{barcode} );
652 C4::Circulation::AddReturn( $item_2->{barcode} );
653 $old_checkouts = $patron->old_checkouts;
654 is( $old_checkouts->count, 2, 'old_checkouts should return 2 old checkouts that patron' );
655 is( ref($old_checkouts), 'Koha::Old::Checkouts', 'old_checkouts should return a Koha::Old::Checkouts object' );
658 Koha::Checkouts->search( { borrowernumber => $patron->borrowernumber } )->delete;
662 subtest 'get_routing_lists' => sub {
665 my $biblio = Koha::Biblio->new()->store();
666 my $subscription = Koha::Subscription->new({
667 biblionumber => $biblio->biblionumber,
671 my $patron = $builder->build( { source => 'Borrower' } );
672 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
674 is( $patron->get_routing_lists->count, 0, 'Retrieves correct number of routing lists: 0' );
676 my $routinglist_count = Koha::Subscription::Routinglists->count;
677 my $routinglist = Koha::Subscription::Routinglist->new({
678 borrowernumber => $patron->borrowernumber,
680 subscriptionid => $subscription->subscriptionid
683 is ($patron->get_routing_lists->count, 1, "Retrieves correct number of routing lists: 1");
685 my $routinglists = $patron->get_routing_lists;
686 is ($routinglists->next->ranking, 5, "Retrieves ranking: 5");
687 is( ref($routinglists), 'Koha::Subscription::Routinglists', 'get_routing_lists returns Koha::Subscription::Routinglists' );
689 my $subscription2 = Koha::Subscription->new({
690 biblionumber => $biblio->biblionumber,
693 my $routinglist2 = Koha::Subscription::Routinglist->new({
694 borrowernumber => $patron->borrowernumber,
696 subscriptionid => $subscription2->subscriptionid
699 is ($patron->get_routing_lists->count, 2, "Retrieves correct number of routing lists: 2");
701 $patron->delete; # Clean up for later tests
705 subtest 'get_age' => sub {
708 my $patron = $builder->build( { source => 'Borrower' } );
709 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
711 my $today = dt_from_string;
713 $patron->dateofbirth( undef );
714 is( $patron->get_age, undef, 'get_age should return undef if no dateofbirth is defined' );
715 $patron->dateofbirth( $today->clone->add( years => -12, months => -6, days => -1, end_of_month => 'limit' ) );
716 is( $patron->get_age, 12, 'Patron should be 12' );
717 $patron->dateofbirth( $today->clone->add( years => -18, months => 0, days => 1, end_of_month => 'limit' ) );
718 is( $patron->get_age, 17, 'Patron should be 17, happy birthday tomorrow!' );
719 $patron->dateofbirth( $today->clone->add( years => -18, months => 0, days => 0, end_of_month => 'limit' ) );
720 is( $patron->get_age, 18, 'Patron should be 18' );
721 $patron->dateofbirth( $today->clone->add( years => -18, months => -12, days => -31, end_of_month => 'limit' ) );
722 is( $patron->get_age, 19, 'Patron should be 19' );
723 $patron->dateofbirth( $today->clone->add( years => -18, months => -12, days => -30, end_of_month => 'limit' ) );
724 is( $patron->get_age, 19, 'Patron should be 19 again' );
725 $patron->dateofbirth( $today->clone->add( years => 0, months => -1, days => -1, end_of_month => 'limit' ) );
726 is( $patron->get_age, 0, 'Patron is a newborn child' );
731 subtest 'is_valid_age' => sub {
734 my $today = dt_from_string;
736 my $category = $builder->build({
737 source => 'Category',
739 categorycode => 'AGE_5_10',
740 dateofbirthrequired => 5,
744 $category = Koha::Patron::Categories->find( $category->{categorycode} );
746 my $patron = $builder->build({
747 source => 'Borrower',
749 categorycode => 'AGE_5_10'
752 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
755 $patron->dateofbirth( undef );
756 is( $patron->is_valid_age, 1, 'Patron with no dateofbirth is always valid for any category');
758 $patron->dateofbirth( $today->clone->add( years => -12, months => -6, days => -1 ) );
759 is( $patron->is_valid_age, 0, 'Patron is 12, so the age is above allowed range 5-10 years');
761 $patron->dateofbirth( $today->clone->add( years => -3, months => -6, days => -1 ) );
762 is( $patron->is_valid_age, 0, 'Patron is 3, so the age is below allowed range 5-10 years');
764 $patron->dateofbirth( $today->clone->add( years => -7, months => -6, days => -1 ) );
765 is( $patron->is_valid_age, 1, 'Patron is 7, so the age perfectly suits allowed range 5-10 years');
767 $patron->dateofbirth( $today->clone->add( years => -5, months => 0, days => 0 ) );
768 is( $patron->is_valid_age, 1, 'Patron celebrates the 5th birthday today, so the age is allowed for this category');
770 $patron->dateofbirth( $today->clone->add( years => -5, months => 0, days => 1 ) );
771 is( $patron->is_valid_age, 0, 'Patron will celebrate the 5th birthday tomorrow, so the age is NOT allowed for this category');
773 $patron->dateofbirth( $today->clone->add( years => -5, months => 0, days => -1 ) );
774 is( $patron->is_valid_age, 1, 'Patron celebrated the 5th birthday yesterday, so the age is allowed for this category');
776 $patron->dateofbirth( $today->clone->add( years => -11, months => 0, days => 0 ) );
777 is( $patron->is_valid_age, 0, 'Patron celebrate the 11th birthday today, so the age is NOT allowed for this category');
779 $patron->dateofbirth( $today->clone->add( years => -11, months => 0, days => 1 ) );
780 is( $patron->is_valid_age, 1, 'Patron will celebrate the 11th birthday tomorrow, so the age is allowed for this category');
782 $patron->dateofbirth( $today->clone->add( years => -11, months => 0, days => -1 ) );
783 is( $patron->is_valid_age, 0, 'Patron celebrated the 11th birthday yesterday, so the age is NOT allowed for this category');
789 subtest 'account' => sub {
792 my $patron = $builder->build({source => 'Borrower'});
794 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
795 my $account = $patron->account;
796 is( ref($account), 'Koha::Account', 'account should return a Koha::Account object' );
801 subtest 'search_upcoming_membership_expires' => sub {
804 my $expiry_days = 15;
805 t::lib::Mocks::mock_preference( 'MembershipExpiryDaysNotice', $expiry_days );
806 my $nb_of_days_before = 1;
807 my $nb_of_days_after = 2;
809 my $builder = t::lib::TestBuilder->new();
811 my $library = $builder->build({ source => 'Branch' });
813 # before we add borrowers to this branch, add the expires we have now
814 # note that this pertains to the current mocked setting of the pref
815 # for this reason we add the new branchcode to most of the tests
816 my $nb_of_expires = Koha::Patrons->search_upcoming_membership_expires->count;
818 my $patron_1 = $builder->build({
819 source => 'Borrower',
821 branchcode => $library->{branchcode},
822 dateexpiry => dt_from_string->add( days => $expiry_days )
826 my $patron_2 = $builder->build({
827 source => 'Borrower',
829 branchcode => $library->{branchcode},
830 dateexpiry => dt_from_string->add( days => $expiry_days - $nb_of_days_before )
834 my $patron_3 = $builder->build({
835 source => 'Borrower',
837 branchcode => $library->{branchcode},
838 dateexpiry => dt_from_string->add( days => $expiry_days + $nb_of_days_after )
842 # Test without extra parameters
843 my $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires();
844 is( $upcoming_mem_expires->count, $nb_of_expires + 1, 'Get upcoming membership expires should return one new borrower.' );
847 $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires({ 'me.branchcode' => $library->{branchcode} });
848 is( $upcoming_mem_expires->count, 1, 'Test with branch parameter' );
849 my $expired = $upcoming_mem_expires->next;
850 is( $expired->surname, $patron_1->{surname}, 'Get upcoming membership expires should return the correct patron.' );
851 is( $expired->library->branchemail, $library->{branchemail}, 'Get upcoming membership expires should return the correct patron.' );
852 is( $expired->branchcode, $patron_1->{branchcode}, 'Get upcoming membership expires should return the correct patron.' );
854 t::lib::Mocks::mock_preference( 'MembershipExpiryDaysNotice', 0 );
855 $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires({ 'me.branchcode' => $library->{branchcode} });
856 is( $upcoming_mem_expires->count, 0, 'Get upcoming membership expires with MembershipExpiryDaysNotice==0 should not return new records.' );
858 # Test MembershipExpiryDaysNotice == undef
859 t::lib::Mocks::mock_preference( 'MembershipExpiryDaysNotice', undef );
860 $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires({ 'me.branchcode' => $library->{branchcode} });
861 is( $upcoming_mem_expires->count, 0, 'Get upcoming membership expires without MembershipExpiryDaysNotice should not return new records.' );
863 # Test the before parameter
864 t::lib::Mocks::mock_preference( 'MembershipExpiryDaysNotice', 15 );
865 $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires({ 'me.branchcode' => $library->{branchcode}, before => $nb_of_days_before });
866 is( $upcoming_mem_expires->count, 2, 'Expect two results for before');
867 # Test after parameter also
868 $upcoming_mem_expires = Koha::Patrons->search_upcoming_membership_expires({ 'me.branchcode' => $library->{branchcode}, before => $nb_of_days_before, after => $nb_of_days_after });
869 is( $upcoming_mem_expires->count, 3, 'Expect three results when adding after' );
870 Koha::Patrons->search({ borrowernumber => { in => [ $patron_1->{borrowernumber}, $patron_2->{borrowernumber}, $patron_3->{borrowernumber} ] } })->delete;
873 subtest 'holds and old_holds' => sub {
876 my $library = $builder->build( { source => 'Branch' } );
877 my ($biblionumber_1) = AddBiblio( MARC::Record->new, '' );
878 my $item_1 = $builder->build(
882 homebranch => $library->{branchcode},
883 holdingbranch => $library->{branchcode},
884 biblionumber => $biblionumber_1
888 my $item_2 = $builder->build(
892 homebranch => $library->{branchcode},
893 holdingbranch => $library->{branchcode},
894 biblionumber => $biblionumber_1
898 my ($biblionumber_2) = AddBiblio( MARC::Record->new, '' );
899 my $item_3 = $builder->build(
903 homebranch => $library->{branchcode},
904 holdingbranch => $library->{branchcode},
905 biblionumber => $biblionumber_2
909 my $patron = $builder->build(
911 source => 'Borrower',
912 value => { branchcode => $library->{branchcode} }
916 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
917 my $holds = $patron->holds;
918 is( ref($holds), 'Koha::Holds',
919 'Koha::Patron->holds should return a Koha::Holds objects' );
920 is( $holds->count, 0, 'There should not be holds placed by this patron yet' );
922 C4::Reserves::AddReserve(
924 branchcode => $library->{branchcode},
925 borrowernumber => $patron->borrowernumber,
926 biblionumber => $biblionumber_1
930 C4::Reserves::AddReserve(
932 branchcode => $library->{branchcode},
933 borrowernumber => $patron->borrowernumber,
934 biblionumber => $biblionumber_2,
935 expiration_date => dt_from_string->add( days => 2 )
939 $holds = $patron->holds;
940 is( $holds->count, 2, 'There should be 2 holds placed by this patron' );
942 my $old_holds = $patron->old_holds;
943 is( ref($old_holds), 'Koha::Old::Holds',
944 'Koha::Patron->old_holds should return a Koha::Old::Holds objects' );
945 is( $old_holds->count, 0, 'There should not be any old holds yet');
947 my $hold = $holds->next;
950 $old_holds = $patron->old_holds;
951 is( $old_holds->count, 1, 'There should be 1 old (cancelled) hold');
958 subtest 'notice_email_address' => sub {
961 my $patron = $builder->build_object({ class => 'Koha::Patrons' });
963 t::lib::Mocks::mock_preference( 'AutoEmailPrimaryAddress', 'OFF' );
964 is ($patron->notice_email_address, $patron->email, "Koha::Patron->notice_email_address returns correct value when AutoEmailPrimaryAddress is off");
966 t::lib::Mocks::mock_preference( 'AutoEmailPrimaryAddress', 'emailpro' );
967 is ($patron->notice_email_address, $patron->emailpro, "Koha::Patron->notice_email_address returns correct value when AutoEmailPrimaryAddress is emailpro");
972 subtest 'search_patrons_to_anonymise & anonymise_issue_history' => sub {
975 # TODO create a subroutine in t::lib::Mocks
976 my $branch = $builder->build({ source => 'Branch' });
977 my $userenv_patron = $builder->build_object({
978 class => 'Koha::Patrons',
979 value => { branchcode => $branch->{branchcode}, flags => 0 },
981 t::lib::Mocks::mock_userenv({ patron => $userenv_patron });
983 my $anonymous = $builder->build( { source => 'Borrower', }, );
985 t::lib::Mocks::mock_preference( 'AnonymousPatron', $anonymous->{borrowernumber} );
987 subtest 'patron privacy is 1 (default)' => sub {
990 t::lib::Mocks::mock_preference('IndependentBranches', 0);
991 my $patron = $builder->build(
992 { source => 'Borrower',
993 value => { privacy => 1, }
996 my $item_1 = $builder->build(
1004 my $issue_1 = $builder->build(
1005 { source => 'Issue',
1007 borrowernumber => $patron->{borrowernumber},
1008 itemnumber => $item_1->{itemnumber},
1012 my $item_2 = $builder->build(
1020 my $issue_2 = $builder->build(
1021 { source => 'Issue',
1023 borrowernumber => $patron->{borrowernumber},
1024 itemnumber => $item_2->{itemnumber},
1029 my ( $returned_1, undef, undef ) = C4::Circulation::AddReturn( $item_1->{barcode}, undef, undef, dt_from_string('2010-10-10') );
1030 my ( $returned_2, undef, undef ) = C4::Circulation::AddReturn( $item_2->{barcode}, undef, undef, dt_from_string('2011-11-11') );
1031 is( $returned_1 && $returned_2, 1, 'The items should have been returned' );
1033 my $patrons_to_anonymise = Koha::Patrons->search_patrons_to_anonymise( { before => '2010-10-11' } )->search( { 'me.borrowernumber' => $patron->{borrowernumber} } );
1034 is( ref($patrons_to_anonymise), 'Koha::Patrons', 'search_patrons_to_anonymise should return Koha::Patrons' );
1036 my $rows_affected = Koha::Patrons->search_patrons_to_anonymise( { before => '2011-11-12' } )->anonymise_issue_history( { before => '2010-10-11' } );
1037 ok( $rows_affected > 0, 'AnonymiseIssueHistory should affect at least 1 row' );
1039 $patrons_to_anonymise = Koha::Patrons->search_patrons_to_anonymise( { before => '2010-10-11' } );
1040 is( $patrons_to_anonymise->count, 0, 'search_patrons_to_anonymise should return 0 after anonymisation is done' );
1042 my $dbh = C4::Context->dbh;
1043 my $sth = $dbh->prepare(q|SELECT borrowernumber FROM old_issues where itemnumber = ?|);
1044 $sth->execute($item_1->{itemnumber});
1045 my ($borrowernumber_used_to_anonymised) = $sth->fetchrow_array;
1046 is( $borrowernumber_used_to_anonymised, $anonymous->{borrowernumber}, 'With privacy=1, the issue should have been anonymised' );
1047 $sth->execute($item_2->{itemnumber});
1048 ($borrowernumber_used_to_anonymised) = $sth->fetchrow_array;
1049 is( $borrowernumber_used_to_anonymised, $patron->{borrowernumber}, 'The issue should not have been anonymised, the returned date is later' );
1051 $rows_affected = Koha::Patrons->search_patrons_to_anonymise( { before => '2011-11-12' } )->anonymise_issue_history;
1052 $sth->execute($item_2->{itemnumber});
1053 ($borrowernumber_used_to_anonymised) = $sth->fetchrow_array;
1054 is( $borrowernumber_used_to_anonymised, $anonymous->{borrowernumber}, 'The issue should have been anonymised, the returned date is before' );
1056 my $sth_reset = $dbh->prepare(q|UPDATE old_issues SET borrowernumber = ? WHERE itemnumber = ?|);
1057 $sth_reset->execute( $patron->{borrowernumber}, $item_1->{itemnumber} );
1058 $sth_reset->execute( $patron->{borrowernumber}, $item_2->{itemnumber} );
1059 $rows_affected = Koha::Patrons->search_patrons_to_anonymise->anonymise_issue_history;
1060 $sth->execute($item_1->{itemnumber});
1061 ($borrowernumber_used_to_anonymised) = $sth->fetchrow_array;
1062 is( $borrowernumber_used_to_anonymised, $anonymous->{borrowernumber}, 'The issue 1 should have been anonymised, before parameter was not passed' );
1063 $sth->execute($item_2->{itemnumber});
1064 ($borrowernumber_used_to_anonymised) = $sth->fetchrow_array;
1065 is( $borrowernumber_used_to_anonymised, $anonymous->{borrowernumber}, 'The issue 2 should have been anonymised, before parameter was not passed' );
1067 Koha::Patrons->find( $patron->{borrowernumber})->delete;
1070 subtest 'patron privacy is 0 (forever)' => sub {
1073 t::lib::Mocks::mock_preference('IndependentBranches', 0);
1074 my $patron = $builder->build(
1075 { source => 'Borrower',
1076 value => { privacy => 0, }
1079 my $item = $builder->build(
1087 my $issue = $builder->build(
1088 { source => 'Issue',
1090 borrowernumber => $patron->{borrowernumber},
1091 itemnumber => $item->{itemnumber},
1096 my ( $returned, undef, undef ) = C4::Circulation::AddReturn( $item->{barcode}, undef, undef, dt_from_string('2010-10-10') );
1097 is( $returned, 1, 'The item should have been returned' );
1099 my $dbh = C4::Context->dbh;
1100 my ($borrowernumber_used_to_anonymised) = $dbh->selectrow_array(q|
1101 SELECT borrowernumber FROM old_issues where itemnumber = ?
1102 |, undef, $item->{itemnumber});
1103 is( $borrowernumber_used_to_anonymised, $patron->{borrowernumber}, 'With privacy=0, the issue should not be anonymised' );
1104 Koha::Patrons->find( $patron->{borrowernumber})->delete;
1107 t::lib::Mocks::mock_preference( 'AnonymousPatron', '' );
1109 subtest 'AnonymousPatron is not defined' => sub {
1112 t::lib::Mocks::mock_preference('IndependentBranches', 0);
1113 my $patron = $builder->build(
1114 { source => 'Borrower',
1115 value => { privacy => 1, }
1118 my $item = $builder->build(
1126 my $issue = $builder->build(
1127 { source => 'Issue',
1129 borrowernumber => $patron->{borrowernumber},
1130 itemnumber => $item->{itemnumber},
1135 my ( $returned, undef, undef ) = C4::Circulation::AddReturn( $item->{barcode}, undef, undef, dt_from_string('2010-10-10') );
1136 is( $returned, 1, 'The item should have been returned' );
1137 my $rows_affected = Koha::Patrons->search_patrons_to_anonymise( { before => '2010-10-11' } )->anonymise_issue_history( { before => '2010-10-11' } );
1138 ok( $rows_affected > 0, 'AnonymiseIssueHistory should affect at least 1 row' );
1140 my $dbh = C4::Context->dbh;
1141 my ($borrowernumber_used_to_anonymised) = $dbh->selectrow_array(q|
1142 SELECT borrowernumber FROM old_issues where itemnumber = ?
1143 |, undef, $item->{itemnumber});
1144 is( $borrowernumber_used_to_anonymised, undef, 'With AnonymousPatron is not defined, the issue should have been anonymised anyway' );
1145 Koha::Patrons->find( $patron->{borrowernumber})->delete;
1148 subtest 'Logged in librarian is not superlibrarian & IndependentBranches' => sub {
1150 t::lib::Mocks::mock_preference( 'IndependentBranches', 1 );
1151 my $patron = $builder->build(
1152 { source => 'Borrower',
1153 value => { privacy => 1 } # Another branchcode than the logged in librarian
1156 my $item = $builder->build(
1164 my $issue = $builder->build(
1165 { source => 'Issue',
1167 borrowernumber => $patron->{borrowernumber},
1168 itemnumber => $item->{itemnumber},
1173 my ( $returned, undef, undef ) = C4::Circulation::AddReturn( $item->{barcode}, undef, undef, dt_from_string('2010-10-10') );
1174 is( Koha::Patrons->search_patrons_to_anonymise( { before => '2010-10-11' } )->count, 0 );
1175 Koha::Patrons->find( $patron->{borrowernumber})->delete;
1178 Koha::Patrons->find( $anonymous->{borrowernumber})->delete;
1179 $userenv_patron->delete;
1181 # Reset IndependentBranches for further tests
1182 t::lib::Mocks::mock_preference('IndependentBranches', 0);
1185 subtest 'libraries_where_can_see_patrons + can_see_patron_infos + search_limited' => sub {
1193 $nb_of_patrons = Koha::Patrons->search->count;
1194 my $group_1 = Koha::Library::Group->new( { title => 'TEST Group 1', ft_hide_patron_info => 1 } )->store;
1195 my $group_2 = Koha::Library::Group->new( { title => 'TEST Group 2', ft_hide_patron_info => 1 } )->store;
1196 my $library_11 = $builder->build( { source => 'Branch' } );
1197 my $library_12 = $builder->build( { source => 'Branch' } );
1198 my $library_21 = $builder->build( { source => 'Branch' } );
1199 $library_11 = Koha::Libraries->find( $library_11->{branchcode} );
1200 $library_12 = Koha::Libraries->find( $library_12->{branchcode} );
1201 $library_21 = Koha::Libraries->find( $library_21->{branchcode} );
1202 Koha::Library::Group->new(
1203 { branchcode => $library_11->branchcode, parent_id => $group_1->id } )->store;
1204 Koha::Library::Group->new(
1205 { branchcode => $library_12->branchcode, parent_id => $group_1->id } )->store;
1206 Koha::Library::Group->new(
1207 { branchcode => $library_21->branchcode, parent_id => $group_2->id } )->store;
1209 my $sth = C4::Context->dbh->prepare(q|INSERT INTO user_permissions( borrowernumber, module_bit, code ) VALUES (?, 4, ?)|); # 4 for borrowers
1210 # 2 patrons from library_11 (group1)
1211 # patron_11_1 see patron's infos from outside its group
1212 # Setting flags => undef to not be considered as superlibrarian
1213 my $patron_11_1 = $builder->build({ source => 'Borrower', value => { branchcode => $library_11->branchcode, flags => undef, }});
1214 $patron_11_1 = Koha::Patrons->find( $patron_11_1->{borrowernumber} );
1215 $sth->execute( $patron_11_1->borrowernumber, 'edit_borrowers' );
1216 $sth->execute( $patron_11_1->borrowernumber, 'view_borrower_infos_from_any_libraries' );
1217 # patron_11_2 can only see patron's info from its group
1218 my $patron_11_2 = $builder->build({ source => 'Borrower', value => { branchcode => $library_11->branchcode, flags => undef, }});
1219 $patron_11_2 = Koha::Patrons->find( $patron_11_2->{borrowernumber} );
1220 $sth->execute( $patron_11_2->borrowernumber, 'edit_borrowers' );
1221 # 1 patron from library_12 (group1)
1222 my $patron_12 = $builder->build({ source => 'Borrower', value => { branchcode => $library_12->branchcode, flags => undef, }});
1223 $patron_12 = Koha::Patrons->find( $patron_12->{borrowernumber} );
1224 # 1 patron from library_21 (group2) can only see patron's info from its group
1225 my $patron_21 = $builder->build({ source => 'Borrower', value => { branchcode => $library_21->branchcode, flags => undef, }});
1226 $patron_21 = Koha::Patrons->find( $patron_21->{borrowernumber} );
1227 $sth->execute( $patron_21->borrowernumber, 'edit_borrowers' );
1229 # Pfiou, we can start now!
1230 subtest 'libraries_where_can_see_patrons' => sub {
1235 t::lib::Mocks::mock_userenv({ patron => $patron_11_1 });
1236 @branchcodes = $patron_11_1->libraries_where_can_see_patrons;
1237 is_deeply( \@branchcodes, [], q|patron_11_1 has view_borrower_infos_from_any_libraries => No restriction| );
1239 t::lib::Mocks::mock_userenv({ patron => $patron_11_2 });
1240 @branchcodes = $patron_11_2->libraries_where_can_see_patrons;
1241 is_deeply( \@branchcodes, [ sort ( $library_11->branchcode, $library_12->branchcode ) ], q|patron_11_2 has not view_borrower_infos_from_any_libraries => Can only see patron's from its group| );
1243 t::lib::Mocks::mock_userenv({ patron => $patron_21 });
1244 @branchcodes = $patron_21->libraries_where_can_see_patrons;
1245 is_deeply( \@branchcodes, [$library_21->branchcode], q|patron_21 has not view_borrower_infos_from_any_libraries => Can only see patron's from its group| );
1247 subtest 'can_see_patron_infos' => sub {
1250 t::lib::Mocks::mock_userenv({ patron => $patron_11_1 });
1251 is( $patron_11_1->can_see_patron_infos( $patron_11_2 ), 1, q|patron_11_1 can see patron_11_2, from its library| );
1252 is( $patron_11_1->can_see_patron_infos( $patron_12 ), 1, q|patron_11_1 can see patron_12, from its group| );
1253 is( $patron_11_1->can_see_patron_infos( $patron_21 ), 1, q|patron_11_1 can see patron_11_2, from another group| );
1255 t::lib::Mocks::mock_userenv({ patron => $patron_11_2 });
1256 is( $patron_11_2->can_see_patron_infos( $patron_11_1 ), 1, q|patron_11_2 can see patron_11_1, from its library| );
1257 is( $patron_11_2->can_see_patron_infos( $patron_12 ), 1, q|patron_11_2 can see patron_12, from its group| );
1258 is( $patron_11_2->can_see_patron_infos( $patron_21 ), 0, q|patron_11_2 can NOT see patron_21, from another group| );
1260 subtest 'search_limited' => sub {
1263 t::lib::Mocks::mock_userenv({ patron => $patron_11_1 });
1264 my $total_number_of_patrons = $nb_of_patrons + 4; #we added four in these tests
1265 is( Koha::Patrons->search->count, $total_number_of_patrons, 'Non-limited search should return all patrons' );
1266 is( Koha::Patrons->search_limited->count, $total_number_of_patrons, 'patron_11_1 is allowed to see all patrons' );
1268 t::lib::Mocks::mock_userenv({ patron => $patron_11_2 });
1269 is( Koha::Patrons->search->count, $total_number_of_patrons, 'Non-limited search should return all patrons');
1270 is( Koha::Patrons->search_limited->count, 3, 'patron_12_1 is not allowed to see patrons from other groups, only patron_11_1, patron_11_2 and patron_12' );
1272 t::lib::Mocks::mock_userenv({ patron => $patron_21 });
1273 is( Koha::Patrons->search->count, $total_number_of_patrons, 'Non-limited search should return all patrons');
1274 is( Koha::Patrons->search_limited->count, 1, 'patron_21 is not allowed to see patrons from other groups, only himself' );
1276 $patron_11_1->delete;
1277 $patron_11_2->delete;
1282 subtest 'account_locked' => sub {
1284 my $patron = $builder->build({ source => 'Borrower', value => { login_attempts => 0 } });
1285 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
1286 for my $value ( undef, '', 0 ) {
1287 t::lib::Mocks::mock_preference('FailedloginAttempts', $value);
1288 $patron->login_attempts(0)->store;
1289 is( $patron->account_locked, 0, 'Feature is disabled, patron account should not be considered locked' );
1290 $patron->login_attempts(1)->store;
1291 is( $patron->account_locked, 0, 'Feature is disabled, patron account should not be considered locked' );
1292 $patron->login_attempts(-1)->store;
1293 is( $patron->account_locked, 1, 'Feature is disabled but administrative lockout has been triggered' );
1296 t::lib::Mocks::mock_preference('FailedloginAttempts', 3);
1297 $patron->login_attempts(2)->store;
1298 is( $patron->account_locked, 0, 'Patron has 2 failed attempts, account should not be considered locked yet' );
1299 $patron->login_attempts(3)->store;
1300 is( $patron->account_locked, 1, 'Patron has 3 failed attempts, account should be considered locked yet' );
1301 $patron->login_attempts(4)->store;
1302 is( $patron->account_locked, 1, 'Patron could not have 4 failed attempts, but account should still be considered locked' );
1303 $patron->login_attempts(-1)->store;
1304 is( $patron->account_locked, 1, 'Administrative lockout triggered' );
1309 subtest 'is_child | is_adult' => sub {
1311 my $category = $builder->build_object(
1313 class => 'Koha::Patron::Categories',
1314 value => { category_type => 'A' }
1317 my $patron_adult = $builder->build_object(
1319 class => 'Koha::Patrons',
1320 value => { categorycode => $category->categorycode }
1323 $category = $builder->build_object(
1325 class => 'Koha::Patron::Categories',
1326 value => { category_type => 'I' }
1329 my $patron_adult_i = $builder->build_object(
1331 class => 'Koha::Patrons',
1332 value => { categorycode => $category->categorycode }
1335 $category = $builder->build_object(
1337 class => 'Koha::Patron::Categories',
1338 value => { category_type => 'C' }
1341 my $patron_child = $builder->build_object(
1343 class => 'Koha::Patrons',
1344 value => { categorycode => $category->categorycode }
1347 $category = $builder->build_object(
1349 class => 'Koha::Patron::Categories',
1350 value => { category_type => 'O' }
1353 my $patron_other = $builder->build_object(
1355 class => 'Koha::Patrons',
1356 value => { categorycode => $category->categorycode }
1359 is( $patron_adult->is_adult, 1, 'Patron from category A should be considered adult' );
1360 is( $patron_adult_i->is_adult, 1, 'Patron from category I should be considered adult' );
1361 is( $patron_child->is_adult, 0, 'Patron from category C should not be considered adult' );
1362 is( $patron_other->is_adult, 0, 'Patron from category O should not be considered adult' );
1364 is( $patron_adult->is_child, 0, 'Patron from category A should be considered child' );
1365 is( $patron_adult_i->is_child, 0, 'Patron from category I should be considered child' );
1366 is( $patron_child->is_child, 1, 'Patron from category C should not be considered child' );
1367 is( $patron_other->is_child, 0, 'Patron from category O should not be considered child' );
1370 $patron_adult->delete;
1371 $patron_adult_i->delete;
1372 $patron_child->delete;
1373 $patron_other->delete;
1376 subtest 'get_overdues' => sub {
1379 my $library = $builder->build( { source => 'Branch' } );
1380 my ($biblionumber_1) = AddBiblio( MARC::Record->new, '' );
1381 my $item_1 = $builder->build(
1385 homebranch => $library->{branchcode},
1386 holdingbranch => $library->{branchcode},
1387 biblionumber => $biblionumber_1
1391 my $item_2 = $builder->build(
1395 homebranch => $library->{branchcode},
1396 holdingbranch => $library->{branchcode},
1397 biblionumber => $biblionumber_1
1401 my ($biblionumber_2) = AddBiblio( MARC::Record->new, '' );
1402 my $item_3 = $builder->build(
1406 homebranch => $library->{branchcode},
1407 holdingbranch => $library->{branchcode},
1408 biblionumber => $biblionumber_2
1412 my $patron = $builder->build(
1414 source => 'Borrower',
1415 value => { branchcode => $library->{branchcode} }
1419 t::lib::Mocks::mock_preference({ branchcode => $library->{branchcode} });
1421 AddIssue( $patron, $item_1->{barcode}, DateTime->now->subtract( days => 1 ) );
1422 AddIssue( $patron, $item_2->{barcode}, DateTime->now->subtract( days => 5 ) );
1423 AddIssue( $patron, $item_3->{barcode} );
1425 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
1426 my $overdues = $patron->get_overdues;
1427 is( $overdues->count, 2, 'Patron should have 2 overdues');
1428 is( $overdues->next->itemnumber, $item_1->{itemnumber}, 'The issue should be returned in the same order as they have been done, first is correct' );
1429 is( $overdues->next->itemnumber, $item_2->{itemnumber}, 'The issue should be returned in the same order as they have been done, second is correct' );
1431 my $o = $overdues->reset->next;
1432 my $unblessed_overdue = $o->unblessed_all_relateds;
1433 is( exists( $unblessed_overdue->{issuedate} ), 1, 'Fields from the issues table should be filled' );
1434 is( exists( $unblessed_overdue->{itemcallnumber} ), 1, 'Fields from the items table should be filled' );
1435 is( exists( $unblessed_overdue->{title} ), 1, 'Fields from the biblio table should be filled' );
1436 is( exists( $unblessed_overdue->{itemtype} ), 1, 'Fields from the biblioitems table should be filled' );
1439 $patron->checkouts->delete;
1443 subtest 'userid_is_valid' => sub {
1446 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
1447 my $patron_category = $builder->build_object(
1449 class => 'Koha::Patron::Categories',
1450 value => { category_type => 'P', enrolmentfee => 0 }
1454 cardnumber => "123456789",
1455 firstname => "Tomasito",
1457 categorycode => $patron_category->categorycode,
1458 branchcode => $library->branchcode,
1461 my $expected_userid_patron_1 = 'tomasito.none';
1462 my $borrowernumber = Koha::Patron->new(\%data)->store->borrowernumber;
1463 my $patron_1 = Koha::Patrons->find($borrowernumber);
1464 is( $patron_1->has_valid_userid, 1, "Should be valid when compared against them self" );
1465 is ( $patron_1->userid, $expected_userid_patron_1, 'The userid generated should be the one we expect' );
1467 $patron_1->userid( 'tomasito.non' );
1468 is( $patron_1->has_valid_userid, # FIXME Joubu: What is the difference with the next test?
1469 1, 'recently created userid -> unique (borrowernumber passed)' );
1471 $patron_1->userid( 'tomasitoxxx' );
1472 is( $patron_1->has_valid_userid,
1473 1, 'non-existent userid -> unique (borrowernumber passed)' );
1474 $patron_1->discard_changes; # We compare with the original userid later
1476 my $patron_not_in_storage = Koha::Patron->new( { userid => '' } );
1477 is( $patron_not_in_storage->has_valid_userid,
1478 0, 'userid exists for another patron, patron is not in storage yet' );
1480 $patron_not_in_storage = Koha::Patron->new( { userid => 'tomasitoxxx' } );
1481 is( $patron_not_in_storage->has_valid_userid,
1482 1, 'non-existent userid, patron is not in storage yet' );
1484 # Regression tests for BZ12226
1485 my $db_patron = Koha::Patron->new( { userid => C4::Context->config('user') } );
1486 is( $db_patron->has_valid_userid,
1487 0, 'Koha::Patron->has_valid_userid should return 0 for the DB user (Bug 12226)' );
1489 # Add a new borrower with the same userid but different cardnumber
1490 $data{cardnumber} = "987654321";
1491 my $new_borrowernumber = Koha::Patron->new(\%data)->store->borrowernumber;
1492 my $patron_2 = Koha::Patrons->find($new_borrowernumber);
1493 $patron_2->userid($patron_1->userid);
1494 is( $patron_2->has_valid_userid,
1495 0, 'The userid is already in used, it cannot be used for another patron' );
1497 my $new_userid = 'a_user_id';
1498 $data{cardnumber} = "234567890";
1499 $data{userid} = 'a_user_id';
1500 $borrowernumber = Koha::Patron->new(\%data)->store->borrowernumber;
1501 my $patron_3 = Koha::Patrons->find($borrowernumber);
1502 is( $patron_3->userid, $new_userid,
1503 'Koha::Patron->store should insert the given userid' );
1511 subtest 'generate_userid' => sub {
1514 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
1515 my $patron_category = $builder->build_object(
1517 class => 'Koha::Patron::Categories',
1518 value => { category_type => 'P', enrolmentfee => 0 }
1522 cardnumber => "123456789",
1523 firstname => "Tômà sÃtó",
1524 surname => "Ñoné",
1525 categorycode => $patron_category->categorycode,
1526 branchcode => $library->branchcode,
1529 my $expected_userid_patron_1 = 'tomasito.none';
1530 my $new_patron = Koha::Patron->new({ firstname => $data{firstname}, surname => $data{surname} } );
1531 $new_patron->generate_userid;
1532 my $userid = $new_patron->userid;
1533 is( $userid, $expected_userid_patron_1, 'generate_userid should generate the userid we expect' );
1534 my $borrowernumber = Koha::Patron->new(\%data)->store->borrowernumber;
1535 my $patron_1 = Koha::Patrons->find($borrowernumber);
1536 is ( $patron_1->userid, $expected_userid_patron_1, 'The userid generated should be the one we expect' );
1538 $new_patron->generate_userid;
1539 $userid = $new_patron->userid;
1540 is( $userid, $expected_userid_patron_1 . '1', 'generate_userid should generate the userid we expect' );
1541 $data{cardnumber} = '987654321';
1542 my $new_borrowernumber = Koha::Patron->new(\%data)->store->borrowernumber;
1543 my $patron_2 = Koha::Patrons->find($new_borrowernumber);
1544 isnt( $patron_2->userid, 'tomasito',
1545 "Patron with duplicate userid has new userid generated" );
1546 is( $patron_2->userid, $expected_userid_patron_1 . '1', # TODO we could make that configurable
1547 "Patron with duplicate userid has new userid generated (1 is appened" );
1549 $new_patron->generate_userid;
1550 $userid = $new_patron->userid;
1551 is( $userid, $expected_userid_patron_1 . '2', 'generate_userid should generate the userid we expect' );
1553 $patron_1 = Koha::Patrons->find($borrowernumber);
1554 $patron_1->userid(undef);
1555 $patron_1->generate_userid;
1556 $userid = $patron_1->userid;
1557 is( $userid, $expected_userid_patron_1, 'generate_userid should generate the userid we expect' );
1564 subtest 'attributes' => sub {
1567 my $library1 = Koha::Library->new({
1568 branchcode => 'LIBPATRON',
1569 branchname => 'Library of testing patron',
1572 my $library2 = Koha::Library->new({
1573 branchcode => 'LIBATTR',
1574 branchname => 'Library for testing attribute',
1577 my $category = Koha::Patron::Category->new({
1578 categorycode => 'CAT1',
1579 description => 'Category 1',
1582 my $patron = Koha::Patron->new({
1583 firstname => 'Patron',
1584 surname => 'with attributes',
1585 branchcode => 'LIBPATRON',
1586 categorycode => 'CAT1',
1589 my $attribute_type1 = Koha::Patron::Attribute::Type->new({
1591 description => 'Code A desciption',
1594 my $attribute_type2 = Koha::Patron::Attribute::Type->new({
1596 description => 'Code A desciption',
1599 $attribute_type2->library_limits ( [ $library2->branchcode ] );
1601 Koha::Patron::Attribute->new({ borrowernumber => $patron->borrowernumber, code => $attribute_type1->code, attribute => 'value 1' } )->store();
1602 Koha::Patron::Attribute->new({ borrowernumber => $patron->borrowernumber, code => $attribute_type2->code, attribute => 'value 2' } )->store();
1604 is( $patron->attributes->count, 1, 'There should be one attribute');
1606 $attribute_type2->library_limits ( [ $library1->branchcode ] );
1608 is( $patron->attributes->count, 2, 'There should be 2 attributes');
1613 $nb_of_patrons = Koha::Patrons->search->count;
1614 $retrieved_patron_1->delete;
1615 is( Koha::Patrons->search->count, $nb_of_patrons - 1, 'Delete should have deleted the patron' );
1617 subtest 'BorrowersLog tests' => sub {
1620 t::lib::Mocks::mock_preference( 'BorrowersLog', 1 );
1621 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
1623 my $cardnumber = $patron->cardnumber;
1624 $patron->set( { cardnumber => 'TESTCARDNUMBER' });
1627 my @logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'MODIFY', object => $patron->borrowernumber } );
1628 my $log_info = from_json( $logs[0]->info );
1629 is( $log_info->{cardnumber}->{after}, 'TESTCARDNUMBER', 'Got correct new cardnumber' );
1630 is( $log_info->{cardnumber}->{before}, $cardnumber, 'Got correct old cardnumber' );
1631 is( scalar @logs, 1, 'With BorrowerLogs, one detailed MODIFY action should be logged for the modification.' );
1633 t::lib::Mocks::mock_preference( 'TrackLastPatronActivity', 1 );
1634 $patron->track_login();
1635 @logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'MODIFY', object => $patron->borrowernumber } );
1636 is( scalar @logs, 1, 'With BorrowerLogs and TrackLastPatronActivity we should not spam the logs');
1639 $schema->storage->txn_rollback;
1641 subtest 'Test Koha::Patrons::merge' => sub {
1644 my $schema = Koha::Database->new()->schema();
1646 my $resultsets = $Koha::Patron::RESULTSET_PATRON_ID_MAPPING;
1648 $schema->storage->txn_begin;
1650 my $keeper = $builder->build_object({ class => 'Koha::Patrons' });
1651 my $loser_1 = $builder->build({ source => 'Borrower' })->{borrowernumber};
1652 my $loser_2 = $builder->build({ source => 'Borrower' })->{borrowernumber};
1654 while (my ($r, $field) = each(%$resultsets)) {
1655 $builder->build({ source => $r, value => { $field => $keeper->id } });
1656 $builder->build({ source => $r, value => { $field => $loser_1 } });
1657 $builder->build({ source => $r, value => { $field => $loser_2 } });
1660 $schema->resultset($r)->search( { $field => $keeper->id } );
1661 is( $keeper_rs->count(), 1, "Found 1 $r rows for keeper" );
1664 $schema->resultset($r)->search( { $field => $loser_1 } );
1665 is( $loser_1_rs->count(), 1, "Found 1 $r rows for loser_1" );
1668 $schema->resultset($r)->search( { $field => $loser_2 } );
1669 is( $loser_2_rs->count(), 1, "Found 1 $r rows for loser_2" );
1672 my $results = $keeper->merge_with([ $loser_1, $loser_2 ]);
1674 while (my ($r, $field) = each(%$resultsets)) {
1676 $schema->resultset($r)->search( {$field => $keeper->id } );
1677 is( $keeper_rs->count(), 3, "Found 2 $r rows for keeper" );
1680 is( Koha::Patrons->find($loser_1), undef, 'Loser 1 has been deleted' );
1681 is( Koha::Patrons->find($loser_2), undef, 'Loser 2 has been deleted' );
1683 $schema->storage->txn_rollback;
1686 subtest '->store' => sub {
1688 my $schema = Koha::Database->new->schema;
1689 $schema->storage->txn_begin;
1691 my $print_error = $schema->storage->dbh->{PrintError};
1692 $schema->storage->dbh->{PrintError} = 0; ; # FIXME This does not longer work - because of the transaction in Koha::Patron->store?
1694 my $patron_1 = $builder->build_object({class=> 'Koha::Patrons'});
1695 my $patron_2 = $builder->build_object({class=> 'Koha::Patrons'});
1698 { $patron_2->userid($patron_1->userid)->store; }
1699 'Koha::Exceptions::Object::DuplicateID',
1700 'Koha::Patron->store raises an exception on duplicate ID';
1703 t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
1704 my $password = 'password';
1705 $patron_1->set_password({ password => $password });
1706 like( $patron_1->password, qr|^\$2|, 'Password should be hashed using bcrypt (start with $2)' );
1707 my $digest = $patron_1->password;
1708 $patron_1->surname('xxx')->store;
1709 is( $patron_1->password, $digest, 'Password should not have changed on ->store');
1711 # Test uppercasesurnames
1712 t::lib::Mocks::mock_preference( 'uppercasesurnames', 1 );
1713 my $surname = lc $patron_1->surname;
1714 $patron_1->surname($surname)->store;
1715 isnt( $patron_1->surname, $surname,
1716 'Surname converts to uppercase on store.');
1717 t::lib::Mocks::mock_preference( 'uppercasesurnames', 0 );
1718 $patron_1->surname($surname)->store;
1719 is( $patron_1->surname, $surname,
1720 'Surname remains unchanged on store.');
1723 $patron_1->relationship("")->store;
1724 is( $patron_1->relationship, undef, );
1726 $schema->storage->dbh->{PrintError} = $print_error;
1727 $schema->storage->txn_rollback;
1729 subtest 'skip updated_on for BorrowersLog' => sub {
1731 $schema->storage->txn_begin;
1732 t::lib::Mocks::mock_preference('BorrowersLog', 1);
1733 my $patron = $builder->build_object({ class => 'Koha::Patrons' });
1734 $patron->updated_on(dt_from_string($patron->updated_on)->add( seconds => 1 ))->store;
1735 my $logs = Koha::ActionLogs->search({ module =>'MEMBERS', action => 'MODIFY', object => $patron->borrowernumber });
1736 is($logs->count, 0, '->store should not have generated a log for updated_on') or diag 'Log generated:'.Dumper($logs->unblessed);
1737 $schema->storage->txn_rollback;
1741 subtest '->set_password' => sub {
1745 $schema->storage->txn_begin;
1747 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { login_attempts => 3 } } );
1749 # Disable logging password changes for this tests
1750 t::lib::Mocks::mock_preference( 'BorrowersLog', 0 );
1752 # Password-length tests
1753 t::lib::Mocks::mock_preference( 'minPasswordLength', undef );
1754 throws_ok { $patron->set_password({ password => 'ab' }); }
1755 'Koha::Exceptions::Password::TooShort',
1756 'minPasswordLength is undef, fall back to 3, fail test';
1758 'Password length (2) is shorter than required (3)',
1759 'Exception parameters passed correctly'
1762 t::lib::Mocks::mock_preference( 'minPasswordLength', 2 );
1763 throws_ok { $patron->set_password({ password => 'ab' }); }
1764 'Koha::Exceptions::Password::TooShort',
1765 'minPasswordLength is 2, fall back to 3, fail test';
1767 t::lib::Mocks::mock_preference( 'minPasswordLength', 5 );
1768 throws_ok { $patron->set_password({ password => 'abcb' }); }
1769 'Koha::Exceptions::Password::TooShort',
1770 'minPasswordLength is 5, fail test';
1772 # Trailing spaces tests
1773 throws_ok { $patron->set_password({ password => 'abcD12d ' }); }
1774 'Koha::Exceptions::Password::WhitespaceCharacters',
1775 'Password contains trailing spaces, exception is thrown';
1777 # Require strong password tests
1778 t::lib::Mocks::mock_preference( 'RequireStrongPassword', 1 );
1779 throws_ok { $patron->set_password({ password => 'abcd a' }); }
1780 'Koha::Exceptions::Password::TooWeak',
1781 'Password is too weak, exception is thrown';
1783 # Refresh patron from DB, just to make sure
1784 $patron->discard_changes;
1785 is( $patron->login_attempts, 3, 'Previous tests kept login attemps count' );
1787 $patron->set_password({ password => 'abcD12 34' });
1788 $patron->discard_changes;
1790 is( $patron->login_attempts, 0, 'Changing the password resets the login attempts count' );
1792 lives_ok { $patron->set_password({ password => 'abcd a', skip_validation => 1 }) }
1793 'Password is weak, but skip_validation was passed, so no exception thrown';
1796 t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
1797 $patron->login_attempts(3)->store;
1798 my $old_digest = $patron->password;
1799 $patron->set_password({ password => 'abcd a' });
1800 $patron->discard_changes;
1802 isnt( $patron->password, $old_digest, 'Password has been updated' );
1803 ok( checkpw_hash('abcd a', $patron->password), 'Password hash is correct' );
1804 is( $patron->login_attempts, 0, 'Login attemps have been reset' );
1806 my $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'CHANGE PASS', object => $patron->borrowernumber } )->count;
1807 is( $number_of_logs, 0, 'Without BorrowerLogs, Koha::Patron->set_password doesn\'t log password changes' );
1809 # Enable logging password changes
1810 t::lib::Mocks::mock_preference( 'BorrowersLog', 1 );
1811 $patron->set_password({ password => 'abcd b' });
1813 $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'CHANGE PASS', object => $patron->borrowernumber } )->count;
1814 is( $number_of_logs, 1, 'With BorrowerLogs, Koha::Patron->set_password does log password changes' );
1816 $schema->storage->txn_rollback;
1819 $schema->storage->txn_begin;
1820 subtest 'search_unsubscribed' => sub {
1823 t::lib::Mocks::mock_preference( 'FailedLoginAttempts', 3 );
1824 t::lib::Mocks::mock_preference( 'UnsubscribeReflectionDelay', '' );
1825 is( Koha::Patrons->search_unsubscribed->count, 0, 'Empty delay should return empty set' );
1827 my $patron1 = $builder->build_object({ class => 'Koha::Patrons' });
1828 my $patron2 = $builder->build_object({ class => 'Koha::Patrons' });
1830 t::lib::Mocks::mock_preference( 'UnsubscribeReflectionDelay', 0 );
1831 Koha::Patron::Consents->delete; # for correct counts
1832 Koha::Patron::Consent->new({ borrowernumber => $patron1->borrowernumber, type => 'GDPR_PROCESSING', refused_on => dt_from_string })->store;
1833 is( Koha::Patrons->search_unsubscribed->count, 1, 'Find patron1' );
1835 # Add another refusal but shift the period
1836 t::lib::Mocks::mock_preference( 'UnsubscribeReflectionDelay', 2 );
1837 Koha::Patron::Consent->new({ borrowernumber => $patron2->borrowernumber, type => 'GDPR_PROCESSING', refused_on => dt_from_string->subtract(days=>2) })->store;
1838 is( Koha::Patrons->search_unsubscribed->count, 1, 'Find patron2 only' );
1840 # Try another (special) attempts setting
1841 t::lib::Mocks::mock_preference( 'FailedLoginAttempts', 0 );
1842 # Lockout is now disabled
1843 # Patron2 still matches: refused earlier, not locked
1844 is( Koha::Patrons->search_unsubscribed->count, 1, 'Lockout disabled' );
1847 subtest 'search_anonymize_candidates' => sub {
1849 my $patron1 = $builder->build_object({ class => 'Koha::Patrons' });
1850 my $patron2 = $builder->build_object({ class => 'Koha::Patrons' });
1851 $patron1->anonymized(0);
1852 $patron1->dateexpiry( dt_from_string->add(days => 1) )->store;
1853 $patron2->anonymized(0);
1854 $patron2->dateexpiry( dt_from_string->add(days => 1) )->store;
1856 t::lib::Mocks::mock_preference( 'PatronAnonymizeDelay', q{} );
1857 is( Koha::Patrons->search_anonymize_candidates->count, 0, 'Empty set' );
1859 t::lib::Mocks::mock_preference( 'PatronAnonymizeDelay', 0 );
1860 my $cnt = Koha::Patrons->search_anonymize_candidates->count;
1861 $patron1->dateexpiry( dt_from_string->subtract(days => 1) )->store;
1862 $patron2->dateexpiry( dt_from_string->subtract(days => 3) )->store;
1863 is( Koha::Patrons->search_anonymize_candidates->count, $cnt+2, 'Delay 0' );
1865 t::lib::Mocks::mock_preference( 'PatronAnonymizeDelay', 2 );
1866 $patron1->dateexpiry( dt_from_string->add(days => 1) )->store;
1867 $patron2->dateexpiry( dt_from_string->add(days => 1) )->store;
1868 $cnt = Koha::Patrons->search_anonymize_candidates->count;
1869 $patron1->dateexpiry( dt_from_string->subtract(days => 1) )->store;
1870 $patron2->dateexpiry( dt_from_string->subtract(days => 3) )->store;
1871 is( Koha::Patrons->search_anonymize_candidates->count, $cnt+1, 'Delay 2' );
1873 t::lib::Mocks::mock_preference( 'PatronAnonymizeDelay', 4 );
1874 $patron1->dateexpiry( dt_from_string->add(days => 1) )->store;
1875 $patron2->dateexpiry( dt_from_string->add(days => 1) )->store;
1876 $cnt = Koha::Patrons->search_anonymize_candidates->count;
1877 $patron1->dateexpiry( dt_from_string->subtract(days => 1) )->store;
1878 $patron2->dateexpiry( dt_from_string->subtract(days => 3) )->store;
1879 is( Koha::Patrons->search_anonymize_candidates->count, $cnt, 'Delay 4' );
1881 t::lib::Mocks::mock_preference( 'FailedLoginAttempts', 3 );
1882 $patron1->dateexpiry( dt_from_string->subtract(days => 5) )->store;
1883 $patron1->login_attempts(0)->store;
1884 $patron2->dateexpiry( dt_from_string->subtract(days => 5) )->store;
1885 $patron2->login_attempts(0)->store;
1886 $cnt = Koha::Patrons->search_anonymize_candidates({locked => 1})->count;
1887 $patron1->login_attempts(3)->store;
1888 is( Koha::Patrons->search_anonymize_candidates({locked => 1})->count,
1889 $cnt+1, 'Locked flag' );
1892 subtest 'search_anonymized' => sub {
1894 my $patron1 = $builder->build_object( { class => 'Koha::Patrons' } );
1896 t::lib::Mocks::mock_preference( 'PatronRemovalDelay', q{} );
1897 is( Koha::Patrons->search_anonymized->count, 0, 'Empty set' );
1899 t::lib::Mocks::mock_preference( 'PatronRemovalDelay', 1 );
1900 $patron1->dateexpiry( dt_from_string );
1901 $patron1->anonymized(0)->store;
1902 my $cnt = Koha::Patrons->search_anonymized->count;
1903 $patron1->anonymized(1)->store;
1904 is( Koha::Patrons->search_anonymized->count, $cnt, 'Number unchanged' );
1905 $patron1->dateexpiry( dt_from_string->subtract(days => 1) )->store;
1906 is( Koha::Patrons->search_anonymized->count, $cnt+1, 'Found patron1' );
1909 subtest 'lock' => sub {
1912 my $patron1 = $builder->build_object( { class => 'Koha::Patrons' } );
1913 my $patron2 = $builder->build_object( { class => 'Koha::Patrons' } );
1914 my $hold = $builder->build_object({
1915 class => 'Koha::Holds',
1916 value => { borrowernumber => $patron1->borrowernumber },
1919 t::lib::Mocks::mock_preference( 'FailedLoginAttempts', 3 );
1920 my $expiry = dt_from_string->add(days => 1);
1921 $patron1->dateexpiry( $expiry );
1923 is( $patron1->login_attempts, Koha::Patron::ADMINISTRATIVE_LOCKOUT, 'Check login_attempts' );
1924 is( $patron1->dateexpiry, $expiry, 'Not expired yet' );
1925 is( $patron1->holds->count, 1, 'No holds removed' );
1927 $patron1->lock({ expire => 1, remove => 1});
1928 isnt( $patron1->dateexpiry, $expiry, 'Expiry date adjusted' );
1929 is( $patron1->holds->count, 0, 'Holds removed' );
1931 # Disable lockout feature
1932 t::lib::Mocks::mock_preference( 'FailedLoginAttempts', q{} );
1933 $patron1->login_attempts(0);
1934 $patron1->dateexpiry( $expiry );
1937 is( $patron1->login_attempts, Koha::Patron::ADMINISTRATIVE_LOCKOUT, 'Check login_attempts' );
1939 # Trivial wrapper test (Koha::Patrons->lock)
1940 $patron1->login_attempts(0)->store;
1941 Koha::Patrons->search({ borrowernumber => [ $patron1->borrowernumber, $patron2->borrowernumber ] })->lock;
1942 $patron1->discard_changes; # refresh
1943 $patron2->discard_changes;
1944 is( $patron1->login_attempts, Koha::Patron::ADMINISTRATIVE_LOCKOUT, 'Check login_attempts patron 1' );
1945 is( $patron2->login_attempts, Koha::Patron::ADMINISTRATIVE_LOCKOUT, 'Check login_attempts patron 2' );
1948 subtest 'anonymize' => sub {
1951 my $patron1 = $builder->build_object( { class => 'Koha::Patrons' } );
1952 my $patron2 = $builder->build_object( { class => 'Koha::Patrons' } );
1954 # First try patron with issues
1955 my $issue = $builder->build_object({ class => 'Koha::Checkouts', value => { borrowernumber => $patron2->borrowernumber } });
1956 warning_like { $patron2->anonymize } qr/still has issues/, 'Skip patron with issues';
1959 t::lib::Mocks::mock_preference( 'BorrowerMandatoryField', 'surname|email|cardnumber' );
1960 my $surname = $patron1->surname; # expect change, no clear
1961 my $branchcode = $patron1->branchcode; # expect skip
1962 $patron1->anonymize;
1963 is($patron1->anonymized, 1, 'Check flag' );
1965 is( $patron1->dateofbirth, undef, 'Birth date cleared' );
1966 is( $patron1->firstname, undef, 'First name cleared' );
1967 isnt( $patron1->surname, $surname, 'Surname changed' );
1968 ok( $patron1->surname =~ /^\w{10}$/, 'Mandatory surname randomized' );
1969 is( $patron1->branchcode, $branchcode, 'Branch code skipped' );
1970 is( $patron1->email, undef, 'Email was mandatory, must be cleared' );
1972 # Test wrapper in Koha::Patrons
1973 $patron1->surname($surname)->store; # restore
1974 my $rs = Koha::Patrons->search({ borrowernumber => [ $patron1->borrowernumber, $patron2->borrowernumber ] })->anonymize;
1975 $patron1->discard_changes; # refresh
1976 isnt( $patron1->surname, $surname, 'Surname patron1 changed again' );
1977 $patron2->discard_changes; # refresh
1978 is( $patron2->firstname, undef, 'First name patron2 cleared' );
1980 $schema->storage->txn_rollback;