3 # This file is part of Koha.
5 # Koha is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License as published by
7 # the Free Software Foundation; either version 3 of the License, or
8 # (at your option) any later version.
10 # Koha is distributed in the hope that it will be useful, but
11 # WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
15 # You should have received a copy of the GNU General Public License
16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
20 use DateTime::Duration;
21 use Test::More tests => 91;
25 use t::lib::TestBuilder;
28 use C4::Letters qw( GetQueuedMessages GetMessage );
29 use C4::Budgets qw( AddBudgetPeriod AddBudget GetBudget );
31 use Koha::DateUtils qw( dt_from_string output_pref );
34 use Koha::Suggestions;
37 use_ok('C4::Suggestions', qw( NewSuggestion GetSuggestion ModSuggestion GetSuggestionInfo GetSuggestionFromBiblionumber GetSuggestionInfoFromBiblionumber GetSuggestionByStatus ConnectSuggestionAndBiblio DelSuggestion MarcRecordFromNewSuggestion GetUnprocessedSuggestions DelSuggestionsOlderThan ));
40 my $schema = Koha::Database->new->schema;
41 $schema->storage->txn_begin;
42 my $dbh = C4::Context->dbh;
43 my $builder = t::lib::TestBuilder->new;
45 t::lib::Mocks::mock_preference( "EmailPurchaseSuggestions", "0");
47 # Reset item types to only the default ones
48 $dbh->do(q|DELETE FROM itemtypes;|);
50 INSERT INTO itemtypes (itemtype, description, rentalcharge, notforloan, imageurl, summary) VALUES
51 ('BK', 'Books',5,0,'bridge/book.png',''),
52 ('MX', 'Mixed Materials',5,0,'bridge/kit.png',''),
53 ('CF', 'Computer Files',5,0,'bridge/computer_file.png',''),
54 ('MP', 'Maps',5,0,'bridge/map.png',''),
55 ('VM', 'Visual Materials',5,1,'bridge/dvd.png',''),
56 ('MU', 'Music',5,0,'bridge/sound.png',''),
57 ('CR', 'Continuing Resources',5,0,'bridge/periodical.png',''),
58 ('REF', 'Reference',0,1,'bridge/reference.png','');|;
60 $dbh->do(q|DELETE FROM suggestions|);
61 $dbh->do(q|DELETE FROM issues|);
62 $dbh->do(q|DELETE FROM borrowers|);
63 $dbh->do(q|DELETE FROM letter|);
64 $dbh->do(q|DELETE FROM message_queue|);
65 $dbh->do(q|INSERT INTO letter(module, code, content) VALUES ('suggestions', 'CHECKED', 'my content')|);
66 $dbh->do(q|INSERT INTO letter(module, code, content) VALUES ('suggestions', 'NEW_SUGGESTION', 'Content for new suggestion')|);
69 if (not defined Koha::Libraries->find('CPL')) {
70 Koha::Library->new({ branchcode => 'CPL', branchname => 'Centerville' })->store;
73 my $patron_category = $builder->build({ source => 'Category' });
76 firstname => 'my firstname',
77 surname => 'my surname',
78 categorycode => $patron_category->{categorycode},
80 smsalertnumber => 12345,
84 firstname => 'my firstname',
85 surname => 'my surname',
86 categorycode => $patron_category->{categorycode},
88 email => 'to@example.com',
91 my $borrowernumber = Koha::Patron->new($member)->store->borrowernumber;
92 my $borrowernumber2 = Koha::Patron->new($member2)->store->borrowernumber;
94 my $biblio_1 = $builder->build_object({ class => 'Koha::Biblios' });
97 author => 'my author',
98 publishercode => 'my publishercode',
99 suggestedby => $borrowernumber,
100 biblionumber => $biblio_1->biblionumber,
104 accepteddate => dt_from_string,
106 quantity => '', # Insert an empty string into int to catch strict SQL modes errors
109 my $budgetperiod_id = AddBudgetPeriod({
110 budget_period_startdate => '2008-01-01',
111 budget_period_enddate => '2008-12-31',
112 budget_period_description => 'MAPERI',
113 budget_period_active => 1,
116 my $budget_id = AddBudget({
117 budget_code => 'ABCD',
118 budget_amount => '123.132000',
119 budget_name => 'ABCD',
120 budget_notes => 'This is a note',
121 budget_period_id => $budgetperiod_id,
123 my $my_suggestion_with_budget = {
124 title => 'my title 2',
125 author => 'my author 2',
126 publishercode => 'my publishercode 2',
127 suggestedby => $borrowernumber,
128 branchcode => '', # This should not fail be set to undef instead
129 biblionumber => $biblio_1->biblionumber,
132 accepteddate => dt_from_string,
134 budgetid => $budget_id,
136 my $my_suggestion_with_budget2 = {
137 title => 'my title 3',
138 author => 'my author 3',
139 publishercode => 'my publishercode 3',
140 suggestedby => $borrowernumber2,
141 biblionumber => $biblio_1->biblionumber,
144 accepteddate => dt_from_string,
146 budgetid => $budget_id,
148 my $my_suggestion_without_suggestedby = {
150 author => 'my author',
151 publishercode => 'my publishercode',
152 suggestedby => undef,
153 biblionumber => $biblio_1->biblionumber,
157 accepteddate => dt_from_string,
159 quantity => '', # Insert an empty string into int to catch strict SQL modes errors
162 my $my_suggestionid = NewSuggestion($my_suggestion);
163 isnt( $my_suggestionid, 0, 'NewSuggestion returns an not null id' );
164 my $my_suggestionid_with_budget = NewSuggestion($my_suggestion_with_budget);
166 is( GetSuggestion(), undef, 'GetSuggestion without the suggestion id returns undef' );
167 my $suggestion = GetSuggestion($my_suggestionid);
168 is( $suggestion->{title}, $my_suggestion->{title}, 'NewSuggestion stores the title correctly' );
169 is( $suggestion->{author}, $my_suggestion->{author}, 'NewSuggestion stores the author correctly' );
170 is( $suggestion->{publishercode}, $my_suggestion->{publishercode}, 'NewSuggestion stores the publishercode correctly' );
171 is( $suggestion->{suggestedby}, $my_suggestion->{suggestedby}, 'NewSuggestion stores the borrower number correctly' );
172 is( $suggestion->{biblionumber}, $my_suggestion->{biblionumber}, 'NewSuggestion stores the biblio number correctly' );
173 is( $suggestion->{STATUS}, 'ASKED', 'NewSuggestion stores a suggestion with the status ASKED by default' );
174 is( $suggestion->{managedby}, undef, 'NewSuggestion stores empty string as undef for non existent foreign key (integer)' );
175 is( $suggestion->{manageddate}, undef, 'NewSuggestion stores empty string as undef for date' );
176 is( $suggestion->{budgetid}, undef, 'NewSuggestion should set budgetid to NULL if not given' );
178 is( ModSuggestion(), undef, 'ModSuggestion without the suggestion returns undef' );
179 my $mod_suggestion1 = {
180 title => 'my modified title',
181 author => 'my modified author',
182 publishercode => 'my modified publishercode',
186 my $status = ModSuggestion($mod_suggestion1);
187 is( $status, undef, 'ModSuggestion without the suggestion id returns undef' );
189 $mod_suggestion1->{suggestionid} = $my_suggestionid;
190 $status = ModSuggestion($mod_suggestion1);
191 is( $status, 1, 'ModSuggestion modifies one entry' );
192 $suggestion = GetSuggestion($my_suggestionid);
193 is( $suggestion->{title}, $mod_suggestion1->{title}, 'ModSuggestion modifies the title correctly' );
194 is( $suggestion->{author}, $mod_suggestion1->{author}, 'ModSuggestion modifies the author correctly' );
195 is( $suggestion->{publishercode}, $mod_suggestion1->{publishercode}, 'ModSuggestion modifies the publishercode correctly' );
196 is( $suggestion->{managedby}, undef, 'ModSuggestion stores empty string as undef for non existent foreign key (integer)' );
197 is( $suggestion->{manageddate}, undef, 'ModSuggestion stores empty string as undef for date' );
198 isnt( $suggestion->{accepteddate}, undef, 'ModSuggestion does not update a non given date value' );
199 is( $suggestion->{note}, 'my note', 'ModSuggestion should not erase data if not given' );
201 my $messages = C4::Letters::GetQueuedMessages({
202 borrowernumber => $borrowernumber
204 is( @$messages, 0, 'ModSuggestions does not send an email if the status is not updated' );
206 my $authorised_value = Koha::AuthorisedValue->new(
208 category => 'SUGGEST_STATUS',
209 authorised_value => 'STALLED'
212 my $mod_suggestion2 = {
214 suggestionid => $my_suggestionid,
216 warning_is { $status = ModSuggestion($mod_suggestion2) }
217 "No suggestions STALLED letter transported by email",
218 "ModSuggestion status warning is correct";
219 is( $status, 1, "ModSuggestion Status OK");
221 my $mod_suggestion3 = {
223 suggestionid => $my_suggestionid,
226 #Test the message_transport_type of suggestion notices
228 #Check the message_transport_type when the 'FallbackToSMSIfNoEmail' syspref is disabled
229 t::lib::Mocks::mock_preference( 'FallbackToSMSIfNoEmail', 0 );
230 $status = ModSuggestion($mod_suggestion3);
231 is( $status, 1, 'ModSuggestion modifies one entry' );
232 $suggestion = GetSuggestion($my_suggestionid);
233 is( $suggestion->{STATUS}, $mod_suggestion3->{STATUS}, 'ModSuggestion modifies the status correctly' );
234 $messages = C4::Letters::GetQueuedMessages({
235 borrowernumber => $borrowernumber
237 is( @$messages, 1, 'ModSuggestion sends an email if the status is updated' );
238 is ($messages->[0]->{message_transport_type}, 'email', 'When FallbackToSMSIfNoEmail syspref is disabled the suggestion message_transport_type is always email');
240 #Check the message_transport_type when the 'FallbackToSMSIfNoEmail' syspref is enabled and the borrower has a smsalertnumber and no email
241 t::lib::Mocks::mock_preference( 'FallbackToSMSIfNoEmail', 1 );
242 ModSuggestion($mod_suggestion3);
243 $messages = C4::Letters::GetQueuedMessages({
244 borrowernumber => $borrowernumber
246 is ($messages->[1]->{message_transport_type}, 'sms', 'When FallbackToSMSIfNoEmail syspref is enabled the suggestion message_transport_type is sms if the borrower has no email');
248 #Make a new suggestion for a borrower with defined email and no smsalertnumber
249 my $my_suggestion_2_id = NewSuggestion($my_suggestion_with_budget2);
251 #Check the message_transport_type when the 'FallbackToSMSIfNoEmail' syspref is enabled and the borrower has a defined email and no smsalertnumber
252 t::lib::Mocks::mock_preference( 'FallbackToSMSIfNoEmail', 1 );
253 my $mod_suggestion4 = {
255 suggestionid => $my_suggestion_2_id,
257 ModSuggestion($mod_suggestion4);
258 $messages = C4::Letters::GetQueuedMessages({
259 borrowernumber => $borrowernumber2
261 is ($messages->[0]->{message_transport_type}, 'email', 'When FallbackToSMSIfNoEmail syspref is enabled the suggestion message_transport_type is email if the borrower has an email');
264 # Hiding the expected warning displayed by DBI
265 # DBD::mysql::st execute failed: Incorrect date value: 'invalid date!' for column 'manageddate'
267 open STDERR, '>', '/dev/null';
269 $mod_suggestion4->{manageddate} = 'invalid date!';
270 ModSuggestion($mod_suggestion4);
271 $messages = C4::Letters::GetQueuedMessages({
272 borrowernumber => $borrowernumber2
276 is (scalar(@$messages), 1, 'No new letter should have been generated if the update raised an error');
279 is( GetSuggestionInfo(), undef, 'GetSuggestionInfo without the suggestion id returns undef' );
280 $suggestion = GetSuggestionInfo($my_suggestionid);
281 is( $suggestion->{suggestionid}, $my_suggestionid, 'GetSuggestionInfo returns the suggestion id correctly' );
282 is( $suggestion->{title}, $mod_suggestion1->{title}, 'GetSuggestionInfo returns the title correctly' );
283 is( $suggestion->{author}, $mod_suggestion1->{author}, 'GetSuggestionInfo returns the author correctly' );
284 is( $suggestion->{publishercode}, $mod_suggestion1->{publishercode}, 'GetSuggestionInfo returns the publisher code correctly' );
285 is( $suggestion->{suggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionInfo returns the borrower number correctly' );
286 is( $suggestion->{biblionumber}, $my_suggestion->{biblionumber}, 'GetSuggestionInfo returns the biblio number correctly' );
287 is( $suggestion->{STATUS}, $mod_suggestion3->{STATUS}, 'GetSuggestionInfo returns the status correctly' );
288 is( $suggestion->{surnamesuggestedby}, $member->{surname}, 'GetSuggestionInfo returns the surname correctly' );
289 is( $suggestion->{firstnamesuggestedby}, $member->{firstname}, 'GetSuggestionInfo returns the firstname correctly' );
290 is( $suggestion->{borrnumsuggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionInfo returns the borrower number correctly' );
293 is( GetSuggestionFromBiblionumber(), undef, 'GetSuggestionFromBiblionumber without the biblio number returns undef' );
294 is( GetSuggestionFromBiblionumber(2), undef, 'GetSuggestionFromBiblionumber with an invalid biblio number returns undef' );
295 is( GetSuggestionFromBiblionumber($biblio_1->biblionumber), $my_suggestionid, 'GetSuggestionFromBiblionumber functions correctly' );
298 is( GetSuggestionInfoFromBiblionumber(), undef, 'GetSuggestionInfoFromBiblionumber without the biblio number returns undef' );
299 is( GetSuggestionInfoFromBiblionumber(2), undef, 'GetSuggestionInfoFromBiblionumber with an invalid biblio number returns undef' );
300 $suggestion = GetSuggestionInfoFromBiblionumber($biblio_1->biblionumber);
301 is( $suggestion->{suggestionid}, $my_suggestionid, 'GetSuggestionInfoFromBiblionumber returns the suggestion id correctly' );
302 is( $suggestion->{title}, $mod_suggestion1->{title}, 'GetSuggestionInfoFromBiblionumber returns the title correctly' );
303 is( $suggestion->{author}, $mod_suggestion1->{author}, 'GetSuggestionInfoFromBiblionumber returns the author correctly' );
304 is( $suggestion->{publishercode}, $mod_suggestion1->{publishercode}, 'GetSuggestionInfoFromBiblionumber returns the publisher code correctly' );
305 is( $suggestion->{suggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionInfoFromBiblionumber returns the borrower number correctly' );
306 is( $suggestion->{biblionumber}, $my_suggestion->{biblionumber}, 'GetSuggestionInfoFromBiblionumber returns the biblio number correctly' );
307 is( $suggestion->{STATUS}, $mod_suggestion3->{STATUS}, 'GetSuggestionInfoFromBiblionumber returns the status correctly' );
308 is( $suggestion->{surnamesuggestedby}, $member->{surname}, 'GetSuggestionInfoFromBiblionumber returns the surname correctly' );
309 is( $suggestion->{firstnamesuggestedby}, $member->{firstname}, 'GetSuggestionInfoFromBiblionumber returns the firstname correctly' );
310 is( $suggestion->{borrnumsuggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionInfoFromBiblionumeber returns the borrower number correctly' );
313 my $suggestions = GetSuggestionByStatus();
314 is( @$suggestions, 0, 'GetSuggestionByStatus without the status returns an empty array' );
315 $suggestions = GetSuggestionByStatus('CHECKED');
316 is( @$suggestions, 2, 'GetSuggestionByStatus returns the correct number of suggestions' );
317 is( $suggestions->[0]->{suggestionid}, $my_suggestionid, 'GetSuggestionByStatus returns the suggestion id correctly' );
318 is( $suggestions->[0]->{title}, $mod_suggestion1->{title}, 'GetSuggestionByStatus returns the title correctly' );
319 is( $suggestions->[0]->{author}, $mod_suggestion1->{author}, 'GetSuggestionByStatus returns the author correctly' );
320 is( $suggestions->[0]->{publishercode}, $mod_suggestion1->{publishercode}, 'GetSuggestionByStatus returns the publisher code correctly' );
321 is( $suggestions->[0]->{suggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionByStatus returns the borrower number correctly' );
322 is( $suggestions->[0]->{biblionumber}, $my_suggestion->{biblionumber}, 'GetSuggestionByStatus returns the biblio number correctly' );
323 is( $suggestions->[0]->{STATUS}, $mod_suggestion3->{STATUS}, 'GetSuggestionByStatus returns the status correctly' );
324 is( $suggestions->[0]->{surnamesuggestedby}, $member->{surname}, 'GetSuggestionByStatus returns the surname correctly' );
325 is( $suggestions->[0]->{firstnamesuggestedby}, $member->{firstname}, 'GetSuggestionByStatus returns the firstname correctly' );
326 is( $suggestions->[0]->{branchcodesuggestedby}, $member->{branchcode}, 'GetSuggestionByStatus returns the branch code correctly' );
327 is( $suggestions->[0]->{borrnumsuggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionByStatus returns the borrower number correctly' );
328 is( $suggestions->[0]->{categorycodesuggestedby}, $member->{categorycode}, 'GetSuggestionByStatus returns the category code correctly' );
331 is( ConnectSuggestionAndBiblio(), '0E0', 'ConnectSuggestionAndBiblio without arguments returns 0E0' );
332 my $biblio_2 = $builder->build_object({ class => 'Koha::Biblios' });
333 my $connect_suggestion_and_biblio = ConnectSuggestionAndBiblio($my_suggestionid, $biblio_2->biblionumber);
334 is( $connect_suggestion_and_biblio, '1', 'ConnectSuggestionAndBiblio returns 1' );
335 $suggestion = GetSuggestion($my_suggestionid);
336 is( $suggestion->{biblionumber}, $biblio_2->biblionumber, 'ConnectSuggestionAndBiblio updates the biblio number correctly' );
338 my $del_suggestion = {
339 title => 'my deleted title',
341 suggestedby => $borrowernumber,
343 my $del_suggestionid = NewSuggestion($del_suggestion);
345 is( DelSuggestion(), '0E0', 'DelSuggestion without arguments returns 0E0' );
346 is( DelSuggestion($borrowernumber), '', 'DelSuggestion without the suggestion id returns an empty string' );
347 is( DelSuggestion(undef, $my_suggestionid), '', 'DelSuggestion with an invalid borrower number returns an empty string' );
348 $suggestion = DelSuggestion($borrowernumber, $my_suggestionid);
349 is( $suggestion, 1, 'DelSuggestion deletes one suggestion' );
351 $suggestions = GetSuggestionByStatus('CHECKED');
352 is( @$suggestions, 2, 'DelSuggestion deletes one suggestion' );
353 is( $suggestions->[1]->{title}, $del_suggestion->{title}, 'DelSuggestion deletes the correct suggestion' );
356 $my_suggestion->{budgetid} = ''; # If budgetid == '', NULL should be set in DB
357 my $my_suggestionid_test_budgetid = NewSuggestion($my_suggestion);
358 $suggestion = GetSuggestion($my_suggestionid_test_budgetid);
359 is( $suggestion->{budgetid}, undef, 'NewSuggestion Should set budgetid to NULL if equals an empty string' );
361 $my_suggestion->{budgetid} = ''; # If budgetid == '', NULL should be set in DB
362 ModSuggestion( $my_suggestion );
363 $suggestion = GetSuggestion($my_suggestionid_test_budgetid);
364 is( $suggestion->{budgetid}, undef, 'NewSuggestion Should set budgetid to NULL if equals an empty string' );
367 title => "Cuisine d'automne",
368 author => "Catherine",
372 my $record = MarcRecordFromNewSuggestion($suggestion2);
374 is("MARC::Record", ref($record), "MarcRecordFromNewSuggestion should return a MARC::Record object");
376 my ($title_tag, $title_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.title', '');
378 is($record->field( $title_tag )->subfield( $title_subfield ), "Cuisine d'automne", "Record from suggestion title should be 'Cuisine d'automne'");
380 my ($author_tag, $author_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.author', '');
382 is($record->field( $author_tag )->subfield( $author_subfield ), "Catherine", "Record from suggestion author should be 'Catherine'");
384 subtest 'GetUnprocessedSuggestions' => sub {
386 $dbh->do(q|DELETE FROM suggestions|);
387 my $my_suggestionid = NewSuggestion($my_suggestion);
388 my $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
389 is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should return 0 if a suggestion has been processed but not linked to a fund' );
390 my $status = ModSuggestion($mod_suggestion1);
391 my $suggestion = GetSuggestion($my_suggestionid);
392 is( $suggestion->{budgetid}, undef, 'ModSuggestion should set budgetid to NULL if not given' );
393 ModSuggestion( { suggestionid => $my_suggestionid, budgetid => $budget_id } );
394 $suggestion = GetSuggestion($my_suggestionid);
395 is( $suggestion->{budgetid}, $budget_id, 'ModSuggestion should modify budgetid if given' );
397 $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
398 is( scalar(@$unprocessed_suggestions), 1, 'GetUnprocessedSuggestions should return the suggestion if the suggestion is linked to a fund and has not been processed yet' );
400 warning_is { ModSuggestion( { suggestionid => $my_suggestionid, STATUS => 'REJECTED' } ) }
401 'No suggestions REJECTED letter transported by email',
402 'Warning raised if no REJECTED letter by email';
403 $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
404 is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should return the suggestion if the suggestion is linked to a fund and has not been processed yet' );
406 warning_is { ModSuggestion( { suggestionid => $my_suggestionid, STATUS => 'ASKED', suggesteddate => dt_from_string->add_duration( DateTime::Duration->new( days => -4 ) ) } ); }
407 'No suggestions ASKED letter transported by email',
408 'Warning raised if no ASKED letter by email';
409 $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
410 is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should use 0 as default value for days' );
411 $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions(4);
412 is( scalar(@$unprocessed_suggestions), 1, 'GetUnprocessedSuggestions should return the suggestion suggested 4 days ago' );
413 $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions(3);
414 is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should not return the suggestion, it has not been suggested 3 days ago' );
415 $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions(5);
416 is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should not return the suggestion, it has not been suggested 5 days ago' );
419 subtest 'DelSuggestionsOlderThan' => sub {
422 Koha::Suggestions->delete;
424 # Add four suggestions; note that STATUS needs uppercase (FIXME)
425 my $d1 = output_pref({ dt => dt_from_string->add(days => -2), dateformat => 'sql' });
426 my $d2 = output_pref({ dt => dt_from_string->add(days => -4), dateformat => 'sql' });
427 my $sugg01 = $builder->build({ source => 'Suggestion', value => { manageddate => $d1, date => $d2, STATUS => 'ASKED' }});
428 my $sugg02 = $builder->build({ source => 'Suggestion', value => { manageddate => $d1, date => $d2, STATUS => 'CHECKED' }});
429 my $sugg03 = $builder->build({ source => 'Suggestion', value => { manageddate => $d2, date => $d2, STATUS => 'ASKED' }});
430 my $sugg04 = $builder->build({ source => 'Suggestion', value => { manageddate => $d2, date => $d2, STATUS => 'ACCEPTED' }});
432 # Test no parameter: should do nothing
433 C4::Suggestions::DelSuggestionsOlderThan();
434 is( Koha::Suggestions->count, 4, 'No suggestions deleted' );
435 # Test zero: should do nothing too
436 C4::Suggestions::DelSuggestionsOlderThan(0);
437 is( Koha::Suggestions->count, 4, 'No suggestions deleted again' );
438 # Test negative value
439 C4::Suggestions::DelSuggestionsOlderThan(-1);
440 is( Koha::Suggestions->count, 4, 'No suggestions deleted for -1' );
442 # Test positive values
443 C4::Suggestions::DelSuggestionsOlderThan(5);
444 is( Koha::Suggestions->count, 4, 'No suggestions>5d deleted' );
445 C4::Suggestions::DelSuggestionsOlderThan(3);
446 is( Koha::Suggestions->count, 3, '1 suggestions>3d deleted' );
447 C4::Suggestions::DelSuggestionsOlderThan(1);
448 is( Koha::Suggestions->count, 2, '1 suggestions>1d deleted' );
451 subtest 'EmailPurchaseSuggestions' => sub {
454 $dbh->do(q|DELETE FROM message_queue|);
456 t::lib::Mocks::mock_preference( "KohaAdminEmailAddress",
457 'noreply@hosting.com' );
459 # EmailPurchaseSuggestions set to disabled
460 t::lib::Mocks::mock_preference( "EmailPurchaseSuggestions", "0" );
461 NewSuggestion($my_suggestion);
462 my $newsuggestions_messages = C4::Letters::GetQueuedMessages(
464 borrowernumber => $borrowernumber
467 is( @$newsuggestions_messages, 0,
468 'NewSuggestions does not send an email when disabled' );
470 # EmailPurchaseSuggestions set to BranchEmailAddress
471 t::lib::Mocks::mock_preference( "EmailPurchaseSuggestions",
472 "BranchEmailAddress" );
473 NewSuggestion($my_suggestion);
475 t::lib::Mocks::mock_preference( "ReplytoDefault", 'library@b.c' );
476 NewSuggestion($my_suggestion);
478 Koha::Libraries->find('CPL')->update( { branchemail => 'branchemail@hosting.com' } );
479 NewSuggestion($my_suggestion);
481 Koha::Libraries->find('CPL')->update( { branchreplyto => 'branchemail@b.c' } );
482 NewSuggestion($my_suggestion);
484 $newsuggestions_messages = C4::Letters::GetQueuedMessages(
486 borrowernumber => $borrowernumber
489 isnt( @$newsuggestions_messages, 0, 'NewSuggestions sends an email' );
491 C4::Letters::GetMessage( $newsuggestions_messages->[0]->{message_id} );
492 is( $message1->{to_address}, 'noreply@hosting.com',
493 'BranchEmailAddress falls back to KohaAdminEmailAddress if branchreplyto, branchemail and ReplytoDefault are not set'
496 C4::Letters::GetMessage( $newsuggestions_messages->[1]->{message_id} );
497 is( $message2->{to_address}, 'library@b.c',
498 'BranchEmailAddress falls back to ReplytoDefault if neither branchreplyto or branchemail are set'
501 C4::Letters::GetMessage( $newsuggestions_messages->[2]->{message_id} );
502 is( $message3->{to_address}, 'branchemail@hosting.com',
503 'BranchEmailAddress uses branchemail if branch_replto is not set'
506 C4::Letters::GetMessage( $newsuggestions_messages->[3]->{message_id} );
507 is( $message4->{to_address}, 'branchemail@b.c',
508 'BranchEmailAddress uses branchreplyto in preference to branchemail when set'
511 # EmailPurchaseSuggestions set to KohaAdminEmailAddress
512 t::lib::Mocks::mock_preference( "EmailPurchaseSuggestions",
513 "KohaAdminEmailAddress" );
515 t::lib::Mocks::mock_preference( "ReplytoDefault", undef );
516 NewSuggestion($my_suggestion);
518 t::lib::Mocks::mock_preference( "ReplytoDefault", 'library@b.c' );
519 NewSuggestion($my_suggestion);
521 $newsuggestions_messages = C4::Letters::GetQueuedMessages(
523 borrowernumber => $borrowernumber
527 C4::Letters::GetMessage( $newsuggestions_messages->[4]->{message_id} );
528 is( $message5->{to_address},
529 'noreply@hosting.com', 'KohaAdminEmailAddress uses KohaAdminEmailAddress when ReplytoDefault is not set' );
531 C4::Letters::GetMessage( $newsuggestions_messages->[5]->{message_id} );
532 is( $message6->{to_address},
533 'library@b.c', 'KohaAdminEmailAddress uses ReplytoDefualt when ReplytoDefault is set' );
535 # EmailPurchaseSuggestions set to EmailAddressForSuggestions
536 t::lib::Mocks::mock_preference( "EmailPurchaseSuggestions",
537 "EmailAddressForSuggestions" );
539 t::lib::Mocks::mock_preference( "ReplytoDefault", undef );
540 NewSuggestion($my_suggestion);
542 t::lib::Mocks::mock_preference( "ReplytoDefault", 'library@b.c' );
543 NewSuggestion($my_suggestion);
545 t::lib::Mocks::mock_preference( "EmailAddressForSuggestions",
547 NewSuggestion($my_suggestion);
549 $newsuggestions_messages = C4::Letters::GetQueuedMessages(
551 borrowernumber => $borrowernumber
555 C4::Letters::GetMessage( $newsuggestions_messages->[6]->{message_id} );
556 is( $message7->{to_address},
557 'noreply@hosting.com', 'EmailAddressForSuggestions uses KohaAdminEmailAddress when neither EmailAddressForSuggestions or ReplytoDefault are set' );
560 C4::Letters::GetMessage( $newsuggestions_messages->[7]->{message_id} );
561 is( $message8->{to_address},
562 'library@b.c', 'EmailAddressForSuggestions uses ReplytoDefault when EmailAddressForSuggestions is not set' );
565 C4::Letters::GetMessage( $newsuggestions_messages->[8]->{message_id} );
566 is( $message9->{to_address},
567 'suggestions@b.c', 'EmailAddressForSuggestions uses EmailAddressForSuggestions when set' );
570 subtest 'ModSuggestion should work on suggestions without a suggester' => sub {
573 $dbh->do(q|DELETE FROM suggestions|);
574 my $my_suggestionid = NewSuggestion($my_suggestion_without_suggestedby);
575 $suggestion = GetSuggestion($my_suggestionid);
576 is( $suggestion->{suggestedby}, undef, "Suggestedby is undef" );
580 suggestionid => $my_suggestionid,
585 $suggestion = GetSuggestion($my_suggestionid);
587 is( $suggestion->{note}, "Test note", "ModSuggestion works on suggestions without a suggester" );
590 subtest 'Suggestion with ISBN' => sub {
591 my $suggestion_with_isbn = {
592 isbn => '1940997232',
593 title => "The Clouds",
594 author => "Aristophanes",
596 my $record = MarcRecordFromNewSuggestion( $suggestion_with_isbn );
597 is("MARC::Record", ref($record), "MarcRecordFromNewSuggestion should return a MARC::Record object");
599 my ($isbn_tag, $isbn_subfield) = C4::Biblio::GetMarcFromKohaField('biblioitems.isbn', '');
600 is($record->field( $isbn_tag )->subfield( $isbn_subfield ), "1940997232", "ISBN Record from suggestion ISBN should be '1940997232'");
602 my ($issn_tag, $issn_subfield) = C4::Biblio::GetMarcFromKohaField('biblioitems.issn', '');
603 is($record->field( $issn_tag )->subfield( $issn_subfield ), "1940997232", "ISSN Record from suggestion ISBN should also be '1940997232'");
605 my ($title_tag, $title_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.title', '');
606 is($record->field( $title_tag), undef, "Record from suggestion title should be empty");
608 my ($author_tag, $author_subfield) = C4::Biblio::GetMarcFromKohaField('biblio.author', '');
609 is($record->field( $author_tag), undef, "Record from suggestion author should be empty");
612 $schema->storage->txn_rollback;