]> git.koha-community.org Git - koha.git/commit
Bug 14969: Remove C4::Dates from serials/*.pl files
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 11 Nov 2015 10:48:36 +0000 (10:48 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Tue, 17 Nov 2015 18:35:57 +0000 (15:35 -0300)
commit018de8802d1aa8af9e309187c210f2036957e10a
tree1d18d435286c4e7beccdaa6be36551c0f517da9a
parent42ef8c7e98a7785de46ade8cc88bc904bbf6149e
Bug 14969: Remove C4::Dates from serials/*.pl files

Warning: This area is a mess, especially with date management.

For the same reasons as other "Remove C4::Dates from*" patches, this one
will deal with the serials module.

Note that this patch add the datepicker on 3 input fields (on
serials/subscription-detail.tt and serials/subscription-renew.tt).
There was also weird behavior when the dates were invalid. Now default
to undefined. But with the datepicker it will reduce the number of
cases even if the user is still allowed to fill invalid dates.

Test plan:
1/ Create a subscription, fill the first issue pub date and the
subscription start date.
You can fill or not the end date.
Play with the numbering pattern and confirm that there are generated as
before this patch.
2/ On the check expiration page, confirm that the dates are correctly
displayed.
3/ Renew the subscription and confirm that the behavior is correct.
4/ Go on the subscription history page and confirm you have now the
datepicker plugin set on the 2 date fields.

QA notes: The startdate, histstartdate and enddate are not used in
the serials-collection template, this patch removes them from the pl
script.

Tested on top of 15166 15168 15171, full browser reload for date pickers.
Note for 4/: It is the link in tab planning on subscription
detail page, near "Manual history" (if manual history is enabled).
Works as advertised.
Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
15 files changed:
C4/Serials.pm
koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-history.tt
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt
serials/checkexpiration.pl
serials/routing-preview.pl
serials/routing.pl
serials/serial-issues.pl
serials/serials-collection.pl
serials/serials-edit.pl
serials/showpredictionpattern.pl
serials/subscription-add.pl
serials/subscription-detail.pl
serials/subscription-history.pl
serials/subscription-renew.pl