]> git.koha-community.org Git - koha.git/commit
Bug 25297: Consistent return value in K::A::Order->current_item_level_holds
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 27 Apr 2020 21:55:59 +0000 (18:55 -0300)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 1 May 2020 07:16:38 +0000 (08:16 +0100)
commit15595a5f35a204ec26501a9a0fcec2d5a21f0e24
tree87628f68443ccbf9e2aeae54271c53be2c38fcbb
parente3382d89cd3616f171863e328abd0f83bbcebce8
Bug 25297: Consistent return value in K::A::Order->current_item_level_holds

This patch makes the return values for 'current_item_level_holds'
consistent: they will always be a Koha::Holds iterator.

To test:
1. Apply the regression tests
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Acquisition/Order.t
=> FAIL: It doesn't work as expected, cannot call ->count on undef, etc
3. Apply this patch
4. Repeat 2.
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Koha/Acquisition/Order.pm