]> git.koha-community.org Git - koha.git/commit
Bug 28928: Minor follow-ups to Bug 28376 - Flatpickr introduction
authorOwen Leonard <oleonard@myacpl.org>
Tue, 31 Aug 2021 12:09:44 +0000 (12:09 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 1 Sep 2021 13:46:01 +0000 (15:46 +0200)
commit1bd10a4a2e2c25a2b688f898d31f9ee1e6089e40
tree3f15954b127b82e2be15522380705889e23366a7
parent80b8c6e225e9987e96849f1b9257d2a67c7cf37c
Bug 28928: Minor follow-ups to Bug 28376 - Flatpickr introduction

This patch corrects three errors in the original Flatpickr introduction
patch:

- Missing document.ready() in borrowers_stats.tt.
- Redundant calendarFirstDayOfWeek setting in caregories.js
- Missing preventDefault() in calendar.inc

The first two issues don't appear to cause any malfunction but are best
practices. The third issue can cause the page to scroll unexpectedly.

To reproduce this bug, go to (for instance) Administration -> Patron
categories -> New category.

 - If necessary, narrow the height of your browser window so that there
   is a vertical scrollbar.
 - Scroll down the page so that the "Until date" field is at the top.
 - Click the "X" next to the field.
 - The page will scroll to the top.

Apply the patch and test again. The page jump should not occur.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc
koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt
koha-tmpl/intranet-tmpl/prog/js/categories.js