Bug 23575: Template error causes item search to be submitted multiple times
authorOwen Leonard <oleonard@myacpl.org>
Mon, 9 Sep 2019 16:58:04 +0000 (16:58 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 19 Sep 2019 15:45:38 +0000 (17:45 +0200)
commit3cf3782a6097067d57030772417c3a2fe5cc9566
tree54b11b2b668477b98f61e5fd55783a25881000a8
parent4c15068ec0f6b113ecb227d9afd2bbae7624661e
Bug 23575: Template error causes item search to be submitted multiple times

This patch corrects the item search template so that the submit handler
is not nested inside an unrelated loop. The change should have no
outward effect on the behavior of the item search other than making it
faster.

To observe the bug in action, open your browser's developer tools and
click the "Network" tab. Filter the output to only "XHR" and perform an
item search. You should see multiple requests.

To test, apply the patch and perform an item search. It should behave
normally.

Check the browser's "Network" monitor again to verify that only one
request is being sent.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 075261645e1650629038c9a09e8d9e387bcc5474)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt