Bug 21886: (QA follow-up) Fix indentation, prevent warns, fix parameter, simplify SQL
authorNick Clemens <nick@bywatersolutions.com>
Tue, 1 Dec 2020 12:50:28 +0000 (12:50 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 4 Jan 2021 15:33:15 +0000 (16:33 +0100)
commit41bca0e0ca42429cead48f647a9b3533de5d1670
tree0e26435a278d8e680ccce0ffc0bc4d525b76fe5b
parent12d8b26bc2a617ded8959da3688860a17e77d4a3
Bug 21886: (QA follow-up) Fix indentation, prevent warns, fix parameter, simplify SQL

The SQL code was duplicated, I combine them here

frombranch needs to take input

switch owning to frombranch in second script

initialize hash as empty list, not a reference

add a newline after printed output if not mailing notices

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Circulation.pm
misc/cronjobs/advance_notices.pl
misc/cronjobs/overdue_notices.pl