]> git.koha-community.org Git - koha.git/commit
Bug 11680: fix case where tax rate changes unexpectedly on editing an order
authorJacek Ablewicz <abl@biblos.pk.edu.pl>
Wed, 5 Feb 2014 10:16:14 +0000 (11:16 +0100)
committerGalen Charlton <gmc@esilibrary.com>
Fri, 18 Apr 2014 22:13:48 +0000 (22:13 +0000)
commit471215dc46e5a65360a3bde53666f62f809f0861
tree3a00dcfb74d1ecdb240384113acdd431ccaf5073
parent378bffa0ddbe793dff75a828e2bf5b03ad666b57
Bug 11680: fix case where tax rate changes unexpectedly on editing an order

If the tax rates in Acquisitions -> gist system preference are entered
with trailing zeroes, given order tax rate value may not be correctly
handled on order edit.

To test:

1) insert some tax rates with trailing zeroes in gist
system preference (e.g: '0|0.080|0.12|0.20|0.23')
2) place some new orders, choosing 8.0% 12.0% 20.0% 23.0%
as gst rate
3) try to modify them
4) note that orders with 12.0% and 23.0% tax rates are
preserving previously choosen rates on edit, while
the ones with 8.0% and 20.0% do not (they are defaulting
to the first defined tax rate)
5) apply the patch
6) repeat 2) and 3)
7) all tax rates configured in system prefrence shall now
behave properly while editing orders

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
All tests pass

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Confirmed the problem and that this patch fixes it.
Problem also exists for editing the default tax rate of a vendor.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
acqui/neworderempty.pl