]> git.koha-community.org Git - koha.git/commit
Bug 27566: (follow-up) Add generic font family to prevent unstyled select tags
authorOwen Leonard <oleonard@myacpl.org>
Wed, 7 Apr 2021 13:43:40 +0000 (13:43 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 23 Apr 2021 08:03:37 +0000 (10:03 +0200)
commit4cc224baa77b9879ee64691c8dec565a489f83f4
tree2c4ecb3911359e4bd0f1aa60c566f13964c2f50a
parent34575f1f1a063380c1e3f05dd300302bc42ac460
Bug 27566: (follow-up) Add generic font family to prevent unstyled select tags

This correction fixes the previous patch which was dumb and stupid.

This patch adds a default font family "sans-serif" to the OPAC CSS as a
workaround for this Firefox bug:

font-family isn't honored in `<option>` element within `<select>`
dropdown
https://bugzilla.mozilla.org/show_bug.cgi?id=1536148

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

 - Open the OPAC main page in Firefox.
 - Click the search type dropdown. The options should be styled using
   your system's default sans-serif font rather than a serif font.
 - Check that other areas of the OPAC are still styled with the correct
   "NotoSans" font. An error with this patch should be obvious when
   looking at a logged-in user's checkouts.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss
koha-tmpl/opac-tmpl/bootstrap/css/src/_fonts.scss