]> git.koha-community.org Git - koha.git/commit
Bug 22847: Correctly displayed circ rule values for max_holds and maxissue*
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 3 May 2019 21:34:22 +0000 (17:34 -0400)
committerNick Clemens <nick@bywatersolutions.com>
Thu, 9 May 2019 14:32:27 +0000 (14:32 +0000)
commit503842ac6c37cdbab2a8868604bd6f1294c829b1
tree820382c0badb6d48b689244f9474274313e0b135
parentd38d78bcf4cc62d34aa953864cf6da87bef93c80
Bug 22847: Correctly displayed circ rule values for max_holds and maxissue*

There are several things going wrong on the circulation rules screen. The global rule is displayed for specific libraries (even if the rule does not exist for the library), and max_holds is always blank.

I have trouble finding the root of the issue, but I will propose a patch to fix both problem.

Certainly a mismatch between bug 18887 and bug 18925.

Test plan:
0. Do not apply the patch
1. Notice the issue on the circulation rules screen
2. Apply the patch
3. Confirm that the value you set are correctly displayed (and not the propagated ones!)

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Signed-off-by: Agustin Moyano <agustinmoyano@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Koha/Template/Plugin/CirculationRules.pm
koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt