Bug 25726: make holds to pull ignore holds where found is not null and itemnumber...
authorAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Fri, 12 Jun 2020 13:51:16 +0000 (13:51 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 20 Jul 2020 10:37:21 +0000 (12:37 +0200)
commit56220d211d7b5c4e2622787f9ea38ab12c8868f5
tree061a27600b8d12e4494863ada2f18953bfd71a10
parent981b601c39e97e23d309fe342c00a819a9ee8ad6
Bug 25726: make holds to pull ignore holds where found is not null and itemnumber is null

To test:
1- place 2 bib-level holds on available items
2- confirm they both show on Holds to Pull
3- edit one hold from the database to set found='T'
4- reload Holds to Pull, confirm it is now empty
5- apply patch
6- Reload Holds to Pull
7- confirm it now shows the hold you did not edit

Signed-off-by: donnab <donna@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
[EDIT] Using capitals for SQL reserved words; added a FIXME
Tested with:
    update reserves set found='T', itemnumber=NULL where reserve_id=...
This should be a workaround while we fix the underlying problem.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
circ/pendingreserves.pl