]> git.koha-community.org Git - koha.git/commit
Bug 11056: Delete dead code in basketgroup.pl
authorMathieu Saby <mathieu.saby@univ-rennes2.fr>
Wed, 18 Dec 2013 17:04:25 +0000 (18:04 +0100)
committerGalen Charlton <gmc@esilibrary.com>
Fri, 17 Jan 2014 21:17:58 +0000 (21:17 +0000)
commit59c0a0e02b9b4dd179c99c31ebbd13e70f266d77
tree458e1c21d2c53dc15095d9d54b1bfbae61afff5b
parentebe92b97ea3082da4de7901971f681b09d3eb265
Bug 11056: Delete dead code in basketgroup.pl

In basketgroup.pl, some code is supposed to be executed if
$op = "validate".  But this value is no longer assigned to
the $op variable since 2009.

This patch suppressed dead code, along with parseinputbaskets
and parseinputbasketgroups subs, which are obsolete.

No functional changes expected

Regression test :
* Check basketgroup are shown as before the patch, and can be closed
 and reopened.
* Check you can add or remove a basket from a basketgroup, and change
  information about it (like delivery place)
* Check you can create a basketgroup when you close a basket.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
The following commands return nothing:
- grep validate acqui/basketgroup.tt
- grep -R basketgroup.pl -C 2 | grep validate
- git grep parseinputbaskets
- git grep parseinputbasketgroups
- git grep basketgroup.pl | grep validate

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
acqui/basketgroup.pl