]> git.koha-community.org Git - koha.git/commit
Bug 31782: Remove js/autocomplete/patrons.js
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 11 Nov 2022 11:17:28 +0000 (12:17 +0100)
committerTomas Cohen Arazi <tomascohen@theke.io>
Mon, 14 Nov 2022 12:13:49 +0000 (09:13 -0300)
commit6df74598ebd2f18320540fc32e7249dfe8239f67
tree0a83a6111de83c1dbf6f934a6fe25200fa077a1a
parent9800cfbca282267ebff4db7bb8c8fe737a43f30b
Bug 31782: Remove js/autocomplete/patrons.js

On 30578 we replace circ/ysearch.pl with a call to the /api/v1/patrons
route. A new patron_autocomplete JS function has been written
(js/patron-autocomplete.js) for that purpose.

However 3 occurrences were using an existing patron_autocomplete
function, and 30578 didn't take care of adjusting correctly the call to
the REST API route.

On this patchset I am suggesting to copy/paste the JS functions defined
in js/autocomplete/patrons.js, because we are very close of the 22.11
release. But ideally we should improve js/patron-autocomplete.js to add
a new 'on-select-add-to' option that will take care of add/remove/hide
behaviour. IMO that must be done on a separate bug, and after 22.11 is
released (to not need to retest the other occurrences of the patron
autocomplete)

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
koha-tmpl/intranet-tmpl/js/autocomplete/patrons.js [deleted file]