]> git.koha-community.org Git - koha.git/commit
Bugfix 2026 - Comments handling overhauled. Scrubber and Error feedback added.
authorJoe Atzberger <joe.atzberger@liblime.com>
Thu, 22 May 2008 20:10:22 +0000 (15:10 -0500)
committerJoshua Ferraro <jmf@liblime.com>
Thu, 29 May 2008 11:51:58 +0000 (06:51 -0500)
commit70829660c2cd0f464ea643437e7fa607c5d8d4ba
tree4e846814a558830b0c986f77217b1da27f2149c8
parent74d3dc35ee8cf5eefd0ce12c9ef582c3efeae48b
Bugfix 2026 - Comments handling overhauled. Scrubber and Error feedback added.

Note: we CANNOT rely on window.close in onSubmit or $().submit to close our popups.
On a relatively slow connection with a relatively large POST, commonly the close finishes
*before* the POST completes, as reported with our New Zealand clients.  Despite success in
trivial cases, this should be obvious, since the event is necessarily before the submission.
It also assumes success and prevents any kind of error feedback.  Other popups are likely
to exhibit this same defective behavior.

Some FIXME's outstanding: need to allow users to delete their own comments,
need to enforce and feedback on max comment length.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tmpl
opac/opac-review.pl