]> git.koha-community.org Git - koha.git/commit
Bug 28125: Display a warning on the about page for OPACHiddenItems is needed
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 13 Apr 2021 08:47:19 +0000 (10:47 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 16 Apr 2021 10:28:17 +0000 (12:28 +0200)
commit71574961f7322e04e996b11f9932b2006ea93215
tree81206ff52d6124ea6cd793b83391eff85e3316d9
parent70239b355c6776065e20ed371f93483b110b7cda
Bug 28125: Display a warning on the about page for OPACHiddenItems is needed

If OPACHiddenItems is containing badly construct it will lead to
inconsistent behaviours. For instance the holds view will not display
any items, when the detail page will display all of them (because we are
not using the same code, we are in transition to merge it).

This patch suggests to add a warning to the about page in case the query
generated by Koha::Items->filter_by_visible_in_opac produces a warning

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Bug 28125: (QA follow-up) Fix missing filter

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
about.pl
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
t/db_dependent/Koha/Items.t