]> git.koha-community.org Git - koha.git/commit
Bug 14200: GetNormalizedISBN failing to normalize valid ISBNs in some cases
authorKyle M Hall <kyle@bywatersolutions.com>
Thu, 14 May 2015 10:20:00 +0000 (06:20 -0400)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Tue, 19 May 2015 12:45:38 +0000 (09:45 -0300)
commit7507145a6ee7b56fb07fc28bc7d599638b3f4bf1
tree3b1225d07109117487eba4076cb5376f1d38e626
parent422ffc64060a44c4adeb86bb5325f0a4909f95be
Bug 14200: GetNormalizedISBN failing to normalize valid ISBNs in some cases

For some reason the regular expression used to split the multiple ISBN
fields can fail which keeps Business::ISBN from being able to parse out
and return a valid isbn. Using split() instead of the regex fixes the
issue.

Test Plan:
1) Apply the unit test patch first
2) prove t/Koha.t
3) Note the failures
4) Apply the second patch
5) prove t/Koha.t
6) Note all tests pass

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Karen Bryant <kbryant@ccpl-fl.net>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
C4/Koha.pm