]> git.koha-community.org Git - koha.git/commit
Bug 35935: Ensure login branch will be used after incorrect login
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 30 Jan 2024 08:02:19 +0000 (09:02 +0100)
committerLucas Gass <lucas@bywatersolutions.com>
Tue, 19 Mar 2024 15:00:07 +0000 (15:00 +0000)
commit7c0844109d62f16e1c1b7ba816b6ed7395de8b35
tree3892930d6f51be24d44547cf9ab0e4ac0d0d8f22
parentf018711df24855aab33af3835610ba092c10bd02
Bug 35935: Ensure login branch will be used after incorrect login

If a different branch is selected after an incorrect login, the previous
branch will be used.

To recreate:
* login with foo/bar, select CPL => FAIL
* login with koha/koha, select another branch => OK but CPL is picked!

It was caused by a dup of "branch" in CGI param list (and first was
picked).

This patch patch also removes "koha_login_context" to not have it twice.
You can also open the source of the page to confirm that form#loginform
contains "branch" and "koha_login_context" in hidden inputs.

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Tested in KTD. Works as advertised.
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 7c54394383234f33dcf5b6acb8ceabb72d0deca4)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit b94bb009dca187cba85c072f1d7e00af484bdcea)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt