]> git.koha-community.org Git - koha.git/commit
Bug 7932 [Revised] Twitter share doesn't work with socialnetworks
authorOwen Leonard <oleonard@myacpl.org>
Thu, 1 Nov 2012 15:21:37 +0000 (11:21 -0400)
committerJared Camins-Esakov <jcamins@cpbibliography.com>
Tue, 20 Nov 2012 12:36:00 +0000 (07:36 -0500)
commit7f45bb37dde58991b1b7521c5dac69f6fbd25e67
tree7ebd30bb10a5407a5c701679255d1c1e253a4e25
parentd44b552b3f22c7423038f831d622bfe67a543936
Bug 7932 [Revised] Twitter share doesn't work with socialnetworks

The only way I can get this to work consistently is to use
Twitter's own code as documented here:

https://dev.twitter.com/docs/tweet-button

This requires that we use the tweet button generated by Twitter
rather than the smaller image we were using before. Using the
documented options for generating a custom button produced the
same inconsistent behavior this patch attempts to fix.

Because of the change of appearance I moved the Twitter button
to last in line so that similarly-sized buttons were grouped. I
also changed the configuration of the Google+ button to exclude
the count, saving some horizontal space.

Revision removes explicit declaration of share URL. I think when
testing this previously I assumed it was required when in fact
the share URL wasn't working because it was a localhost address.

Localhost addresses are apparently rejected by Twitter. Testers
beware.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Passed-QA-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt